From: frowand.list@gmail.com (Frank Rowand)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] usb: Make sure usb/phy/of gets built-in
Date: Mon, 17 Apr 2017 20:15:21 -0700 [thread overview]
Message-ID: <58F584C9.3050607@gmail.com> (raw)
In-Reply-To: <1492086814-21006-1-git-send-email-abrodkin@synopsys.com>
On 04/13/17 05:33, Alexey Brodkin wrote:
> DWC3 driver uses of_usb_get_phy_mode() which is
> implemented in drivers/usb/phy/of.c and in bare minimal
> configuration it might not be pulled in kernel binary.
>
> In case of ARC or ARM this could be easily reproduced with
> "allnodefconfig" +CONFIG_USB=m +CONFIG_USB_DWC3=m.
>
> On building all ends-up with:
> ---------------------->8------------------
> Kernel: arch/arm/boot/Image is ready
> Kernel: arch/arm/boot/zImage is ready
> Building modules, stage 2.
> MODPOST 5 modules
> ERROR: "of_usb_get_phy_mode" [drivers/usb/dwc3/dwc3.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> ---------------------->8------------------
>
> Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> Cc: Geert Uytterhoeven <geert+renesas at glider.be>
> Cc: Nicolas Pitre <nicolas.pitre at linaro.org>
> Cc: Thomas Gleixner <tglx at linutronix.de>
> Cc: Felipe Balbi <balbi at kernel.org>
> Cc: Felix Fietkau <nbd at nbd.name>
> Cc: Jeremy Kerr <jk at ozlabs.org>
> Cc: linux-snps-arc at lists.infradead.org
> Cc: stable at vger.kernel.org
> ---
> drivers/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 2eced9afba53..8f8bdc9e3d29 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -104,6 +104,7 @@ obj-$(CONFIG_USB_PHY) += usb/
> obj-$(CONFIG_USB) += usb/
> obj-$(CONFIG_PCI) += usb/
> obj-$(CONFIG_USB_GADGET) += usb/
> +obj-$(CONFIG_OF) += usb/
Would CONFIG_USB_SUPPORT make more sense? (And does it work?)
> obj-$(CONFIG_SERIO) += input/serio/
> obj-$(CONFIG_GAMEPORT) += input/gameport/
> obj-$(CONFIG_INPUT) += input/
>
next prev parent reply other threads:[~2017-04-18 3:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 12:33 [PATCH] usb: Make sure usb/phy/of gets built-in Alexey Brodkin
2017-04-18 3:15 ` Frank Rowand [this message]
2017-04-18 12:23 ` Alexey Brodkin
2017-04-24 12:44 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58F584C9.3050607@gmail.com \
--to=frowand.list@gmail.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).