* [PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency
2017-04-21 10:15 ` [RESEND PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency Jose Abreu
@ 2017-03-02 17:35 ` Alexey Brodkin
0 siblings, 0 replies; 12+ messages in thread
From: Alexey Brodkin @ 2017-03-02 17:35 UTC (permalink / raw)
To: linux-snps-arc
Hi Jose,
On Wed, 2017-02-22@18:19 +0000, Jose Abreu wrote:
> Default clock frequency for ARC PGU does not match any
> existing HDMI mode, instead the default value matches a
> DVI mode. Change the clock frequency to 74.25MHz so that
> it matches HDMI mode 1280x720 at 60Hz
>
> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
> Cc: Carlos Palminha <palminha at synopsys.com>
> Cc: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Rob Herring <robh+dt at kernel.org>
> Cc: Vineet Gupta <vgupta at synopsys.com>
> Cc: devicetree at vger.kernel.org
> Cc: linux-snps-arc at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
> ?arch/arc/boot/dts/axs10x_mb.dtsi | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> index 9d882b1..41cfb29 100644
> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> @@ -51,7 +51,7 @@
> ? pguclk: pguclk {
> ? #clock-cells = <0>;
> ? compatible = "fixed-clock";
> - clock-frequency = <74440000>;
> + clock-frequency = <74250000>;
> ? };
> ? };
Looks good to me but I have to note that with this change in place
monitors that don't report [correct] EDID won't work just because
if EDID is missing Linux kernel calculates pixel clock on its
own and for 1280x720 at 60?it gets 74.40 MHz which obviously differs from
yours 74.25 MHz and so?arc_pgu_crtc_atomic_check() returns?-EINVAL.
But with the fix I just sent, see
http://lists.infradead.org/pipermail/linux-snps-arc/2017-March/002173.html
everything will work again.
And once Vlad's patch for AXS PLLs gets accepted we'll finally get
support of multiple modes on AXS10x boards.
That said...
Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback
2017-04-21 10:15 [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Jose Abreu
@ 2017-03-02 18:57 ` Alexey Brodkin
2017-03-20 14:02 ` Jose Abreu
2017-04-21 10:15 ` [RESEND PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency Jose Abreu
2017-04-24 17:36 ` [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Vineet Gupta
2 siblings, 1 reply; 12+ messages in thread
From: Alexey Brodkin @ 2017-03-02 18:57 UTC (permalink / raw)
To: linux-snps-arc
Hi Jose,
On Wed, 2017-02-22@18:19 +0000, Jose Abreu wrote:
> This patch adds the necessary DT bindings to get HDMI audio
> output in ARC AXS10x SDP. The bindings for I2S controller were
> added as well as the bindings for simple audio card.
>
> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
> Cc: Carlos Palminha <palminha at synopsys.com>
> Cc: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Rob Herring <robh+dt at kernel.org>
> Cc: Vineet Gupta <vgupta at synopsys.com>
> Cc: devicetree at vger.kernel.org
> Cc: linux-snps-arc at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
> ?arch/arc/boot/dts/axs10x_mb.dtsi | 22 ++++++++++++++++++----
> ?1 file changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> index d6c1bbc..9d882b1 100644
> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> @@ -149,12 +149,13 @@
> ? interrupts = <14>;
> ? };
> ?
> - i2c at 0x1e000 {
> - compatible = "snps,designware-i2c";
> + i2s: i2s at 1e000 {
> + compatible = "snps,designware-i2s";
> ? reg = <0x1e000 0x100>;
> - clock-frequency = <400000>;
> - clocks = <&i2cclk>;
> + clocks = <&i2sclk 0>;
> + clock-names = "i2sclk";
> ? interrupts = <15>;
> + #sound-dai-cells = <0>;
> ? };
> ?
> ? i2c at 0x1f000 {
> @@ -174,6 +175,7 @@
> ? adi,input-colorspace = "rgb";
> ? adi,input-clock = "1x";
> ? adi,clock-delay = <0x03>;
> + #sound-dai-cells = <0>;
> ?
> ? ports {
> ? #address-cells = <1>;
> @@ -295,5 +297,17 @@
> ? };
> ? };
> ? };
> +
> + sound_playback {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "AXS10x HDMI Audio";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,cpu {
> + sound-dai = <&i2s>;
> + };
> + simple-audio-card,codec {
> + sound-dai = <&adv7511>;
> + };
> + };
> ? };
> ?};
Just for the sake of history that's my mods to defconfig that allowed me
to play .pcm via HDMI from axs103 board:
-------------------------------->8-------------------------------
diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs103_smp_defconfig
index 30a3d4cf53d2..b11362a32e4e 100644
--- a/arch/arc/configs/axs103_smp_defconfig
+++ b/arch/arc/configs/axs103_smp_defconfig
@@ -67,25 +67,29 @@ CONFIG_MOUSE_PS2_TOUCHKIT=y
?CONFIG_MOUSE_SERIAL=y
?CONFIG_MOUSE_SYNAPTICS_USB=y
?# CONFIG_LEGACY_PTYS is not set
-# CONFIG_DEVKMEM is not set
?CONFIG_SERIAL_8250=y
?CONFIG_SERIAL_8250_CONSOLE=y
?CONFIG_SERIAL_8250_DW=y
?CONFIG_SERIAL_OF_PLATFORM=y
?# CONFIG_HW_RANDOM is not set
-CONFIG_I2C=y
?CONFIG_I2C_CHARDEV=y
?CONFIG_I2C_DESIGNWARE_PLATFORM=y
?# CONFIG_HWMON is not set
-CONFIG_DRM=m
-CONFIG_DRM_I2C_ADV7511=m
-CONFIG_DRM_ARCPGU=m
-CONFIG_FB=y
+CONFIG_DRM=y
+CONFIG_DRM_I2C_ADV7511=y
+CONFIG_DRM_I2C_ADV7511_AUDIO=y
+CONFIG_DRM_ARCPGU=y
?CONFIG_FRAMEBUFFER_CONSOLE=y
?CONFIG_LOGO=y
?# CONFIG_LOGO_LINUX_MONO is not set
?# CONFIG_LOGO_LINUX_VGA16 is not set
?# CONFIG_LOGO_LINUX_CLUT224 is not set
+CONFIG_SOUND=y
+CONFIG_SND=y
+CONFIG_SND_SOC=y
+CONFIG_SND_DESIGNWARE_I2S=y
+CONFIG_SND_DESIGNWARE_PCM=y
+CONFIG_SND_SIMPLE_CARD=y
?CONFIG_USB_EHCI_HCD=y
?CONFIG_USB_EHCI_HCD_PLATFORM=y
?CONFIG_USB_OHCI_HCD=y
-------------------------------->8-------------------------------
Anyways...
Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback
2017-03-02 18:57 ` [PATCH " Alexey Brodkin
@ 2017-03-20 14:02 ` Jose Abreu
2017-03-20 14:05 ` Alexey Brodkin
2017-03-29 13:38 ` Jose Abreu
0 siblings, 2 replies; 12+ messages in thread
From: Jose Abreu @ 2017-03-20 14:02 UTC (permalink / raw)
To: linux-snps-arc
Hi Vineet, Alexey, Rob,
On 02-03-2017 18:57, Alexey Brodkin wrote:
> Hi Jose,
>
> On Wed, 2017-02-22@18:19 +0000, Jose Abreu wrote:
>> This patch adds the necessary DT bindings to get HDMI audio
>> output in ARC AXS10x SDP. The bindings for I2S controller were
>> added as well as the bindings for simple audio card.
>>
>> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
>> Cc: Carlos Palminha <palminha at synopsys.com>
>> Cc: Alexey Brodkin <abrodkin at synopsys.com>
>> Cc: Rob Herring <robh+dt at kernel.org>
>> Cc: Vineet Gupta <vgupta at synopsys.com>
>> Cc: devicetree at vger.kernel.org
>> Cc: linux-snps-arc at lists.infradead.org
>> Cc: linux-kernel at vger.kernel.org
>> ---
>> arch/arc/boot/dts/axs10x_mb.dtsi | 22 ++++++++++++++++++----
>> 1 file changed, 18 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
>> index d6c1bbc..9d882b1 100644
>> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
>> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
>> @@ -149,12 +149,13 @@
>> interrupts = <14>;
>> };
>>
>> - i2c at 0x1e000 {
>> - compatible = "snps,designware-i2c";
>> + i2s: i2s at 1e000 {
>> + compatible = "snps,designware-i2s";
>> reg = <0x1e000 0x100>;
>> - clock-frequency = <400000>;
>> - clocks = <&i2cclk>;
>> + clocks = <&i2sclk 0>;
>> + clock-names = "i2sclk";
>> interrupts = <15>;
>> + #sound-dai-cells = <0>;
>> };
>>
>> i2c at 0x1f000 {
>> @@ -174,6 +175,7 @@
>> adi,input-colorspace = "rgb";
>> adi,input-clock = "1x";
>> adi,clock-delay = <0x03>;
>> + #sound-dai-cells = <0>;
>>
>> ports {
>> #address-cells = <1>;
>> @@ -295,5 +297,17 @@
>> };
>> };
>> };
>> +
>> + sound_playback {
>> + compatible = "simple-audio-card";
>> + simple-audio-card,name = "AXS10x HDMI Audio";
>> + simple-audio-card,format = "i2s";
>> + simple-audio-card,cpu {
>> + sound-dai = <&i2s>;
>> + };
>> + simple-audio-card,codec {
>> + sound-dai = <&adv7511>;
>> + };
>> + };
>> };
>> };
> Just for the sake of history that's my mods to defconfig that allowed me
> to play .pcm via HDMI from axs103 board:
> -------------------------------->8-------------------------------
> diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs103_smp_defconfig
> index 30a3d4cf53d2..b11362a32e4e 100644
> --- a/arch/arc/configs/axs103_smp_defconfig
> +++ b/arch/arc/configs/axs103_smp_defconfig
> @@ -67,25 +67,29 @@ CONFIG_MOUSE_PS2_TOUCHKIT=y
> CONFIG_MOUSE_SERIAL=y
> CONFIG_MOUSE_SYNAPTICS_USB=y
> # CONFIG_LEGACY_PTYS is not set
> -# CONFIG_DEVKMEM is not set
> CONFIG_SERIAL_8250=y
> CONFIG_SERIAL_8250_CONSOLE=y
> CONFIG_SERIAL_8250_DW=y
> CONFIG_SERIAL_OF_PLATFORM=y
> # CONFIG_HW_RANDOM is not set
> -CONFIG_I2C=y
> CONFIG_I2C_CHARDEV=y
> CONFIG_I2C_DESIGNWARE_PLATFORM=y
> # CONFIG_HWMON is not set
> -CONFIG_DRM=m
> -CONFIG_DRM_I2C_ADV7511=m
> -CONFIG_DRM_ARCPGU=m
> -CONFIG_FB=y
> +CONFIG_DRM=y
> +CONFIG_DRM_I2C_ADV7511=y
> +CONFIG_DRM_I2C_ADV7511_AUDIO=y
> +CONFIG_DRM_ARCPGU=y
> CONFIG_FRAMEBUFFER_CONSOLE=y
> CONFIG_LOGO=y
> # CONFIG_LOGO_LINUX_MONO is not set
> # CONFIG_LOGO_LINUX_VGA16 is not set
> # CONFIG_LOGO_LINUX_CLUT224 is not set
> +CONFIG_SOUND=y
> +CONFIG_SND=y
> +CONFIG_SND_SOC=y
> +CONFIG_SND_DESIGNWARE_I2S=y
> +CONFIG_SND_DESIGNWARE_PCM=y
> +CONFIG_SND_SIMPLE_CARD=y
> CONFIG_USB_EHCI_HCD=y
> CONFIG_USB_EHCI_HCD_PLATFORM=y
> CONFIG_USB_OHCI_HCD=y
> -------------------------------->8-------------------------------
>
> Anyways...
>
> Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
Rob, can you please take a look at this patch and at 2/2?
Alexey, do you still maintain your ack in these patches? (I'm
asking because I remember you were having no video after patch
2/2 of this series). If so, Vineet, can you please pick this up
and patch 2/2 also?
Best regards,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback
2017-03-20 14:02 ` Jose Abreu
@ 2017-03-20 14:05 ` Alexey Brodkin
2017-03-29 13:38 ` Jose Abreu
1 sibling, 0 replies; 12+ messages in thread
From: Alexey Brodkin @ 2017-03-20 14:05 UTC (permalink / raw)
To: linux-snps-arc
Hi Jose,
On Mon, 2017-03-20@14:02 +0000, Jose Abreu wrote:
> Hi Vineet, Alexey, Rob,
>?
> > Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
>
> Rob, can you please take a look at this patch and at 2/2?
>
> Alexey, do you still maintain your ack in these patches? (I'm
> asking because I remember you were having no video after patch
> 2/2 of this series).
Indeed I'm still OK with your both patches.
My problem was due to broken monitor that doesn't report EDID.
With proper monitor your patch works perfectly fine.
-Alexey
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback
2017-03-20 14:02 ` Jose Abreu
2017-03-20 14:05 ` Alexey Brodkin
@ 2017-03-29 13:38 ` Jose Abreu
1 sibling, 0 replies; 12+ messages in thread
From: Jose Abreu @ 2017-03-29 13:38 UTC (permalink / raw)
To: linux-snps-arc
Hi Vineet, Rob,
On 20-03-2017 14:02, Jose Abreu wrote:
> Hi Vineet, Alexey, Rob,
>
>
> On 02-03-2017 18:57, Alexey Brodkin wrote:
>> Hi Jose,
>>
>> On Wed, 2017-02-22@18:19 +0000, Jose Abreu wrote:
>>> This patch adds the necessary DT bindings to get HDMI audio
>>> output in ARC AXS10x SDP. The bindings for I2S controller were
>>> added as well as the bindings for simple audio card.
>>>
>>> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
>>> Cc: Carlos Palminha <palminha at synopsys.com>
>>> Cc: Alexey Brodkin <abrodkin at synopsys.com>
>>> Cc: Rob Herring <robh+dt at kernel.org>
>>> Cc: Vineet Gupta <vgupta at synopsys.com>
>>> Cc: devicetree at vger.kernel.org
>>> Cc: linux-snps-arc at lists.infradead.org
>>> Cc: linux-kernel at vger.kernel.org
>>> ---
>>> arch/arc/boot/dts/axs10x_mb.dtsi | 22 ++++++++++++++++++----
>>> 1 file changed, 18 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
>>> index d6c1bbc..9d882b1 100644
>>> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
>>> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
>>> @@ -149,12 +149,13 @@
>>> interrupts = <14>;
>>> };
>>>
>>> - i2c at 0x1e000 {
>>> - compatible = "snps,designware-i2c";
>>> + i2s: i2s at 1e000 {
>>> + compatible = "snps,designware-i2s";
>>> reg = <0x1e000 0x100>;
>>> - clock-frequency = <400000>;
>>> - clocks = <&i2cclk>;
>>> + clocks = <&i2sclk 0>;
>>> + clock-names = "i2sclk";
>>> interrupts = <15>;
>>> + #sound-dai-cells = <0>;
>>> };
>>>
>>> i2c at 0x1f000 {
>>> @@ -174,6 +175,7 @@
>>> adi,input-colorspace = "rgb";
>>> adi,input-clock = "1x";
>>> adi,clock-delay = <0x03>;
>>> + #sound-dai-cells = <0>;
>>>
>>> ports {
>>> #address-cells = <1>;
>>> @@ -295,5 +297,17 @@
>>> };
>>> };
>>> };
>>> +
>>> + sound_playback {
>>> + compatible = "simple-audio-card";
>>> + simple-audio-card,name = "AXS10x HDMI Audio";
>>> + simple-audio-card,format = "i2s";
>>> + simple-audio-card,cpu {
>>> + sound-dai = <&i2s>;
>>> + };
>>> + simple-audio-card,codec {
>>> + sound-dai = <&adv7511>;
>>> + };
>>> + };
>>> };
>>> };
>> Just for the sake of history that's my mods to defconfig that allowed me
>> to play .pcm via HDMI from axs103 board:
>> -------------------------------->8-------------------------------
>> diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs103_smp_defconfig
>> index 30a3d4cf53d2..b11362a32e4e 100644
>> --- a/arch/arc/configs/axs103_smp_defconfig
>> +++ b/arch/arc/configs/axs103_smp_defconfig
>> @@ -67,25 +67,29 @@ CONFIG_MOUSE_PS2_TOUCHKIT=y
>> CONFIG_MOUSE_SERIAL=y
>> CONFIG_MOUSE_SYNAPTICS_USB=y
>> # CONFIG_LEGACY_PTYS is not set
>> -# CONFIG_DEVKMEM is not set
>> CONFIG_SERIAL_8250=y
>> CONFIG_SERIAL_8250_CONSOLE=y
>> CONFIG_SERIAL_8250_DW=y
>> CONFIG_SERIAL_OF_PLATFORM=y
>> # CONFIG_HW_RANDOM is not set
>> -CONFIG_I2C=y
>> CONFIG_I2C_CHARDEV=y
>> CONFIG_I2C_DESIGNWARE_PLATFORM=y
>> # CONFIG_HWMON is not set
>> -CONFIG_DRM=m
>> -CONFIG_DRM_I2C_ADV7511=m
>> -CONFIG_DRM_ARCPGU=m
>> -CONFIG_FB=y
>> +CONFIG_DRM=y
>> +CONFIG_DRM_I2C_ADV7511=y
>> +CONFIG_DRM_I2C_ADV7511_AUDIO=y
>> +CONFIG_DRM_ARCPGU=y
>> CONFIG_FRAMEBUFFER_CONSOLE=y
>> CONFIG_LOGO=y
>> # CONFIG_LOGO_LINUX_MONO is not set
>> # CONFIG_LOGO_LINUX_VGA16 is not set
>> # CONFIG_LOGO_LINUX_CLUT224 is not set
>> +CONFIG_SOUND=y
>> +CONFIG_SND=y
>> +CONFIG_SND_SOC=y
>> +CONFIG_SND_DESIGNWARE_I2S=y
>> +CONFIG_SND_DESIGNWARE_PCM=y
>> +CONFIG_SND_SIMPLE_CARD=y
>> CONFIG_USB_EHCI_HCD=y
>> CONFIG_USB_EHCI_HCD_PLATFORM=y
>> CONFIG_USB_OHCI_HCD=y
>> -------------------------------->8-------------------------------
>>
>> Anyways...
>>
>> Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
> Rob, can you please take a look at this patch and at 2/2?
>
> Alexey, do you still maintain your ack in these patches? (I'm
> asking because I remember you were having no video after patch
> 2/2 of this series). If so, Vineet, can you please pick this up
> and patch 2/2 also?
>
> Best regards,
> Jose Miguel Abreu
>
> _______________________________________________
> linux-snps-arc mailing list
> linux-snps-arc at lists.infradead.org
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.infradead.org_mailman_listinfo_linux-2Dsnps-2Darc&d=DwICAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=yaVFU4TjGY0gVF8El1uKcisy6TPsyCl9uN7Wsis-qhY&m=05dGD6sUxxlAGDQnPi7nAbNEBEAQb-u7BnZFDdL6TwI&s=NSYlH7VAuvW7bJx6m50UgCpZmyvijw__WBWmn39sh6Y&e=
Gentle ping :)
Best regards,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 12+ messages in thread
* [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback
@ 2017-04-21 10:15 Jose Abreu
2017-03-02 18:57 ` [PATCH " Alexey Brodkin
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Jose Abreu @ 2017-04-21 10:15 UTC (permalink / raw)
To: linux-snps-arc
This patch adds the necessary DT bindings to get HDMI audio
output in ARC AXS10x SDP. The bindings for I2S controller were
added as well as the bindings for simple audio card.
Signed-off-by: Jose Abreu <joabreu at synopsys.com>
Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
Cc: Carlos Palminha <palminha at synopsys.com>
Cc: Alexey Brodkin <abrodkin at synopsys.com>
Cc: Rob Herring <robh+dt at kernel.org>
Cc: Vineet Gupta <vgupta at synopsys.com>
Cc: devicetree at vger.kernel.org
Cc: linux-snps-arc at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
arch/arc/boot/dts/axs10x_mb.dtsi | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index d6c1bbc..9d882b1 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -149,12 +149,13 @@
interrupts = <14>;
};
- i2c at 0x1e000 {
- compatible = "snps,designware-i2c";
+ i2s: i2s at 1e000 {
+ compatible = "snps,designware-i2s";
reg = <0x1e000 0x100>;
- clock-frequency = <400000>;
- clocks = <&i2cclk>;
+ clocks = <&i2sclk 0>;
+ clock-names = "i2sclk";
interrupts = <15>;
+ #sound-dai-cells = <0>;
};
i2c at 0x1f000 {
@@ -174,6 +175,7 @@
adi,input-colorspace = "rgb";
adi,input-clock = "1x";
adi,clock-delay = <0x03>;
+ #sound-dai-cells = <0>;
ports {
#address-cells = <1>;
@@ -295,5 +297,17 @@
};
};
};
+
+ sound_playback {
+ compatible = "simple-audio-card";
+ simple-audio-card,name = "AXS10x HDMI Audio";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,cpu {
+ sound-dai = <&i2s>;
+ };
+ simple-audio-card,codec {
+ sound-dai = <&adv7511>;
+ };
+ };
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [RESEND PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency
2017-04-21 10:15 [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Jose Abreu
2017-03-02 18:57 ` [PATCH " Alexey Brodkin
@ 2017-04-21 10:15 ` Jose Abreu
2017-03-02 17:35 ` [PATCH " Alexey Brodkin
2017-04-24 17:36 ` [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Vineet Gupta
2 siblings, 1 reply; 12+ messages in thread
From: Jose Abreu @ 2017-04-21 10:15 UTC (permalink / raw)
To: linux-snps-arc
Default clock frequency for ARC PGU does not match any
existing HDMI mode, instead the default value matches a
DVI mode. Change the clock frequency to 74.25MHz so that
it matches HDMI mode 1280x720 at 60Hz
Signed-off-by: Jose Abreu <joabreu at synopsys.com>
Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
Cc: Carlos Palminha <palminha at synopsys.com>
Cc: Alexey Brodkin <abrodkin at synopsys.com>
Cc: Rob Herring <robh+dt at kernel.org>
Cc: Vineet Gupta <vgupta at synopsys.com>
Cc: devicetree at vger.kernel.org
Cc: linux-snps-arc at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
arch/arc/boot/dts/axs10x_mb.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 9d882b1..41cfb29 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -51,7 +51,7 @@
pguclk: pguclk {
#clock-cells = <0>;
compatible = "fixed-clock";
- clock-frequency = <74440000>;
+ clock-frequency = <74250000>;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback
2017-04-21 10:15 [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Jose Abreu
2017-03-02 18:57 ` [PATCH " Alexey Brodkin
2017-04-21 10:15 ` [RESEND PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency Jose Abreu
@ 2017-04-24 17:36 ` Vineet Gupta
2017-04-26 8:55 ` Jose Abreu
2 siblings, 1 reply; 12+ messages in thread
From: Vineet Gupta @ 2017-04-24 17:36 UTC (permalink / raw)
To: linux-snps-arc
On 04/21/2017 03:15 AM, Jose Abreu wrote:
> This patch adds the necessary DT bindings to get HDMI audio
> output in ARC AXS10x SDP. The bindings for I2S controller were
> added as well as the bindings for simple audio card.
Are these waiting on Rob or is it OK for me to pick these up for 4.12 ?
-Vineet
>
> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
> Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Carlos Palminha <palminha at synopsys.com>
> Cc: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Rob Herring <robh+dt at kernel.org>
> Cc: Vineet Gupta <vgupta at synopsys.com>
> Cc: devicetree at vger.kernel.org
> Cc: linux-snps-arc at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
> arch/arc/boot/dts/axs10x_mb.dtsi | 22 ++++++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> index d6c1bbc..9d882b1 100644
> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> @@ -149,12 +149,13 @@
> interrupts = <14>;
> };
>
> - i2c at 0x1e000 {
> - compatible = "snps,designware-i2c";
> + i2s: i2s at 1e000 {
> + compatible = "snps,designware-i2s";
> reg = <0x1e000 0x100>;
> - clock-frequency = <400000>;
> - clocks = <&i2cclk>;
> + clocks = <&i2sclk 0>;
> + clock-names = "i2sclk";
> interrupts = <15>;
> + #sound-dai-cells = <0>;
> };
>
> i2c at 0x1f000 {
> @@ -174,6 +175,7 @@
> adi,input-colorspace = "rgb";
> adi,input-clock = "1x";
> adi,clock-delay = <0x03>;
> + #sound-dai-cells = <0>;
>
> ports {
> #address-cells = <1>;
> @@ -295,5 +297,17 @@
> };
> };
> };
> +
> + sound_playback {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "AXS10x HDMI Audio";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,cpu {
> + sound-dai = <&i2s>;
> + };
> + simple-audio-card,codec {
> + sound-dai = <&adv7511>;
> + };
> + };
> };
> };
^ permalink raw reply [flat|nested] 12+ messages in thread
* [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback
2017-04-24 17:36 ` [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Vineet Gupta
@ 2017-04-26 8:55 ` Jose Abreu
2017-04-26 23:31 ` Vineet Gupta
0 siblings, 1 reply; 12+ messages in thread
From: Jose Abreu @ 2017-04-26 8:55 UTC (permalink / raw)
To: linux-snps-arc
Hi Vineet,
On 24-04-2017 18:36, Vineet Gupta wrote:
> On 04/21/2017 03:15 AM, Jose Abreu wrote:
>> This patch adds the necessary DT bindings to get HDMI audio
>> output in ARC AXS10x SDP. The bindings for I2S controller were
>> added as well as the bindings for simple audio card.
> Are these waiting on Rob or is it OK for me to pick these up for 4.12 ?
Yes, I was waiting for Rob ack but he has been silent. It would
be nice if these went for 4.12.
Best regards,
Jose Miguel Abreu
>
> -Vineet
>
>> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
>> Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
>> Cc: Carlos Palminha <palminha at synopsys.com>
>> Cc: Alexey Brodkin <abrodkin at synopsys.com>
>> Cc: Rob Herring <robh+dt at kernel.org>
>> Cc: Vineet Gupta <vgupta at synopsys.com>
>> Cc: devicetree at vger.kernel.org
>> Cc: linux-snps-arc at lists.infradead.org
>> Cc: linux-kernel at vger.kernel.org
>> ---
>> arch/arc/boot/dts/axs10x_mb.dtsi | 22 ++++++++++++++++++----
>> 1 file changed, 18 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
>> index d6c1bbc..9d882b1 100644
>> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
>> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
>> @@ -149,12 +149,13 @@
>> interrupts = <14>;
>> };
>>
>> - i2c at 0x1e000 {
>> - compatible = "snps,designware-i2c";
>> + i2s: i2s at 1e000 {
>> + compatible = "snps,designware-i2s";
>> reg = <0x1e000 0x100>;
>> - clock-frequency = <400000>;
>> - clocks = <&i2cclk>;
>> + clocks = <&i2sclk 0>;
>> + clock-names = "i2sclk";
>> interrupts = <15>;
>> + #sound-dai-cells = <0>;
>> };
>>
>> i2c at 0x1f000 {
>> @@ -174,6 +175,7 @@
>> adi,input-colorspace = "rgb";
>> adi,input-clock = "1x";
>> adi,clock-delay = <0x03>;
>> + #sound-dai-cells = <0>;
>>
>> ports {
>> #address-cells = <1>;
>> @@ -295,5 +297,17 @@
>> };
>> };
>> };
>> +
>> + sound_playback {
>> + compatible = "simple-audio-card";
>> + simple-audio-card,name = "AXS10x HDMI Audio";
>> + simple-audio-card,format = "i2s";
>> + simple-audio-card,cpu {
>> + sound-dai = <&i2s>;
>> + };
>> + simple-audio-card,codec {
>> + sound-dai = <&adv7511>;
>> + };
>> + };
>> };
>> };
^ permalink raw reply [flat|nested] 12+ messages in thread
* [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback
2017-04-26 8:55 ` Jose Abreu
@ 2017-04-26 23:31 ` Vineet Gupta
2017-04-27 18:42 ` Jose Abreu
0 siblings, 1 reply; 12+ messages in thread
From: Vineet Gupta @ 2017-04-26 23:31 UTC (permalink / raw)
To: linux-snps-arc
On 04/26/2017 01:55 AM, Jose Abreu wrote:
> Hi Vineet,
>
>
> On 24-04-2017 18:36, Vineet Gupta wrote:
>> On 04/21/2017 03:15 AM, Jose Abreu wrote:
>>> This patch adds the necessary DT bindings to get HDMI audio
>>> output in ARC AXS10x SDP. The bindings for I2S controller were
>>> added as well as the bindings for simple audio card.
>> Are these waiting on Rob or is it OK for me to pick these up for 4.12 ?
> Yes, I was waiting for Rob ack but he has been silent. It would
> be nice if these went for 4.12.
Ok lets wait another couple of days before I pick those up.
In the mean time, can you please restest the series against 4.11-rcX and report
here that patches are still valid and do as intended !
Thx,
-Vineet
^ permalink raw reply [flat|nested] 12+ messages in thread
* [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback
2017-04-26 23:31 ` Vineet Gupta
@ 2017-04-27 18:42 ` Jose Abreu
2017-04-27 19:13 ` Vineet Gupta
0 siblings, 1 reply; 12+ messages in thread
From: Jose Abreu @ 2017-04-27 18:42 UTC (permalink / raw)
To: linux-snps-arc
Hi Vineet,
On 27-04-2017 00:31, Vineet Gupta wrote:
> On 04/26/2017 01:55 AM, Jose Abreu wrote:
>> Hi Vineet,
>>
>>
>> On 24-04-2017 18:36, Vineet Gupta wrote:
>>> On 04/21/2017 03:15 AM, Jose Abreu wrote:
>>>> This patch adds the necessary DT bindings to get HDMI audio
>>>> output in ARC AXS10x SDP. The bindings for I2S controller were
>>>> added as well as the bindings for simple audio card.
>>> Are these waiting on Rob or is it OK for me to pick these up for 4.12 ?
>> Yes, I was waiting for Rob ack but he has been silent. It would
>> be nice if these went for 4.12.
> Ok lets wait another couple of days before I pick those up.
> In the mean time, can you please restest the series against 4.11-rcX and report
> here that patches are still valid and do as intended !
I tested based on drm-next of today (which is based on 4.11-rc7)
and the patches work okay.
Best regards,
Jose Miguel Abreu
>
> Thx,
> -Vineet
^ permalink raw reply [flat|nested] 12+ messages in thread
* [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback
2017-04-27 18:42 ` Jose Abreu
@ 2017-04-27 19:13 ` Vineet Gupta
0 siblings, 0 replies; 12+ messages in thread
From: Vineet Gupta @ 2017-04-27 19:13 UTC (permalink / raw)
To: linux-snps-arc
On 04/27/2017 11:42 AM, Jose Abreu wrote:
> Hi Vineet,
>
>
> On 27-04-2017 00:31, Vineet Gupta wrote:
>> On 04/26/2017 01:55 AM, Jose Abreu wrote:
>>> Hi Vineet,
>>>
>>>
>>> On 24-04-2017 18:36, Vineet Gupta wrote:
>>>> On 04/21/2017 03:15 AM, Jose Abreu wrote:
>>>>> This patch adds the necessary DT bindings to get HDMI audio
>>>>> output in ARC AXS10x SDP. The bindings for I2S controller were
>>>>> added as well as the bindings for simple audio card.
>>>> Are these waiting on Rob or is it OK for me to pick these up for 4.12 ?
>>> Yes, I was waiting for Rob ack but he has been silent. It would
>>> be nice if these went for 4.12.
>> Ok lets wait another couple of days before I pick those up.
>> In the mean time, can you please restest the series against 4.11-rcX and report
>> here that patches are still valid and do as intended !
> I tested based on drm-next of today (which is based on 4.11-rc7)
> and the patches work okay.
Pushed to for-curr for 4.12 !
Thx,
-Vineet
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-04-27 19:13 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-21 10:15 [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Jose Abreu
2017-03-02 18:57 ` [PATCH " Alexey Brodkin
2017-03-20 14:02 ` Jose Abreu
2017-03-20 14:05 ` Alexey Brodkin
2017-03-29 13:38 ` Jose Abreu
2017-04-21 10:15 ` [RESEND PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency Jose Abreu
2017-03-02 17:35 ` [PATCH " Alexey Brodkin
2017-04-24 17:36 ` [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Vineet Gupta
2017-04-26 8:55 ` Jose Abreu
2017-04-26 23:31 ` Vineet Gupta
2017-04-27 18:42 ` Jose Abreu
2017-04-27 19:13 ` Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).