From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5225CE7718A for ; Fri, 20 Dec 2024 11:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=47ObQUbnM91VGHkdgScjAmnJqpednjXMrHokemJzcg8=; b=NafZbANvjYgV+g 01mHj7g/N4pP1Tk0BofLiPH6idMsKDSPsD113eeqHw9RgvyfIU1PesdU8rmJscRG9fSDzuEl4Mz2Q TktN3vlPbHPnrQ7imtoX4GBhRed5b4P4I8truC6lGjN4Jh2gnrBTHoUjw8Q50HRL4vzZ53jmnwnNB 8zPAth+aVo/Z+uunNVRM2Vtb3jinLGINNFpC3pGER5OZqC56QPCIpRmSYdQ7Lpk8uIqeWJK90EgxH NEEfnXn9HGIqUmVcj1RkGMSUtc2Gw8xF6ZCyhkYtDbYzOLVeFywJn9FDo5/lB98pumJF0sEUyt3n+ 0G4Lwr5Y90qC1Puyrlgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tOaxo-00000004ilM-1SCE; Fri, 20 Dec 2024 11:14:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tOai4-00000004ebu-0d7j; Fri, 20 Dec 2024 10:58:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4DDC71480; Fri, 20 Dec 2024 02:58:47 -0800 (PST) Received: from [10.57.72.191] (unknown [10.57.72.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0C613F58B; Fri, 20 Dec 2024 02:58:10 -0800 (PST) Message-ID: <765aec36-55a4-4161-bb30-4ff838bc2d98@arm.com> Date: Fri, 20 Dec 2024 11:58:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] Account page tables at all levels To: Dave Hansen , linux-mm@kvack.org Cc: Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , Peter Zijlstra , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org References: <20241219164425.2277022-1-kevin.brodsky@arm.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241220_025820_242382_2E756891 X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On 19/12/2024 18:13, Dave Hansen wrote: > On 12/19/24 08:44, Kevin Brodsky wrote: >> +---------------+-------------------------+-----------------------+--------------+------------------------------------+ >> | x86 | Y | Y | Y/N | kmem_cache at pgd level if PAE | >> +---------------+-------------------------+-----------------------+--------------+------------------------------------+ > This is a really rare series that adds functionality _and_ removes code > overall. It looks really good to me. The x86 implementation seems to be > captured just fine in the generic one: Thank you for the review, very appreciated! > Acked-by: Dave Hansen Just to double-check, are your ack'ing the x86 changes specifically? If so I'll add your Acked-by on patch 6, 7 and 9. > One super tiny nit is that the PAE pgd _can_ be allocated using > __get_free_pages(). It was originally there for Xen, but I think it's > being used for PTI only at this point and the comments are wrong-ish. > > I kinda think we should just get rid of the 32-bit kmem_cache entirely. That would certainly simplify things on the x86 side! I'm not at all familiar with that code though, would you be happy with providing a patch? I could add it to this series if that's convenient. - Kevin _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc