From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6FFACA0FF0 for ; Mon, 1 Sep 2025 17:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CDKi/YBoYcPgmDoGHBmCSAnpay41XaGBU34MWgSqRIE=; b=UbElKa6venepNg 1hLhwduvvLwN00NHGtFi/hYjUYtdvPjzXX+f2qMSwU6kXvH3kGXg8U1V/dOK5dlAIce2qR43OHp5m paOLWVHlEGq4wLod6P9VCsWqagZC6KqXPxfEvuf83pcPbswqEQSAca9hdjp2VBmDNB3MhOiOk89ip YhfUw5U7TAzskftCiQBKkcn63/Q55OMS1v3LKXjDrUt+TB4foGZmkw6pDxW+LEYKie4laKGyzqFTF 4q91VtnttwDgWS+JAoUcTdlm005dkumwyIMbZWNjiHPGj5Y2iCk2PR91eBcPpA22iEByjwznTp2UY qOdu/roWqCPukwf58DSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ut7tq-0000000DNE2-1FmI; Mon, 01 Sep 2025 17:00:58 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ut4Wz-0000000Cg3z-2djR for linux-snps-arc@bombadil.infradead.org; Mon, 01 Sep 2025 13:25:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=tnXepClSCa4TtmpEoW4LNnvfPXJBpj0jhMGD19t2OsQ=; b=JQHccXDQOFkQFmXPgXig0sFXlq O70NEfg+HIDUKlFz8ilvj/wrJ4NPsdJpjMmABi2LrPeAK3PbGGq6SuceA7jLPTUxE11qKFqZPtTus ElwDlLXQ60ALuJ7gM5BWt+7SkYRJdj0FWttjA4vADR0oSmIRl0urUshzsImhhNwzCuPr72jVUT9/Z o4S+hgC1+GDjLNjZf4AztnFfHcy3MoHDlb1wazHMf4LKrDn0GStMGJN7MiXT73csU6vNI70cfx9oB 5BP5z5OWMLIO+3Ivq1U2HjWgzJ29JTRT0p1/ovk526qCeETFy97eQn34bHAbE+TkT6Ao0LYWhDIN8 G8yPNTtg==; Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ut4Ww-00000003jeV-0LHb for linux-snps-arc@lists.infradead.org; Mon, 01 Sep 2025 13:25:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756733104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tnXepClSCa4TtmpEoW4LNnvfPXJBpj0jhMGD19t2OsQ=; b=PVERd+mCExzDiKOXtcatrllKxPoCJO2KgRuWOhtqBXPZeK/JDySlxuRtD9zO0fHphr45kz kuKsi8o6GWR0Ce/WwJOZuQUpAOuvYahT3JnkdkW0us3BGFXMMZPB2Vl//KDFI78DcBlUde wzSUhqWhotcRmBTw9rIVWfV9YDH6H78= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756733104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tnXepClSCa4TtmpEoW4LNnvfPXJBpj0jhMGD19t2OsQ=; b=PVERd+mCExzDiKOXtcatrllKxPoCJO2KgRuWOhtqBXPZeK/JDySlxuRtD9zO0fHphr45kz kuKsi8o6GWR0Ce/WwJOZuQUpAOuvYahT3JnkdkW0us3BGFXMMZPB2Vl//KDFI78DcBlUde wzSUhqWhotcRmBTw9rIVWfV9YDH6H78= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-skSF4WlEMCGo0hB2SN3GeA-1; Mon, 01 Sep 2025 09:25:02 -0400 X-MC-Unique: skSF4WlEMCGo0hB2SN3GeA-1 X-Mimecast-MFC-AGG-ID: skSF4WlEMCGo0hB2SN3GeA_1756733102 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45b87bc6869so12350035e9.3 for ; Mon, 01 Sep 2025 06:25:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756733102; x=1757337902; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tnXepClSCa4TtmpEoW4LNnvfPXJBpj0jhMGD19t2OsQ=; b=hjFOL9qgmzXthF7dgCeX4Cv7EmAZ9G3rm8lm7zLoCnQ+Ky8P+zFNK15PNyD7ebXfio wiS+C098dDFhB+g1+DZN+3M5Huygzw34ukoN4EebHC8aeMU0WWvBj8MjgaMNs6PefuxU qXAjz5fmemTz1EDzHWYJG6bLfkIOz4La+CDdIn1NGfcRHFS8EbgTmblrGmADIA3g52o3 X1Z7ooRY56NUmpxq4H/Wr6mEf8a28HL4wDqj0+5PtmzUo5p35wo1Tz+1kjW0JgJGw5iH RAt1YilMagFeBo2qQco7forCf0+Ojr68VYe13my1H8M+5f3/P6Tem2wBwspA5D9vVgWX yLRQ== X-Forwarded-Encrypted: i=1; AJvYcCWTAzPJMhkaYM1fyOGN+KHlhqOT34zAvBJD3qkxvggn6EoRMTTlf+gccPeMZdFeePq6iwxvhiH3YGAIzpY2tw==@lists.infradead.org X-Gm-Message-State: AOJu0Yx4Fxk8H591FUjG34kmI49pa/QmFOSX3FQGtp6ubZ1qMuzaJBqr A7HOYv9Ry+daAiZX45a+Foz39O9PIv7hOVdad/BKijILy/g4xq6BAHNrBhogjaRzezBDO8i9FeY hGMwsPNY8nMAOMkcoFrxDzBc9KzA+YeR+GEmCtt0Xr2rB8QsaUgGJnZt02eyecv0kyPFj7bpbCg == X-Gm-Gg: ASbGncuCliEhWZgvj+fhaN5UWgOczeDynsXxyJfyT3aKjm8d+zqxDouaM1lz5qrk8JW 9cyd7qO3RMd8lt0EmuWtbaLlZmgu7jTZANPwtG/krQfromnvL1dWNW0wo0OmGUmckZmGyWgHbkt 1XjqSnQbGakPaCl9j0y3CGcuZtJPLvwM0D8EtWbllKpC2A0aKnoqN9MMYfLKfQMLv003S6kxZl9 Pl1/8nDy0dEnS5r9grvnJ+xmpWws+z/tl7rmdhvx7SAI2jyGPhvWtge2ECoaqKMdYh+EpBSp9D3 we58TYh2gOnFGas5zg2XXMGr8l9r5Zm8i0JS+aiMzjV5gFpk2uHhWGCySWWFJBi+pDi1tIgsnw8 kvO2crao2D5Mi1XXfIwJwAqmtk1r1424zlf+xNor1P/sY7Q46EdEsxmmc0u2ArTxpFWo= X-Received: by 2002:a05:600c:1c98:b0:45b:8cee:580a with SMTP id 5b1f17b1804b1-45b8cee5b84mr29479205e9.35.1756733101650; Mon, 01 Sep 2025 06:25:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFn4DAGKD4/hR6ptaEjNoxJNELsNDQWoqjaZ80cydfGU/2h/6IoyZcnqEvOz4BgFx0o138wIQ== X-Received: by 2002:a05:600c:1c98:b0:45b:8cee:580a with SMTP id 5b1f17b1804b1-45b8cee5b84mr29478885e9.35.1756733101175; Mon, 01 Sep 2025 06:25:01 -0700 (PDT) Received: from ?IPV6:2003:d8:2f37:2b00:948c:dd9f:29c8:73f4? (p200300d82f372b00948cdd9f29c873f4.dip0.t-ipconnect.de. [2003:d8:2f37:2b00:948c:dd9f:29c8:73f4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b6f0c6dc1sm239218725e9.1.2025.09.01.06.24.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Sep 2025 06:25:00 -0700 (PDT) Message-ID: <94ec640b-76cd-478e-9ee7-ff8597d1fafc@redhat.com> Date: Mon, 1 Sep 2025 15:24:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] copy_sighand: Handle architectures where sizeof(unsigned long) < sizeof(u64) To: schuster.simon@siemens-energy.com, Dinh Nguyen , Christian Brauner , Arnd Bergmann , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-security-module@vger.kernel.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, apparmor@lists.ubuntu.com, selinux@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, stable@vger.kernel.org References: <20250901-nios2-implement-clone3-v2-0-53fcf5577d57@siemens-energy.com> <20250901-nios2-implement-clone3-v2-1-53fcf5577d57@siemens-energy.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20250901-nios2-implement-clone3-v2-1-53fcf5577d57@siemens-energy.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ltj1SL28aM1K-6bmzcpx58rEDGYOMm7QsFTcgMP9zBA_1756733102 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250901_142506_438003_497154A7 X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On 01.09.25 15:09, Simon Schuster via B4 Relay wrote: > From: Simon Schuster > > With the introduction of clone3 in commit 7f192e3cd316 ("fork: add > clone3") the effective bit width of clone_flags on all architectures was > increased from 32-bit to 64-bit. However, the signature of the copy_* > helper functions (e.g., copy_sighand) used by copy_process was not > adapted. > > As such, they truncate the flags on any 32-bit architectures that > supports clone3 (arc, arm, csky, m68k, microblaze, mips32, openrisc, > parisc32, powerpc32, riscv32, x86-32 and xtensa). > > For copy_sighand with CLONE_CLEAR_SIGHAND being an actual u64 > constant, this triggers an observable bug in kernel selftest > clone3_clear_sighand: > > if (clone_flags & CLONE_CLEAR_SIGHAND) > > in function copy_sighand within fork.c will always fail given: > > unsigned long /* == uint32_t */ clone_flags > #define CLONE_CLEAR_SIGHAND 0x100000000ULL > > This commit fixes the bug by always passing clone_flags to copy_sighand > via their declared u64 type, invariant of architecture-dependent integer > sizes. > > Fixes: b612e5df4587 ("clone3: add CLONE_CLEAR_SIGHAND") > Cc: stable@vger.kernel.org # linux-5.5+ > Signed-off-by: Simon Schuster > Reviewed-by: Lorenzo Stoakes > --- (stripping To list) Acked-by: David Hildenbrand -- Cheers David / dhildenb _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc