From: Julia Lawall <julia.lawall@inria.fr>
To: Shahab Vahedi <Shahab.Vahedi@synopsys.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
Jilin Yuan <yuanjilin@cdjrlc.com>,
"vgupta@kernel.org" <vgupta@kernel.org>,
"Julia.Lawall@inria.fr" <Julia.Lawall@inria.fr>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARC:mm:Fix syntax errors in comments
Date: Wed, 22 Jun 2022 05:16:21 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2206220513590.2646@hadrien> (raw)
In-Reply-To: <4cef89c9-3b27-11e8-2971-66b93b847ede@synopsys.com>
On Wed, 22 Jun 2022, Shahab Vahedi wrote:
> On 6/22/22 10:30, Bagas Sanjaya wrote:
>
> > I think that this kind of cleanup patches (typofixes) are best done
> > as part of **actual** work on the code in question (for example
> > refactoring or fixing build errors).
>
> Amen!
So code that is fine will have typos forever? Fixing typos in comments
doesn't break git blame for the following code. And typos in comments
give a bad impression about the state of the code in general.
But that is a general statement. Perhaps this code does particularly need
work.
julia
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2022-06-22 9:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 8:04 [PATCH] ARC:mm:Fix syntax errors in comments Jilin Yuan
2022-06-22 8:30 ` Bagas Sanjaya
2022-06-22 8:42 ` Shahab Vahedi
2022-06-22 9:16 ` Julia Lawall [this message]
2022-06-22 9:25 ` Shahab Vahedi
2022-06-22 9:38 ` Julia Lawall
2022-06-22 13:20 ` Bagas Sanjaya
2022-06-22 13:46 ` Julia Lawall
2022-06-22 14:10 ` Conor.Dooley
2022-06-23 2:50 ` Vineet Gupta
2022-06-23 7:56 ` Bagas Sanjaya
2022-06-24 1:57 ` Vineet Gupta
2022-06-24 3:16 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2206220513590.2646@hadrien \
--to=julia.lawall@inria.fr \
--cc=Shahab.Vahedi@synopsys.com \
--cc=bagasdotme@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=rdunlap@infradead.org \
--cc=vgupta@kernel.org \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox