From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A11DC43334 for ; Wed, 22 Jun 2022 13:46:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t1rdhAwrup3zsA58phIhjE4Roq2URZbt4KowskyE/Kg=; b=U3zE16xtYnDifN k5CWgmQzhsRmgeY4NSWDJWgRAIOR9fNYzgCm3ti2QjV0wJ2nE+W1E9iGVdRoaYY6YsNoMe9J2eNIj iei2e+t+3PoM3giPUN8thxcMlFoQxsqP/xH7wgZTMWZDdfoBE9b9XjMu1xw+lA+IyzovElIQWbX+5 rnF2Zr5TVmZyULXy/kLizdKzbACREJtBeClSAG9s9R5sgb8k9uMe9EJZjiaP8t4ldQHxEwpFrSwuq Yp5PviFeF3UDcb6EjUp7jMImb2g7q+IbZEi2OwPe2Z6Ra4VnXNDenK9LZPmdHuwexZExVdt6egFRW a6OTwAqyfgELfLURjitA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o40gy-00Ah01-Kc; Wed, 22 Jun 2022 13:46:48 +0000 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o40gu-00AgvX-AH for linux-snps-arc@lists.infradead.org; Wed, 22 Jun 2022 13:46:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=bdqRyaN94a2F/toYtRRwW4KgpaJhL3mLLBaZfLKAwvc=; b=IKyah0mNYTKZwqc7WA5l/lL6mD4r4+fRGjigyU7UmU6DawOTvXDMvN7S nOM9+dB1v2ARmmirSy9yo/oJZNjK2XiI/HJTe39qeJ7V8aoRlCPd8RjQa 8/TATm2oxShA3vATMc9msSh8NKBEBu/yEcmJrvBNHD7Vu1yEerSKtgKyV 0=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.92,212,1650924000"; d="scan'208";a="17503033" Received: from 71-51-165-43.chvl.centurylink.net (HELO hadrien.PK5001Z) ([71.51.165.43]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 15:46:37 +0200 Date: Wed, 22 Jun 2022 09:46:13 -0400 (EDT) From: Julia Lawall X-X-Sender: julia@hadrien To: Bagas Sanjaya cc: Julia Lawall , Shahab Vahedi , Jilin Yuan , "vgupta@kernel.org" , "rdunlap@infradead.org" , "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ARC:mm:Fix syntax errors in comments In-Reply-To: <1b34e0e5-23aa-96cd-c37f-1434884ff061@gmail.com> Message-ID: References: <20220622080423.41570-1-yuanjilin@cdjrlc.com> <4cef89c9-3b27-11e8-2971-66b93b847ede@synopsys.com> <46e4b588-d35b-ec50-ad1a-8502c2903677@synopsys.com> <1b34e0e5-23aa-96cd-c37f-1434884ff061@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_064644_929138_2D360023 X-CRM114-Status: GOOD ( 24.27 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Wed, 22 Jun 2022, Bagas Sanjaya wrote: > On 6/22/22 16:38, Julia Lawall wrote: > >>> So code that is fine will have typos forever? Fixing typos in comments > >>> doesn't break git blame for the following code. And typos in comments > >>> give a bad impression about the state of the code in general. > >> > >> Of course not! Documentation is as important as the code, if not even more. > >> However, fixing typos to increase your commit counts to a reputable project > >> is not fine either. For instance, many of these proposed fixes are targeting > >> one single typo at a time. Couldn't they just be sent altogether!?! > > > > I have the impression that the person is just trying to figure out the > > patch submission process. For example, the subject lines are not > > formatter in the standard way (I sent the person a private email about > > that). Perhaps just let him know about how you would rather have received > > the patches. > > In recent times I had seen many typofix patches sent to LKML. You can see most > of them by querying `s:"fix typo"` on lore.kernel.org. Some of these patches > have been merged, though. > > What I say as starter thread is "ideal" scenario as described in > Documentation/process/2.Process.rst; that is we prefer to see these minor > fixes as part of real patches work (say refactoring), rather than just being > trivial patches. > > But what most reviewers here missed is how these typos are found? I guess > these can be from codespell or some other tools, or even manual review, > then send the fixes en mass. > > Take a look at "fix typo in a comment" aka "delete redundant word" patches > at [1], [2], [3]. and [4]. > > [1]: https://lore.kernel.org/lkml/20220618132659.17100-1-wangxiang@cdjrlc.com/ > [2]: https://lore.kernel.org/lkml/20220618130349.11507-1-wangxiang@cdjrlc.com/ > [3]: https://lore.kernel.org/lkml/20220616163830.11366-1-wangxiang@cdjrlc.com/ > [4]: https://lore.kernel.org/lkml/20220606123419.29109-1-wangxiang@cdjrlc.com/ > > IMHO, these patches should have been in a single, consolidated patch, since > these strip duplicate (hence redundant) word (single logical change). They go to different maintainers, so perhaps each one would prefer to get their own patches? There was a trivial tree, but it is apparently not very active. It would indeed be good to indicate how the problems were found. That could suggest whether the problem has been addressed comprehensively, or whether just some random issues have been detected. julia _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc