Re: [PATCH] ARC:mm:Fix syntax errors in comments

Bagas Sanjaya
2022-06-23T07:56:43Z

On 6/23/22 09:50, Vineet Gupta wrote:
>> The patch is OK, but its subject is wrong.
>
> Right.
>
>> The patch above isn't fixing any syntax errors, but rather minor cleanup.
>> The subject should have been "Remove duplicate 'to' in the
>> flush_dcache_page() comment".
>
> I'd just say "ARC: mm: fix typos"
>

OK.

> In an ideal world yes. But sometimes maintainer complain to break whitespacxe fixes and such into independent fix. Also as someone said later in the thread, for somebody just getting into kernel and figuring out patch submission etc this could be a perfect dry run and helps improve the code anyways.
>

Seems like you missed the point that it's OK to have typofixes while
doing other real changes (like refactoring) in the same patch.

Quoting from [1]:

> My opinion is that trivial patches like this are fine as a starting
> point for new contributors, which is why I acked the previous patch from
> you guys. However, if we start getting two of these every week it just
> adds more maintenance burden than it's worth.

I tend to agree with the last sentence of above quote. Let's pretend that
I'm the tree maintainer. Besides reviewing real change patches, I get
flooded by these similar minor cleanup patches that I need to review.
Some (but not all) these patches have issues (say subject or description
error) that are repeated. Lazily speaking, I'd like to privately notice the
submitter about the situation, and I withhold these for now.

Thanks.

[1]: https://lore.kernel.org/lkml/0308c92a-0e10-35a4-928b-8f715a7bae44@linbit.com/

--
An old man doll... just what I always wanted! - Clara