Re: [PATCH] ARC:mm:Fix syntax errors in comments

Vineet Gupta
2022-06-23T02:50:51Z

On 6/22/22 01:30, Bagas Sanjaya wrote:
>> - * If the U-mapping is not congruent to to K-mapping, former needs flushing.
>> + * If the U-mapping is not congruent to K-mapping, former needs flushing.
>> */
>> void flush_dcache_page(struct page *page)
>> {
> The patch is OK, but its subject is wrong.

Right.

> The patch above isn't fixing any syntax errors, but rather minor cleanup.
> The subject should have been "Remove duplicate 'to' in the
> flush_dcache_page() comment".

I'd just say "ARC: mm: fix typos"

> I think that this kind of cleanup patches (typofixes) are best done
> as part of **actual** work on the code in question (for example
> refactoring or fixing build errors).

In an ideal world yes. But sometimes maintainer complain to break
whitespacxe fixes and such into independent fix. Also as someone said
later in the thread, for somebody just getting into kernel and figuring
out patch submission etc this could be a perfect dry run and helps
improve the code anyways.

-Vineet