From: Vineet Gupta <vgupta@kernel.org>
To: kan.liang@linux.intel.com, peterz@infradead.org,
mingo@redhat.com, namhyung@kernel.org, irogers@google.com,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org
Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com,
leo.yan@arm.com, linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH V3 11/16] arc/perf: Remove driver-specific throttle support
Date: Sun, 18 May 2025 14:58:05 -0700 [thread overview]
Message-ID: <c3fa9e90-a94b-47f7-b911-ed7c97fd1d6f@kernel.org> (raw)
In-Reply-To: <20250516182853.2610284-12-kan.liang@linux.intel.com>
On 5/16/25 11:28, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> The throttle support has been added in the generic code. Remove
> the driver-specific throttle support.
>
> Besides the throttle, perf_event_overflow may return true because of
> event_limit. It already does an inatomic event disable. The pmu->stop
> is not required either.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> Cc: Vineet Gupta <vgupta@ikernel.org>
> Cc: linux-snps-arc@lists.infradead.org
Acked-by: Vineet Gupta <vgupta@kernel.org>
Please let me know if you wane to take it via ARC tree.
Thx,
-Vineet
> ---
> arch/arc/kernel/perf_event.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c
> index 6e5a651cd75c..ed6d4f0cd621 100644
> --- a/arch/arc/kernel/perf_event.c
> +++ b/arch/arc/kernel/perf_event.c
> @@ -599,10 +599,8 @@ static irqreturn_t arc_pmu_intr(int irq, void *dev)
>
> arc_perf_event_update(event, &event->hw, event->hw.idx);
> perf_sample_data_init(&data, 0, hwc->last_period);
> - if (arc_pmu_event_set_period(event)) {
> - if (perf_event_overflow(event, &data, regs))
> - arc_pmu_stop(event, 0);
> - }
> + if (arc_pmu_event_set_period(event))
> + perf_event_overflow(event, &data, regs);
>
> active_ints &= ~BIT(idx);
> } while (active_ints);
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
prev parent reply other threads:[~2025-05-18 21:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250516182853.2610284-1-kan.liang@linux.intel.com>
2025-05-16 18:28 ` [PATCH V3 11/16] arc/perf: Remove driver-specific throttle support kan.liang
2025-05-18 21:58 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3fa9e90-a94b-47f7-b911-ed7c97fd1d6f@kernel.org \
--to=vgupta@kernel.org \
--cc=ctshao@google.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).