* [PATCH V3 11/16] arc/perf: Remove driver-specific throttle support [not found] <20250516182853.2610284-1-kan.liang@linux.intel.com> @ 2025-05-16 18:28 ` kan.liang 2025-05-18 21:58 ` Vineet Gupta 0 siblings, 1 reply; 2+ messages in thread From: kan.liang @ 2025-05-16 18:28 UTC (permalink / raw) To: peterz, mingo, namhyung, irogers, mark.rutland, linux-kernel, linux-perf-users Cc: eranian, ctshao, tmricht, leo.yan, Kan Liang, Vineet Gupta, linux-snps-arc From: Kan Liang <kan.liang@linux.intel.com> The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang <kan.liang@linux.intel.com> Cc: Vineet Gupta <vgupta@ikernel.org> Cc: linux-snps-arc@lists.infradead.org --- arch/arc/kernel/perf_event.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c index 6e5a651cd75c..ed6d4f0cd621 100644 --- a/arch/arc/kernel/perf_event.c +++ b/arch/arc/kernel/perf_event.c @@ -599,10 +599,8 @@ static irqreturn_t arc_pmu_intr(int irq, void *dev) arc_perf_event_update(event, &event->hw, event->hw.idx); perf_sample_data_init(&data, 0, hwc->last_period); - if (arc_pmu_event_set_period(event)) { - if (perf_event_overflow(event, &data, regs)) - arc_pmu_stop(event, 0); - } + if (arc_pmu_event_set_period(event)) + perf_event_overflow(event, &data, regs); active_ints &= ~BIT(idx); } while (active_ints); -- 2.38.1 _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V3 11/16] arc/perf: Remove driver-specific throttle support 2025-05-16 18:28 ` [PATCH V3 11/16] arc/perf: Remove driver-specific throttle support kan.liang @ 2025-05-18 21:58 ` Vineet Gupta 0 siblings, 0 replies; 2+ messages in thread From: Vineet Gupta @ 2025-05-18 21:58 UTC (permalink / raw) To: kan.liang, peterz, mingo, namhyung, irogers, mark.rutland, linux-kernel, linux-perf-users Cc: eranian, ctshao, tmricht, leo.yan, linux-snps-arc On 5/16/25 11:28, kan.liang@linux.intel.com wrote: > From: Kan Liang <kan.liang@linux.intel.com> > > The throttle support has been added in the generic code. Remove > the driver-specific throttle support. > > Besides the throttle, perf_event_overflow may return true because of > event_limit. It already does an inatomic event disable. The pmu->stop > is not required either. > > Signed-off-by: Kan Liang <kan.liang@linux.intel.com> > Cc: Vineet Gupta <vgupta@ikernel.org> > Cc: linux-snps-arc@lists.infradead.org Acked-by: Vineet Gupta <vgupta@kernel.org> Please let me know if you wane to take it via ARC tree. Thx, -Vineet > --- > arch/arc/kernel/perf_event.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c > index 6e5a651cd75c..ed6d4f0cd621 100644 > --- a/arch/arc/kernel/perf_event.c > +++ b/arch/arc/kernel/perf_event.c > @@ -599,10 +599,8 @@ static irqreturn_t arc_pmu_intr(int irq, void *dev) > > arc_perf_event_update(event, &event->hw, event->hw.idx); > perf_sample_data_init(&data, 0, hwc->last_period); > - if (arc_pmu_event_set_period(event)) { > - if (perf_event_overflow(event, &data, regs)) > - arc_pmu_stop(event, 0); > - } > + if (arc_pmu_event_set_period(event)) > + perf_event_overflow(event, &data, regs); > > active_ints &= ~BIT(idx); > } while (active_ints); _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-18 21:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250516182853.2610284-1-kan.liang@linux.intel.com>
2025-05-16 18:28 ` [PATCH V3 11/16] arc/perf: Remove driver-specific throttle support kan.liang
2025-05-18 21:58 ` Vineet Gupta
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).