From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58A33E8FDBE for ; Sun, 28 Dec 2025 13:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hxxj8xf+5F2+EGPrtvaiuav3Z/ouTqSKlSIlcVzSweY=; b=x1i6O3NTmSadRK hUBr49CGUUhc5SxXZFbWOCGW8dFgTkEEUXdNfOu5RROC4l63kj/+JDeKFW3MgYq2SvhzjbL62gdhh ESeCV0c3UOe0sp0g/TOScNECYL90m2dNQtXVP1OUDXyNK28hQ0eOXwpeNeAJ2f1JAV1gtswpKkKKK R1p4mT2mrrBpwEv3KjkWZIueNo2PUeEYTcY6magkdnbMh9NTwHytqGpOuHri8wNL15FiI7+APqys2 s6H3I1Jrr2IC9nf4Cy1kPkCUlAsriZ9UZIkTrBw9lCdpAK3NU3UDXNrRkV8y59Y9QxQACr9oqXPVO nYLpYZ79K5RJV67C6ArQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vZqqQ-00000002mMJ-3nrs; Sun, 28 Dec 2025 13:30:02 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vZqqO-00000002mKg-1jOP for linux-snps-arc@lists.infradead.org; Sun, 28 Dec 2025 13:30:01 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-598f8136a24so9403973e87.3 for ; Sun, 28 Dec 2025 05:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766928597; x=1767533397; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7lWyQqsYJqWc7lm9cTjRQLwXSVE/IuAz3ei2okz3340=; b=QPDgTZsutGviVonp/6FU/JsAA/9QKxAI/C/UENbEiv9cRMO1VVmGHWMRJlopHK4Eii 10jGkkidUQW4biTHBSH1Uh5W8xLqMvOsdX8AXkMfY2qX0Hi+0tMTz++s+8XQ90eIYlJj qx238U1uGNcu2FDGmaqlhSr5ZTsEBmQJ5RK8ioNacSU0c39vfBFRpYr8ojvN/Zosnoio meTWDOeDlNp67WRHQdwjDg5eed2jMNVGhnL9+AlhLDHEfr1SBDJ0p3YnQwcJwykpGc9e nA6PChYWrwN3vrDS/afBhxdxnbGeFa4kg4INq81HXv0dkYj+cuziFB2HFXgCi2ZGC7UF AldA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766928597; x=1767533397; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7lWyQqsYJqWc7lm9cTjRQLwXSVE/IuAz3ei2okz3340=; b=NVMjTtFSrs/SMWGO6r8LX7v3GLJrGcw6s+Zg6U9QKjeWsTr0sZ6UKzyWVt44OvGOH+ 0CdBZCIh5iGxNOlYRgHHYeT2+GECg4CobBObuv8uQOHHaST0Nzrlaii2/KfCWQwZXLeK LKvfVYgIw2ivWlLiz6LHqawWolPpAjVaqzBOzOZb+lsUH7ka82EIpvB/dYrrfnO40RhF hvfZMOfOyvzFnpte+POCByCExDPYjyeUPlDKY2ovVJGFJtxSRfXoz9jEM5hpAg1eskm6 +AC8aUVjWp/i6V0E531QVSkNntvMdn8ZvUe+56Hsq9NNIUwxOXDVPi/eiYxg0BkC8eSQ 2HDw== X-Forwarded-Encrypted: i=1; AJvYcCXa6Ycf22AsAToQpfkp95tBaegh9dmh3w/RfLw4nexmYNwX4JFs7Xa0+YzlbpEq0C74Qpi2hATInHhW8lIscA==@lists.infradead.org X-Gm-Message-State: AOJu0YwX9uMR2AKgGvry44juO4XwbqbJ/7R9eRju8m8OgYaMRjMIlxnY gbQnJM6X8AKKWsXZNjyeLZ2JLjhvR43eiAI6BgIui6iQYAF6ZfXls/7q X-Gm-Gg: AY/fxX4htrDJpGH5rM7XaWygSqAUpvVGbyG+P5QXhh2cwgQtCpOLCK7111V1NoNp8/N zb/1Suy6hyew3GbcaKF9lW3TbygjUOlo+flWWWZffg3ddGZKeiQiwLTvwrLjbpZpystQtZJrwzR lAHkS+L3wxKupeNum/DTs9zhvptT22zWv/5LmFFBGh6wEn0VU6MUBeTq6RHqopyMDZb2RGWy7ml 2hQxkHkhVZ4pk7xgPQIEWOD+YLdZNgMp8LB00BJXcrGf9ycuPjSi8vL9aoO5kJnWvkm4DJkGDPh a6xzBWmLtqz2dILaxQYqISfkC6bFQMNDIxgBnM+nzJG+ts/Shr7gk3epMlPP2G6vYcOSfRr2DvA fvm3bSt8bb3iINPYIKMfMCSlHmTt8lzTBNUGqviLNlSGQFqWht8jkw6877MUWX8ubEVBTb4Jaud kTtjjXP6Fd3iSmBtyJuV3A0TScSVnvGt2HJlw1zAyaMgP1tD0w8xshMrtD0N2kxObR+YiNSx6B5 Lli5O3/ X-Google-Smtp-Source: AGHT+IGo/pr+AQ2VNaaG2TyhewLh2BG0nsRAoXdF/d33J1EZZvYOr8FxE2Re2WZCgj4kGCoIAYrr8g== X-Received: by 2002:a05:6512:3b0c:b0:59a:11b2:2c08 with SMTP id 2adb3069b0e04-59a17dd5fb7mr9312428e87.43.1766928596662; Sun, 28 Dec 2025 05:29:56 -0800 (PST) Received: from ?IPV6:2a00:1fa0:425c:b771:d34f:d055:3147:bcd9? ([2a00:1fa0:425c:b771:d34f:d055:3147:bcd9]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a185d602fsm8238417e87.11.2025.12.28.05.29.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Dec 2025 05:29:55 -0800 (PST) Message-ID: Date: Sun, 28 Dec 2025 16:29:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 25/28] x86: don't reserve hugetlb memory in setup_arch() To: Mike Rapoport , Andrew Morton Cc: Alex Shi , Alexander Gordeev , Andreas Larsson , Borislav Petkov , Brian Cain , "Christophe Leroy (CS GROUP)" , Catalin Marinas , "David S. Miller" , Dave Hansen , David Hildenbrand , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Jonathan Corbet , "Liam R. Howlett" , Lorenzo Stoakes , Magnus Lindholm , Matt Turner , Max Filippov , Michael Ellerman , Michal Hocko , Michal Simek , Muchun Song , Oscar Salvador , Palmer Dabbelt , Pratyush Yadav , Richard Weinberger , Russell King , Stafford Horne , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Vlastimil Babka , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org References: <20251228124001.3624742-1-rppt@kernel.org> <20251228124001.3624742-26-rppt@kernel.org> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: <20251228124001.3624742-26-rppt@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251228_053000_537100_1C2A3CE3 X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On 12/28/25 3:39 PM, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Commit 665eaf313314 ("x86/setup: call hugetlb_bootmem_alloc early") > added an early call to hugetlb_bootmem_alloc() to setup_arch() to allow > HVO style pre-initialization of vmemmap on x86. > > With the ordering of hugetlb reservation vs memory map initiaization > sorted out in core MM this no longer needs to be an architecture specific > quirk. > > Drop the call to hugetlb_bootmem_alloc() from x86::setup_arch(). > > Signed-off-by: Mike Rapoport (Microsoft) > --- > arch/x86/kernel/setup.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index 1b2edd07a3e1..e2318fa9b1bb 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -1191,7 +1191,6 @@ void __init setup_arch(char **cmdline_p) > > if (boot_cpu_has(X86_FEATURE_GBPAGES)) { > hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT); > - hugetlb_bootmem_alloc(); > } You need to drop {} now, no? But seeing that this *if* gets dropped altogether in the next patch, you may as well ignore me... :-) [...] MBR, Sergey _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc