From: Shahab Vahedi <Shahab.Vahedi@synopsys.com>
To: Arnout Vandecappelle <arnout@mind.be>,
Shahab Vahedi <Shahab.Vahedi@synopsys.com>,
"buildroot@buildroot.org" <buildroot@buildroot.org>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [Buildroot] [PATCH] package/bpftool: add a patch to fix cross compilation
Date: Mon, 13 Jun 2022 20:48:38 +0000 [thread overview]
Message-ID: <fcddbfa3-9d7a-e809-630c-b157b5d6c8bf@synopsys.com> (raw)
In-Reply-To: <6592891c-1b2d-d1cb-f34b-3e96f23e74cb@mind.be>
Arnout,
On 6/13/22 22:21, Arnout Vandecappelle wrote:
>> The patch file should be git-formatted and have your Signed-off-by.
> I simply took the patch from [1] (which has your signoff) and added
> the additional Makefile.include changes
Thanks for the tweak. I overlooked the "Sign-off" part. I used "diff"
because of what BR's manual suggests [1]:
If the software is under version control, it is recommended to use
the upstream SCM software to generate the patch set.
Otherwise, concatenate the header with the output of the
diff -purN ...
The proposed patch was made for a tar ball release that is not under
any version control per se. With the hindsight, maybe I should have
checked for "v6.8.0" as branch/tag in upstream repo.
> (of which I don't really understand BTW why they're relevant for Buildroot).
That extra change (setting "HOSTAR") is necessary, because in upstream
that was already taken care of before the patch submission. However, in
v6.8.0 release "HOSTAR" is never initialised and the fix is actually
using it.
[1]
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
Cheers,
Shahab
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2022-06-13 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 13:33 [PATCH] package/bpftool: add a patch to fix cross compilation Shahab Vahedi
2022-06-13 20:21 ` [Buildroot] " Arnout Vandecappelle
2022-06-13 20:48 ` Shahab Vahedi [this message]
2022-06-14 17:04 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcddbfa3-9d7a-e809-630c-b157b5d6c8bf@synopsys.com \
--to=shahab.vahedi@synopsys.com \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox