From: Simon Trimmer <simont@opensource.cirrus.com>
To: "'Luke D. Jones'" <luke@ljones.dev>, <tiwai@suse.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-sound@vger.kernel.org>,
<rf@opensource.cirrus.com>, <foss@athaariq.my.id>,
<sbinding@opensource.cirrus.com>, <kailang@realtek.com>,
<perex@perex.cz>
Subject: RE: [PATCH] ALSA: hda/realtek: fixup ASUS GA605W
Date: Thu, 10 Oct 2024 10:53:49 +0100 [thread overview]
Message-ID: <000d01db1afa$4e76b430$eb641c90$@opensource.cirrus.com> (raw)
In-Reply-To: <20241009205800.40570-1-luke@ljones.dev>
On Wed, Oct 09, 2024, Luke D. Jones wrote:
> The GA605W laptop has almost the exact same codec setup as the GA403
> and so the same quirks apply to it.
>
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
> ---
> sound/pci/hda/patch_realtek.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 41e1119877b3..19b0bae074b6 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10507,7 +10507,7 @@ static const struct snd_pci_quirk
> alc269_fixup_tbl[] = {
...
> SND_PCI_QUIRK(0x1043, 0x1e63, "ASUS H7606W",
ALC285_FIXUP_CS35L56_I2C_2),
> - SND_PCI_QUIRK(0x1043, 0x1e83, "ASUS GA605W",
ALC285_FIXUP_CS35L56_I2C_2),
> + SND_PCI_QUIRK(0x1043, 0x1e83, "ASUS GA605W",
ALC285_FIXUP_ASUS_GA403U_HEADSET_MIC),
...
Hi Luke,
Thanks!
The support code for the CS35L56 has changed a little in Takashi's branches
from what that patch was generated against and there is no longer an
existing quirk in the fixup table to trigger the component binding (but the
general idea seems reasonable to hook the fixup of the headset mic).
Cheers,
-Simon
next prev parent reply other threads:[~2024-10-10 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 20:58 [PATCH] ALSA: hda/realtek: fixup ASUS GA605W Luke D. Jones
2024-10-10 9:53 ` Simon Trimmer [this message]
2024-10-10 12:14 ` Takashi Iwai
2024-10-10 13:20 ` Simon Trimmer
2024-10-10 14:37 ` Takashi Iwai
2024-10-10 15:07 ` Richard Fitzgerald
2024-10-10 15:18 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000d01db1afa$4e76b430$eb641c90$@opensource.cirrus.com' \
--to=simont@opensource.cirrus.com \
--cc=foss@athaariq.my.id \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox