Linux Sound subsystem development
 help / color / mirror / Atom feed
From: "Stefan Binding \(Opensource\)" <sbinding@opensource.cirrus.com>
To: "'Takashi Iwai'" <tiwai@suse.de>
Cc: "'Sven Jans'" <skbotnl@disroot.org>,
	"'David Rhodes'" <david.rhodes@cirrus.com>,
	"'Richard Fitzgerald'" <rf@opensource.cirrus.com>,
	"'Jaroslav Kysela'" <perex@perex.cz>,
	"'Takashi Iwai'" <tiwai@suse.com>, <linux-sound@vger.kernel.org>,
	<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx
Date: Wed, 15 Jul 2026 17:13:49 +0100	[thread overview]
Message-ID: <003701dd1474$ebe66650$c3b332f0$@opensource.cirrus.com> (raw)
In-Reply-To: <87pl0owccc.wl-tiwai@suse.de>

Hi Takashi,

Yes, this is one of the laptops with malformed ACPI.

Thanks,
Stefan

> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Wednesday, July 15, 2026 3:35 PM
> To: Stefan Binding <sbinding@opensource.cirrus.com>
> Cc: Sven Jans <skbotnl@disroot.org>; David Rhodes
> <david.rhodes@cirrus.com>; Richard Fitzgerald <rf@opensource.cirrus.com>;
> Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; linux-
> sound@vger.kernel.org; patches@opensource.cirrus.com; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop
> 16-bh0xxx
> 
> On Thu, 09 Jul 2026 23:43:53 +0200,
> Sven Jans wrote:
> >
> > The laptop has a malformed _DSD which causes the cirrus,dev-index
> > property to fail to parse, so it needs to be supported using the
> > configuration table.
> >
> > Signed-off-by: Sven Jans <skbotnl@disroot.org>
> > ---
> > Resubmission, discussion of the previous submission stalled.
> > The values are equal to the values reported in the _DSD.
> > You can find my ACPI dump to verify here:
> > https://bugzilla.kernel.org/attachment.cgi?id=310050
> > Link to v1:
> > https://lore.kernel.org/linux-sound/20260506181807.22547-1-
> skbotnl@dis
> > root.org/
> 
> Stefan, is this also one of models with odd firmware?
> 
> 
> thanks,
> 
> Takashi
> 
> >
> >  sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> > b/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> > index 416d7bf3e289..e14a87336478 100644
> > --- a/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> > +++ b/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> > @@ -85,6 +85,7 @@ static const struct cs35l41_config
> cs35l41_config_table[] = {
> >  	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0, 1, -1, 1000, 4100, 24 },
> >  	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0, 1, -1, 1000, 4100, 24 },
> >  	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0,
> > 1, -1, 1000, 3900, 24 },
> > +	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0,
> > +1, -1, 1000, 4500, 24 },
> >  	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 1, 2, 0, 1000, 4500, 24 },
> >  	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0, 1, -1, 1000, 4500, 24 },
> >  	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0,
> > 1, -1, 1000, 4500, 24 }, @@ -511,6 +512,7 @@ static const struct
> cs35l41_prop_model cs35l41_prop_model_table[] = {
> >  	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
> >  	{ "CSC3551", "103C8CDD", generic_dsd_config },
> >  	{ "CSC3551", "103C8CDE", generic_dsd_config },
> > +	{ "CSC3551", "103C8E60", generic_dsd_config },
> >  	{ "CSC3551", "104312AF", generic_dsd_config },
> >  	{ "CSC3551", "10431433", generic_dsd_config },
> >  	{ "CSC3551", "10431463", generic_dsd_config },
> > --
> > 2.55.0
> >


      parent reply	other threads:[~2026-07-15 16:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 21:43 [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx Sven Jans
2026-07-15 14:34 ` Takashi Iwai
2026-07-15 14:54   ` Sven Jans
2026-07-15 16:13   ` Stefan Binding (Opensource) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003701dd1474$ebe66650$c3b332f0$@opensource.cirrus.com' \
    --to=sbinding@opensource.cirrus.com \
    --cc=david.rhodes@cirrus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=skbotnl@disroot.org \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox