From: Simon Trimmer <simont@opensource.cirrus.com>
To: 'Chris Chiu' <chris.chiu@canonical.com>, <perex@perex.cz>,
<tiwai@suse.com>, <kailang@realtek.com>,
<sbinding@opensource.cirrus.com>
Cc: <linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ALSA: hda/realtek: fix micmute LEDs don't work on HP Laptops
Date: Mon, 2 Dec 2024 15:11:55 +0000 [thread overview]
Message-ID: <003a01db44cc$86afb1c0$940f1540$@opensource.cirrus.com> (raw)
In-Reply-To: <20241202144659.1553504-1-chris.chiu@canonical.com>
On Mon, 2 Dec 2024 14:47:00 +0000, Chris Chiu wrote:
> These HP laptops use Realtek HDA codec ALC3315 combined CS35L56
> Amplifiers. They need the quirk ALC285_FIXUP_HP_GPIO_LED to get
> the micmute LED working.
>
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
Reviewed-by: Simon Trimmer <simont@opensource.cirrus.com>
> ---
> sound/pci/hda/patch_realtek.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 2bf5c512ebaf..237e0c17083b 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10521,7 +10521,13 @@ static const struct hda_quirk
> alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8cdf, "HP SnowWhite",
> ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8ce0, "HP SnowWhite",
> ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16",
> ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8d01, "HP ZBook Power 14 G12",
> ALC285_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8d84, "HP EliteBook X G1i",
> ALC285_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8d91, "HP ZBook Firefly 14 G12",
> ALC285_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8d92, "HP ZBook Firefly 16 G12",
> ALC285_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8e18, "HP ZBook Firefly 14 G12A",
> ALC285_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8e19, "HP ZBook Firelfy 14 G12A",
> ALC285_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8e1a, "HP ZBook Firefly 14 G12A",
> ALC285_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA",
> ALC256_FIXUP_ASUS_MIC),
> SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300",
> ALC282_FIXUP_ASUS_TX300),
> SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE",
> ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-12-02 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 14:46 [PATCH] ALSA: hda/realtek: fix micmute LEDs don't work on HP Laptops Chris Chiu
2024-12-02 15:11 ` Simon Trimmer [this message]
2024-12-02 15:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003a01db44cc$86afb1c0$940f1540$@opensource.cirrus.com' \
--to=simont@opensource.cirrus.com \
--cc=chris.chiu@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox