RE: [PATCH 2/2] ALSA: hda/realtek: Fix Asus Z13 2025 audio

["Stefan Binding (Opensource)" <sbinding@opensource.cirrus.com>]

Hi,

> -----Original Message-----
> From: Antheas Kapenekakis <lkml@antheas.dev>
> Sent: Monday, February 24, 2025 4:10 PM
> To: linux-sound@vger.kernel.org; kailang@realtek.com
> Cc: linux-kernel@vger.kernel.org; perex@perex.cz; tiwai@suse.com;
> baojun.xu@ti.com; simont@opensource.cirrus.com; Antheas Kapenekakis
> <lkml@antheas.dev>; Kyle Gospodnetich <me@kylegospodneti.ch>
> Subject: [PATCH 2/2] ALSA: hda/realtek: Fix Asus Z13 2025 audio
> 
> dsdt entry is the same as the original Ally, so borrow its quirks.
> Sound works in both speakers, headphones, and microphone. Whereas none
> worked before.

This laptop is in the list of laptops that I was planning to upstream, but I
am currently waiting on testing for this generation of laptops.
The Ally fixups do some extra stuff in the Realtek driver, which may or may
not apply to this laptop.  I believe the minimum fixup required for this
laptop is ALC287_FIXUP_CS35L41_I2C_2, but I don't have the laptop to test
that.
If possible, could you provide an acpidump of this system, so I can compare
against what I have?

It would be better to wait until we have tested this generation of laptops,
after which I can upstream the kernel patches to support them, as well as
the firmware.

Thanks,
Stefan

> 
> Tested-by: Kyle Gospodnetich <me@kylegospodneti.ch>
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 1771e3b5618d..62c77db73df9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10699,6 +10699,7 @@ static const struct hda_quirk alc269_fixup_tbl[] =
{
>  	SND_PCI_QUIRK(0x1043, 0x1f1f, "ASUS H7604JI/JV/J3D",
> ALC245_FIXUP_CS35L41_SPI_2),
>  	SND_PCI_QUIRK(0x1043, 0x1f62, "ASUS UX7602ZM",
> ALC245_FIXUP_CS35L41_SPI_2),
>  	SND_PCI_QUIRK(0x1043, 0x1f92, "ASUS ROG Flow X16",
> ALC289_FIXUP_ASUS_GA401),
> +	SND_PCI_QUIRK(0x1043, 0x1fb3, "ASUS ROG Flow Z13 GZ302EA",
> +ALC294_FIXUP_ASUS_ALLY),
>  	SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE",
> ALC256_FIXUP_ASUS_AIO_GPIO2),
>  	SND_PCI_QUIRK(0x1043, 0x31d0, "ASUS Zen AIO 27 Z272SD_A272SD",
> ALC274_FIXUP_ASUS_ZEN_AIO_27),
>  	SND_PCI_QUIRK(0x1043, 0x3a20, "ASUS G614JZR",
> ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS),
> --
> 2.48.1
>