From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40C2317578; Sun, 4 May 2025 20:02:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746388972; cv=none; b=qb8A2wwF0Ft37S52VPWTO0PBw0F/5mw5lAyRQZmIHye3SoolSg0NXfPPw6Rm4nIBrMN2UR0pah2BCavSc9JRVzQeNvZ1X3QdH3hP+ZaL0YEgQ3kxAGG0CTFHPUd6k/8iMqUHGarx+utgu/JyRq0i7XKNv2qQaQ8KOJksId5NcD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746388972; c=relaxed/simple; bh=oLVEQiT1E2hIWP/2lXC5CJo98Oa/o+aN9Njjq9Jx67Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zjebw2+WH6X7ed5oZ7XxbFq80tHhyhc65XuOb9Jp0cK3grBTXCr0A4KroiMvuIjdpZCPGl5An/nA/Zf1IJPG6bzISBsHx6ClumPpaMBTs77dK2h7+RYbkWnmLeQKG6hjgJ+P/wKuyq07NWzkpxmIM5SMwd2FVfCW/upkt2Bz26U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PXQmSqgq; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PXQmSqgq" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-acbb85ce788so958297366b.3; Sun, 04 May 2025 13:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746388967; x=1746993767; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vI9uJQQEGi80Mtf6IsTHJ7pV+pxOXaUOfgENHS4qtWM=; b=PXQmSqgqzLGJ19QFNLgqO4ZWXYANv4FN4LytawNH3kr6bRZMYlvsyqPs7qWdEsJkNA 7hN4L0UONw9lc+ytkgx7ACf+/eDukY8adhYrl/ymU1PRhsrYeYLFKAkSIPrUWzLQX3gd GnWNBqazm/LjhPmPWnKbBmDCuSxMqPvp4XU65/v+cVFB3om5/maDCPhM2gE8WMISOgR9 EWFmKVgeF/pYF0bbNJU2pnwGp8FOZu3losVaIE91wgl/V3lHqnQCbIVEib0Edb6+olKC oeVGkck7/Vulfs2BbV1ZZozh+b+VaiFVlGDUWJdgQ/ruznYBDXYS6SqGHsVQIxFjPP+X gktw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746388967; x=1746993767; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vI9uJQQEGi80Mtf6IsTHJ7pV+pxOXaUOfgENHS4qtWM=; b=eJP5r1ZzPfC8w1zqP/T8SQbz+LlJf1YKFLZ18EP8sv+JdPqSsOBezUEx4ZG6yO1vSj 5VfuiOXBjuOF/R//jQoaYGiStT9n+Oy2mVnasZIe4KgTonQxZaogm2ZQoRtvVFJd7C12 mmPxH+Sk6C/6h6gKtFlisIav436cMeY/Uf/q0pUNds8g5q7Aj6pUl1W5So2OcbT2FY4v Ij8MYs47YWu94VafRpLESQCcGZHRAIe2w9qNi0K02/pPggn80DSAw2xxB/5Z0GTijKwn xIPIEwt/W+klZaajIn7F7YvzjlcY8QlxEZdfb0M+rNaHAl243kUfA5dpSZcB6rl4bGtE NsKw== X-Forwarded-Encrypted: i=1; AJvYcCVNXZyYgM8N5sLuuxIrBivV2zOgiaYRz/fHbRW8xMXBRleUzniSh4sISd5UQFyuwRWiONh9IrDstUXojtQ=@vger.kernel.org, AJvYcCXU/T+4s+m7YQLmM6Lsxwn0Wc/1QpQex9iR6zhhEJzq2iSZmnUNhVErr+jlrGDUqZVOqHrKfZ1n9t/FxnI=@vger.kernel.org X-Gm-Message-State: AOJu0YyEPuX45kil9BRwSmbCQ9yAfLq+xClngdsTV1xlk/1SA74QrHbO AEgUHqZJg7+iIDvlyCdbT/UtyNvyQhIgFTcLtFyV174D4VUjQm+I X-Gm-Gg: ASbGncvbrBlAs3C4d5pIN3v/52tTPetYRx22hIywxZj623QCaeD3I7X1VeXUpbKw5Rm QyAPxR9sd655Vi+Js3KotjhAo9MHlAsgWdv8PRbcExYbwrZypGLAqbe8Y5ToUBpS1pPMenP+lT2 kiV21PtptqGQ4Dne6iQMcvbTyxvDw0ZdtMaM2e5Gto0Na1xxrQ+5SppPyE9uYIjlzPF0sKXIIZp Y/FWU9LT/241wXzz7v2FXtWsCZesqBOAC53s0fiA7Ka/4GuAunOBciFC0fyQ9mIKs6SCgwD9noc YlxYx6Ss1zNitfdIN4oaxrXgkvJrRm86P69mOVgu5pphwToYHAP3 X-Google-Smtp-Source: AGHT+IFzIx0SkLpaMMywlpzI8p9RAg0tFozdlH9E8C95r/IlGPu+9Ld92ZWDv/ibJ5NRkCtXU9wetA== X-Received: by 2002:a17:906:730e:b0:ac8:14ad:f3cf with SMTP id a640c23a62f3a-ad190655119mr501785766b.23.1746388967311; Sun, 04 May 2025 13:02:47 -0700 (PDT) Received: from [192.168.178.68] ([91.90.160.103]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad189146a30sm364682766b.30.2025.05.04.13.02.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 May 2025 13:02:46 -0700 (PDT) Message-ID: <03a18f37-9b22-42bd-a3ca-86c8d95b4b1d@gmail.com> Date: Sun, 4 May 2025 22:02:44 +0200 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [REGRESSION] Resume from suspend broken in 6.15-rc due to ACP changes. To: "Prasad, Prasad" , "Limonciello, Mario" , Mark Brown , "Mukunda, Vijendar" Cc: "regressions@lists.linux.dev" , "linux-sound@vger.kernel.org" , LKML References: <99dce57f-8947-4c7a-abeb-2e27afdd0d65@sirena.org.uk> <1b850037-8361-4c18-a32d-3ca50b69866e@amd.com> <691c35de-f054-40a1-98bb-2b602e256011@amd.com> Content-Language: en-US, pl From: =?UTF-8?Q?Jacek_=C5=81uczak?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/24/25 6:53 PM, Prasad, Prasad wrote: > On 4/24/2025 12:57 AM, Mario Limonciello wrote: >> On 4/23/2025 2:12 PM, Mario Limonciello wrote: >>> On 4/23/2025 10:18 AM, Mario Limonciello wrote: >>>> On 4/23/2025 10:06 AM, Mark Brown wrote: >>>>> On Wed, Apr 16, 2025 at 01:20:33PM +0200, Jacek Luczak wrote: >>>>>> Hi, >>>>>> >>>>>> On my ASUS Vivobook S16 (and on similar ASUS HW - see [1]) on resume >>>>>> from suspend system dies (no logs available) soon after GPU completes >>>>>> resume - I can see the login screen, only power cycle left. >>>>> Are there any updates on this from the AMD side?  As things stand my >>>>> inclination is to revert the bulk of the changes to the driver from >>>>> the >>>>> past merge window, I don't really know anything about this hardware >>>>> specifically and "dies without logs" is obviously giving few hints. >>>>> None of the skipped commits looks immediately suspect, there's >>>>> doubtless >>>>> some unintended change in there. >>>> This is the first I'm hearing of it; I expect we can dig in and find >>>> a solution so we don't need to revert that whole series. >>>> >>>> Let me add Vijendar to check if this jumps out to him what went wrong. >>>> >>>> * Can we please see the full dmesg up to the failure? >>>> * journalctl -k -b-1 can fetch everything from the last boot up >>>> until the freeze. >>>> * Any crash in /var/lib/systemd/pstore by chance? >>>> >>>>> Adding Mario and leaving the context for his benefit. >>>> To double check - can you blacklist the ACP driver and >>>> suspend/resume and everything is OK? >>>> >>>> If possible can you please capture a report with https:// >>>> web.git.kernel.org/pub/scm/linux/kernel/git/superm1/amd-debug- >>>> tools.git/ tree/amd_s2idle.py both in the case of ACP driver >>>> blacklisted and not blacklisted?  I would like to compare. >>>> >>>> Also; can you put all these artifacts I'm asking for into somewhere >>>> non ephemeral like a kernel bugzilla?  You can loop me and Vijendar >>>> into it. >>> FYI - We managed to track an S16 down and can reproduce the issue. >>> It's a NULL pointer deref happening on the resume path. >>> >>> <1>[   74.046372] BUG: kernel NULL pointer dereference, address: >>> 0000000000000010 >>> <1>[   74.046375] #PF: supervisor read access in kernel mode >>> <1>[   74.046377] #PF: error_code(0x0000) - not-present page >>> <6>[   74.046380] PGD 0 P4D 0 >>> <4>[   74.046384] Oops: Oops: 0000 [#1] SMP NOPTI >>> <4>[   74.046389] CPU: 4 UID: 0 PID: 2563 Comm: rtcwake Not tainted >>> 6.15.0-061500rc3-generic #202504202138 PREEMPT(voluntary) >>> Oops#1 Part4 >>> <4>[   74.046394] Hardware name: ASUSTeK COMPUTER INC. ASUS Vivobook >>> S 16 M5606KA_M5606KA/M5606KA, BIOS M5606KA.304 01/24/2025 >>> <4>[   74.046396] RIP: 0010:acp70_pcm_resume+0x4f/0xe0 [snd_acp70] >>> <4>[   74.046405] Code: 48 89 45 d0 e8 c2 da 98 fc 49 8b 5d 50 49 39 >>> de 75 18 eb 7b 48 89 da 4c 89 ee 4c 89 ff e8 29 cc f6 ff 48 8b 1b 4c >>> 39 f3 74 65 <4c> 8b 7b 10 4d 85 ff 74 ef 49 8b 97 c0 00 00 00 48 85 >>> d2 74 e3 8b >>> <4>[   74.046407] RSP: 0018:ffffd12644d13880 EFLAGS: 00010286 >>> <4>[   74.046410] RAX: 0000000000000000 RBX: 0000000000000000 RCX: >>> 0000000000000000 >>> <4>[   74.046412] RDX: 0000000000000000 RSI: 0000000000000000 RDI: >>> 0000000000000000 >>> <4>[   74.046413] RBP: ffffd12644d138b0 R08: 0000000000000000 R09: >>> 0000000000000000 >>> <4>[   74.046415] R10: 0000000000000000 R11: 0000000000000000 R12: >>> ffffffffbd774fd0 >>> <4>[   74.046416] R13: ffff8a9f13051e00 R14: ffff8a9f13051e50 R15: >>> 0000000000000010 >>> <4>[   74.046418] FS:  0000799af9db9740(0000) >>> GS:ffff8aa486e9d000(0000) knlGS:0000000000000000 >>> <4>[   74.046420] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>> <4>[   74.046421] CR2: 0000000000000010 CR3: 000000016dfaa000 CR4: >>> 0000000000f50ef0 >>> <4>[   74.046423] PKRU: 55555554 >>> <4>[   74.046425] Call Trace: >>> <4>[   74.046427]  >>> <4>[   74.046432]  ? __pfx_platform_pm_resume+0x10/0x10 >>> <4>[   74.046439]  platform_pm_resume+0x28/0x60 >>> <4>[   74.046443]  dpm_run_callback+0x63/0x160 >>> <4>[   74.046447]  device_resume+0x15c/0x260 >>> <4>[   74.046450]  dpm_resume+0x15d/0x230 >>> <4>[   74.046453]  dpm_resume_end+0x11/0x30 >>> <4>[   74.046456]  suspend_devices_and_enter+0x1ea/0x2c0 >>> <4>[   74.046460]  enter_state+0x223/0x560 >>> Oops#1 Part3 >>> <4>[   74.046463]  pm_suspend+0x4e/0x80 >>> >>> We'll need some more time to dig into it, but I wanted to share the >>> trace in case it makes it jump out to anyone what's going on. >>> >>> Just looking at git blame from that function is this perhaps >>> 8fd0e127d8da856e34391399df40b33af2b307e0? >> Reverting a95a1dbbd3d64adf392fed13c8eef4f72b4e5b90 seems to help the >> issue on S16 here. >> >> Jacek - can you reproduce with that reverted? > Hi Mark Brown, > > We will send a fix patch to resolve this issue. Hi Folks, I've just build and tested the fixes that are heading to rc5 and the issue is fixed with https://lore.kernel.org/linux-sound/20250425060144.1773265-1-venkataprasad.potturu@amd.com/ Thanks, -Jacek