Linux Sound subsystem development
 help / color / mirror / Atom feed
From: <zhangyi@everest-semi.com>
To: <sammiee5311@gmail.com>
Cc: <zhuning0077@gmail.com>, "'Mark Brown'" <broonie@kernel.org>,
	<linux-sound@vger.kernel.org>
Subject: 回复: es8326, es8375: controls that write each other's bits
Date: Mon, 19 Oct 2026 11:09:47 +0800	[thread overview]
Message-ID: <050201dd5f77$4d32e170$e798a450$@everest-semi.com> (raw)
In-Reply-To: <CAJciObGfAwYw84mVU0knzJcdLkatWsccsijRBT3E9b25CKyF_w@mail.gmail.com>

Hi

	Thank you very much for pointing that out.
	es8326:The ALC Capture Recovery Level should indeed be applied to bits [2:0] of reg0x32, not reg0x33.

	es8375:The ES8375_DMIC_GAIN_MAX should be 0x03

	Thank you again for your email. If possible, please let me fix these two issues this week.

Thanks and Best Regards
--------------------------------------------------------------------------------------
Everest Semiconductor Co., Ltd
张逸   应用工程师 / Michael   FAE
18179079039 
zhangyi@everest-semi.com
------------------------------------------------------------------
上海市徐家汇中山西路2368号华鼎大厦30楼C

-----邮件原件-----
发件人: sammiee5311@gmail.com <sammiee5311@gmail.com> 
发送时间: 2026年10月19日 10:45
收件人: zhangyi@everest-semi.com
抄送: zhuning0077@gmail.com; Mark Brown <broonie@kernel.org>; linux-sound@vger.kernel.org
主题: es8326, es8375: controls that write each other's bits

Hi Zhang Yi,

I am adding a check to ASoC that warns when two controls write overlapping bits of one register. It warns on two Everest drivers, and I cannot tell from the driver which field is right.

es8326: ALC Capture Recovery Level and ALC Capture Target Level are both on ES8326_ALC_LEVEL (0x33), at bits 2:0 and 3:0. The DRC Recovery Level sits on its own ES8326_DRC_RECOVERY register. Should the ALC one be on ES8326_ALC_RECOVERY (0x32) the same way?

es8375: DMIC Volume has shift 2 and max 4, so it writes bits 4:2 of
ES8375_ADC1 (0x17). DMIC Polarity is bit 4 of the same register. Is the DMIC gain field only bits 3:2?

If you can confirm, I will send the fixes.

Best Regards,
HyeongJun


  reply	other threads:[~2026-10-19  3:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19  2:44 es8326, es8375: controls that write each other's bits HyeongJun An
2026-10-19  3:09 ` zhangyi [this message]
2026-10-19  5:10   ` HyeongJun An

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='050201dd5f77$4d32e170$e798a450$@everest-semi.com' \
    --to=zhangyi@everest-semi.com \
    --cc=broonie@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=sammiee5311@gmail.com \
    --cc=zhuning0077@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox