From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4353E30215C for ; Fri, 5 Sep 2025 16:47:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757090868; cv=none; b=eG3pvlIUk7rdetr/D7aAuY1KK6m6FV7ZCf9r70sc7HuLF0+bhW7n9sPuWZ2iVSgEUwHDoIoqTWpUlk969GKXMX3T9SZ3yCtBwfaN+BvlV178qt+8wxiBRfkU/A1GLFWs/SsAO7nZabWia8/04VPtrKm581eC7pkJROkJJ2Jc6zI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757090868; c=relaxed/simple; bh=TkfY89RKRXEALwgB2aNVJLpg692JYnKY4FfUhrmhjUM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aVWG2ds3qHbdVb/jGC89bKAQFNo1nEV9Vn/Tty8wngIkmYbE5u+/SMf5Oni1oSVMgMpE1MPjaThdiwsf3XaOihQxDgKKuiYJtY2iFzY9Ezno5zSbIPkJBEUZoIYxFaSh+sfEQ97+VfQh+YAVj4R2LWm5HsYj+NSRpXmZM27+kb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PdAciHQ2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PdAciHQ2" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 585Cw0TZ028221 for ; Fri, 5 Sep 2025 16:47:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UUdgNg/39urdaUGy5tuNL+v9wjA5hMimn7UR8IzRX/Q=; b=PdAciHQ2LJAlN3lz mhfyemdXnUhAmCxtsYv54lZFu/YK+QqDMz9kGCQys1dPqVHD/b2muwcqnzvC4RaO nkW0KBEzjPRZ7o8UL/I/qrEQCG4soGkbi6y3GUpCev3WtEY//5mc32yEInyBXeFe hcjDPgfoaHE/j92vUC1xCyRznE7QMlR/3VDlzq/dsowpB4D0/Ojf6phUR90hGkSy q/1w+aQ0L5hGwBSU4E7SFZEiZq++32A/Ys+XvNs0A+Kzi48Vs11OCKA8+ZTeDHyg WV0KqaxhM/YrHWwFqbkZfYeJ/KjBl1/E+b8intGJlkacHB1gEEhBcm6hI/9ENAWx 47RKIA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48uq0ev15k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 05 Sep 2025 16:47:46 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-7222232866aso51040696d6.0 for ; Fri, 05 Sep 2025 09:47:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757090865; x=1757695665; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UUdgNg/39urdaUGy5tuNL+v9wjA5hMimn7UR8IzRX/Q=; b=CQUgnzokocX5VCQdF9G3IrQnjTr+3AuCJJvQz1aoXFPVom52ByLdiIzmG84pxLpAMP JBIN6+Pg85sd/obCs+vgOZMKqPb5w0WREk78VAGwX2TPzOPa3tATxOrMGdaFmUsbXKGH GtRpBqntm4ALcfyiGP+cf0YhacLOtc2V9Us7SWDMF4Ft/7yvdzHfpYIX+l2ApLlXzvMZ HSYQdco65iKh3lnmfqkjv/HG1kS8gDu2b6zM5YTOnDDJnKQWnj0xdXYQVGZsHNCA/8Yb IsSbNisBdCa8u3GFFrBOs6xyNUVRQkoxnzDOwgJpbvyDtVcHEXMIzFUuKOp48jotTIJi ykiw== X-Forwarded-Encrypted: i=1; AJvYcCV5U7lB6eYC+dtSK+csZMhTLM+y1odHV/njEIb8/7px6fGIEKH68hctKPcQUoopy2KNTAjbcSsM+CeB9A==@vger.kernel.org X-Gm-Message-State: AOJu0YxXL51iXhRUjggUpH0w2ywfNdiLQpLu4uAaQDN6qe6OHlN/UYpK YEdqdnWvLUM93C5458S+2UFq8hjw6PcqHD+9XINw7n2NpPPh//zc/GjQLbSlilOyWbIkPxJuqVI BNkNz7tA2/wXMJECem7du4UpmQLgmfPvoFCoJoklFTP6m/Fueqvgwyw9l5pHfHEenww== X-Gm-Gg: ASbGncs0e5CxRdQZvx0V/4BFM3VADJ3uw2r+g/Erwq/vZx6mBjCdJ63b+QcA/7WFmzO N0pkNS5KTV/uQqnwiYVBWi81j4CAT4ZAZIc0Yk4I3p2exSlUAtU+US8DMpTzQQKFWhOdTXjZXza DZE729fquSuld+T2wnsI4y3aqH9BHiLNeLRAAsJbTxH9J0Yab9sXN8DPXMcZYxLeXjcIKDx+k17 rN2sX4qGw3Uy/rrwSA5lR0xvpKCPaE+Ql/Kltd5/Z6uKNl+ShmiskTMWwz95dk8AKsesp04QNtG 9WC62vAHLgdHC9KQjf+NqOjWBusqCeW8kzArjI0fIzfxKC6VC5iAasth/gi+0pnUZd8= X-Received: by 2002:ad4:5fc5:0:b0:707:6cf8:5963 with SMTP id 6a1803df08f44-72bbf3fb0b1mr43965576d6.9.1757090864926; Fri, 05 Sep 2025 09:47:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZ8+8+MxEUmtiGkpVpKbOO3CIojnpVHP4pNFKV12I5SozNXXmspK50f6RKTZrWEioefG8OdQ== X-Received: by 2002:ad4:5fc5:0:b0:707:6cf8:5963 with SMTP id 6a1803df08f44-72bbf3fb0b1mr43965196d6.9.1757090864286; Fri, 05 Sep 2025 09:47:44 -0700 (PDT) Received: from [192.168.68.119] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3d66b013b7dsm20987137f8f.28.2025.09.05.09.47.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Sep 2025 09:47:43 -0700 (PDT) Message-ID: <08afe342-e108-4f0c-9903-fb4df4eb860e@oss.qualcomm.com> Date: Fri, 5 Sep 2025 17:47:42 +0100 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/12] ASoC: codecs: wcd937x: set the comp soundwire port correctly To: Dmitry Baryshkov Cc: broonie@kernel.org, lgirdwood@gmail.com, tiwai@suse.com, vkoul@kernel.org, srini@kernel.org, yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, neil.armstrong@linaro.org, krzysztof.kozlowski@linaro.org, linux-sound@vger.kernel.org, Stable@vger.kernel.org References: <20250905154430.12268-1-srinivas.kandagatla@oss.qualcomm.com> <20250905154430.12268-2-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: V9Ye05Gnoe0ZF5KLpGKFA0lTBC8w98Tl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAwNCBTYWx0ZWRfX22VSOToBtdzj TGYNDyKG83ZA+o3ZbyZzkmCtIPHcBrTh/fQ8pYxbklgrvgdlmCZbbgE2Bm9un9UHKrW6nGVFGUf sU/U1e0TmAN0oE7KqYpEW7Oe2DSUtiRAX9mp2v23pnKC/KUho1p2Ud7+/hKbDOCONnQe3QFSwSD iC/RZdCUIy0qGVeSOjNXP4/i892BcsgzhP1yuklqhlpilMO4ZPZ/yLlDE3353PfWrua7JAPSnsf dnXAEcHAI03KGdsnoj55d2V1XJ52ST3f7JWg5fwmJ4bf9E1mgm4F982YvmkMCcHx7c+aKKv+6EV bOFW6FEf3qxm09bKct2JywYNegFCQVB1x04i83KeFdOMcFqpqgmQ/205Exuhh++9izQ/+z38HkK KPyK592N X-Proofpoint-ORIG-GUID: V9Ye05Gnoe0ZF5KLpGKFA0lTBC8w98Tl X-Authority-Analysis: v=2.4 cv=ea09f6EH c=1 sm=1 tr=0 ts=68bb1432 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=OWw5mONqTAKyzQI3keYA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-05_05,2025-09-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 clxscore=1015 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300004 On 9/5/25 5:14 PM, Dmitry Baryshkov wrote: > On Fri, Sep 05, 2025 at 04:44:19PM +0100, Srinivas Kandagatla wrote: >> For some reason we endup with setting soundwire port for >> HPHL_COMP and HPHR_COMP as zero, this can potentially result >> in a memory corruption due to accessing and setting -1 th element of >> port_map array. > > Nit: if passing 0 here might result in a memory corrution, then > corresponding code should be fixed to warn loudly and ignore that 0. Agreed, This is something that should be fixed at source am on it. --srini > >> >> Fixes: 82be8c62a38c ("ASoC: codecs: wcd937x: add basic controls") >> Cc: >> Signed-off-by: Srinivas Kandagatla >> --- >> sound/soc/codecs/wcd937x.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/sound/soc/codecs/wcd937x.c b/sound/soc/codecs/wcd937x.c >> index 3b0a8cc314e0..de2dff3c56d3 100644 >> --- a/sound/soc/codecs/wcd937x.c >> +++ b/sound/soc/codecs/wcd937x.c >> @@ -2046,9 +2046,9 @@ static const struct snd_kcontrol_new wcd937x_snd_controls[] = { >> SOC_ENUM_EXT("RX HPH Mode", rx_hph_mode_mux_enum, >> wcd937x_rx_hph_mode_get, wcd937x_rx_hph_mode_put), >> >> - SOC_SINGLE_EXT("HPHL_COMP Switch", SND_SOC_NOPM, 0, 1, 0, >> + SOC_SINGLE_EXT("HPHL_COMP Switch", WCD937X_COMP_L, 0, 1, 0, >> wcd937x_get_compander, wcd937x_set_compander), >> - SOC_SINGLE_EXT("HPHR_COMP Switch", SND_SOC_NOPM, 1, 1, 0, >> + SOC_SINGLE_EXT("HPHR_COMP Switch", WCD937X_COMP_R, 1, 1, 0, >> wcd937x_get_compander, wcd937x_set_compander), >> >> SOC_SINGLE_TLV("HPHL Volume", WCD937X_HPH_L_EN, 0, 20, 1, line_gain), >> -- >> 2.50.0 >> >