From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: phucduc.bui@gmail.com, Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: sprd: sprd-mcdt: Drop redundant error messages
Date: Thu, 30 Jul 2026 10:16:40 +0800 [thread overview]
Message-ID: <0a244759-4524-4e4e-9aa8-cd73eda2ccf9@linux.alibaba.com> (raw)
In-Reply-To: <20260729073532.56468-1-phucduc.bui@gmail.com>
On 7/29/26 3:35 PM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> The called functions already log failures where appropriate. Return the
> original error directly and avoid duplicate error messages.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
LGTM.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> sound/soc/sprd/sprd-mcdt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/sprd/sprd-mcdt.c b/sound/soc/sprd/sprd-mcdt.c
> index 5f3a2a7bce31..d9a7bbd6c0b6 100644
> --- a/sound/soc/sprd/sprd-mcdt.c
> +++ b/sound/soc/sprd/sprd-mcdt.c
> @@ -931,10 +931,8 @@ static int sprd_mcdt_probe(struct platform_device *pdev)
>
> ret = devm_request_irq(&pdev->dev, irq, sprd_mcdt_irq_handler,
> 0, "sprd-mcdt", mcdt);
> - if (ret) {
> - dev_err(&pdev->dev, "Failed to request MCDT IRQ\n");
> + if (ret)
> return ret;
> - }
>
> sprd_mcdt_init_chans(mcdt, res);
>
prev parent reply other threads:[~2026-07-30 2:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 7:35 [PATCH 1/2] ASoC: sprd: sprd-mcdt: Drop redundant error messages phucduc.bui
2026-07-29 7:35 ` [PATCH 2/2] ASoC: sprd: sprd-pcm-dma: " phucduc.bui
2026-07-30 2:16 ` Baolin Wang
2026-07-30 2:16 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a244759-4524-4e4e-9aa8-cd73eda2ccf9@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=tiwai@suse.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox