Re: [PATCH v4 0/3] add sof support on imx95

[Iuliana Prodan <iuliana.prodan@nxp.com>]

On 2/12/2025 12:58 AM, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> Add sof support on imx95. This series also includes some changes to
> the audio-graph-card2 binding required for the support.
For the series:
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

Thanks,
Iulia

> ---
> Changes in v4:
> - addressed Frank's comments regarding the DTS.
> - squashed commits for common and imx95 bindings.
> - dropped patch introducing driver. This was already handled via
> https://lore.kernel.org/all/20250207162246.3104-1-laurentiumihalcea111@gmail.com/
> - introduced two new properties: 'reg-names' and 'memory-region-names',
> which are now needed by the driver to work properly. Because of this, 'reg'
> and 'memory-region' properties had to be moved from the common binding as
> 'reg-names' and 'memory-region-names' depend on them (you'd get a failure
> when running the binding check otherwise).
> - added missing 'bitclock-master' and 'frame-master' properties to codec EP.
> - addressed Krzysztof's comments regarding the imx95 binding
> - added Krzysztof's Acked-by
> - Link to v3: https://lore.kernel.org/lkml/20241216145039.3074-1-laurentiumihalcea111@gmail.com/
>
> Changes in v3:
> - Ordered DT nodes alphabetically
> - Removed 'cpu' and 'cpu_ep' labels from binding example
> - Some small changes to the binding commit messages/titles.
> - Link to v2: https://lore.kernel.org/lkml/20241113195240.3699-1-laurentiumihalcea111@gmail.com/
>
> Changes in v2:
> - Added new binding for 95's CM7 core with SOF. fsl,dsp.yaml is no longer used.
> - "hp-det-gpios" and "widgets" properties now reference the definitions from audio-graph.yaml
> - Removed extra empty spaces from DTS as suggested by Frank
> - Ordered 'edma2', 'sai3', 'wm8962' DT nodes alphabetically. The order of the nodes
> placed inside / is kept the same for readability
> - Ordered driver header files includes alphabetically as suggested by Frank
> - Removed "reg-names" and changed the maximum size of the "reg" property to 1 to align
> with the other NXP CPUs sharing the same programming model (i.e: audio processing with SOF).
> The region described in the DTS is the SRAM and the mailbox region is now hardcoded in the
> driver as an offset to the start of the SRAM region.
> - Added new binding with properties required by all NXP CPUs sharing the same programming
> model (i.e: audio processing with SOF).
> - Various driver adjustments made to accomodate the DT changes + some bug fixing related
> to the mboxes not being requested/free'd on resume/suspend.
> - Fixed value passed to "dma-channel-mask". A set bit means the channel is masked, not the
> other way around.
> - Link to v1: https://lore.kernel.org/lkml/20241023162114.3354-1-laurentiumihalcea111@gmail.com/
> ---
>
> Laurentiu Mihalcea (3):
>    ASoC: dt-bindings: support imx95's CM7 core
>    ASoC: dt-bindings: audio-graph-card2: add widgets and hp-det-gpios
>      support
>    arm64: dts: imx: add imx95 dts for sof
>
>   .../bindings/sound/audio-graph-card2.yaml     |  4 +
>   .../bindings/sound/fsl,imx95-cm7-sof.yaml     | 64 ++++++++++++++
>   .../bindings/sound/fsl,sof-cpu.yaml           | 27 ++++++
>   arch/arm64/boot/dts/freescale/Makefile        |  1 +
>   .../dts/freescale/imx95-19x19-evk-sof.dts     | 85 +++++++++++++++++++
>   5 files changed, 181 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/sound/fsl,imx95-cm7-sof.yaml
>   create mode 100644 Documentation/devicetree/bindings/sound/fsl,sof-cpu.yaml
>   create mode 100644 arch/arm64/boot/dts/freescale/imx95-19x19-evk-sof.dts
>