Re: [PATCH 1/2] ASoC : amd: acp: Update Quirk for Lenovo Platforms

[Syed Saba Kareem <syed.sabakareem@amd.com>]

On 4/3/26 21:03, Mario Limonciello wrote:
> On 4/3/26 5:09 AM, Syed Saba Kareem wrote:
>> Use DMI_MATCH instead of DMI_EXACT_MATCH for the Lenovo SKU,
>> So the quirk is applied to all variants of this model.
>
> This seems to do more than the patch description indicates as it also 
> adds the  | (ASOC_SDW_ACP_DMIC).
>
> Could you add that to the description?
>
> Will send a fresh patch with updated commit description.
>>
>> Fixes: 3acf517e1ae0 ("ASoC: amd: amd_sdw: add machine driver quirk 
>> for Lenovo models")
>> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
>> ---
>>   sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c 
>> b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
>> index 05484c72f9a8..986fefd0de08 100644
>> --- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
>> +++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
>> @@ -99,17 +99,17 @@ static const struct dmi_system_id 
>> soc_sdw_quirk_table[] = {
>>           .callback = soc_sdw_quirk_cb,
>>           .matches = {
>>               DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> -            DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "21YW"),
>> +            DMI_MATCH(DMI_PRODUCT_SKU, "21YW"),
>>           },
>> -        .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
>> +        .driver_data = (void *)((ASOC_SDW_CODEC_SPKR) | 
>> (ASOC_SDW_ACP_DMIC)),
>>       },
>>       {
>>           .callback = soc_sdw_quirk_cb,
>>           .matches = {
>>               DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> -            DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "21YX"),
>> +            DMI_MATCH(DMI_PRODUCT_SKU, "21YX"),
>>           },
>> -        .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
>> +        .driver_data = (void *)((ASOC_SDW_CODEC_SPKR) | 
>> (ASOC_SDW_ACP_DMIC)),
>>       },
>>       {
>>           .callback = soc_sdw_quirk_cb,
>