From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
linux-sound@vger.kernel.org, linux-omap@vger.kernel.org
Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v2] ASoC: ti: rx51: remove stale reference to machine_is_nokia_rx51()
Date: Sun, 10 May 2026 15:22:52 +0300 [thread overview]
Message-ID: <0cc395ef-0b8d-4905-8186-e9e3ba129662@bitmer.com> (raw)
In-Reply-To: <20260510054214.564950-1-enelsonmoore@gmail.com>
On 10/05/2026 8:42 am, Ethan Nelson-Moore wrote:
> The rx51 driver relies on the machine_is_nokia_rx51() macro, which was
> used with the legacy board file dropped in commit 9b7141d01a76 ("ARM:
> OMAP2+: Drop legacy board file for n900"). The use of this macro
> prevents the removal of machine IDs no longer used by the kernel from
> arch/arm/tools/mach-types, because the machine_is_*() macros are
> generated from mach-types. Drop this unused code.
>
> Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com> # v1
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> Changes from v1: Fix mistake in commit message - machine ID checks
> still work with DT booting if the bootloader passes the ID
>
> sound/soc/ti/rx51.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
next prev parent reply other threads:[~2026-05-10 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 5:42 [PATCH v2] ASoC: ti: rx51: remove stale reference to machine_is_nokia_rx51() Ethan Nelson-Moore
2026-05-10 12:22 ` Jarkko Nikula [this message]
2026-05-10 13:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cc395ef-0b8d-4905-8186-e9e3ba129662@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=broonie@kernel.org \
--cc=enelsonmoore@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox