From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F114123E330 for ; Fri, 2 May 2025 11:06:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746184013; cv=none; b=txuwgWxRKS1zW0ZxaKMqWbyOj1W0pa1ajBQg6Gi02dKfNPG3HYuY17Me19Axf5eh3U8swczowrvwFb0pmhbFBMOhz8Q6Cg5gTi3E1iKGuTTNcUeftpne8WYYshSCTDKvwVXBE7lmTWwW+NpUolBya+eD2whXxNUphKTKzyssgQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746184013; c=relaxed/simple; bh=/47+sMA0JkyFBnR95B9nb3p/4mhJHYfJBzwuNp3cdaU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vATgI+WDPcPIXHrWTlPAdavRu3iFp4cTmrx3h94BeHR+UpmIGPw/y89JdJ5voFQA06Pmsj9PCaY6Zu5JDtjN9/DV4968pwvpktGCNguLwpQpjUaPKffw8XaJkalwjCZRGOMrgwuyuHVUXb12AXpTWQwxqnvuIGOzaSIidBqg8ks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lk/jsNsU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lk/jsNsU" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5421N303009494 for ; Fri, 2 May 2025 11:06:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= n1zoogZ0mW4AaQa7oJlvbkJUvuNkb6MBNOT54+2ShgI=; b=lk/jsNsUuvJn+oUC GUrJtP8ak2oQDXtsr3fqw3ytUMcaQATxpYZZQuaLM7TtfKTa4GQjwjIkkO4UXJWK XW8qMwUyc8y/PnUCV/YYfmXxe/k/EEsjJeayFdapxHnYk+sG5pqh5VPrAiMxckrd Z4tHWhFXS5vE4pl08Y0+1z/Pgg3Eq48idLLLP0jtfTcfbO7fVIpF+s697usd5eA0 QNlhh4Ys+9pzC1eMIgenRcRnX50RQ40r97JqnI5rJvyV5pAkOXB6i25al8MbnsSE XeZ/H/P9wsdJqLh0dXGiu2fssuq8LexUWUiy0BQaRW7JUl12H/EhWUeH0/DPT7UL ug8a6Q== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46b6ubr48s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 02 May 2025 11:06:49 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5b9333642so228492685a.3 for ; Fri, 02 May 2025 04:06:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746184009; x=1746788809; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n1zoogZ0mW4AaQa7oJlvbkJUvuNkb6MBNOT54+2ShgI=; b=FDoANUkre/As3cKkoAeYIuGns65+xs4tggI8CfQai1WMomokZM6kk0Gs0BnUdF2+IY 8coMLjQfR/tEwjjNmFwhT6xtCwf9xZe1Sj/HKWYjZCf7qXyqj9ZdSkpgkMMU8c+ihgdr G/fHyXas7Yepz84AW66jmwtbB0vk6fb8028OADhSErK04bk/90Bl0WE/Ss3tngKiVkrd gokzlPvfOzU/8RdHUY+MY6ZnBS0EhyDQ1906XcPSRUUTMeLXPJWHs+yO1QlwZI8rlKuX bv85K8S+q0VY7LpGH1+py1Q8z6rEV6kJC1mgUIx/TEbQ5fimMPbEN2VqB2F7+o7Lh+CB +GPA== X-Forwarded-Encrypted: i=1; AJvYcCX5rPJ7DN5ku+tCnR5y7+XynnOERSx4XOzqbpWysKcFhpHQvF4We7WiEn8eCBmtlBqB0yo9rKHAPxqyHw==@vger.kernel.org X-Gm-Message-State: AOJu0YykTBfFxf/4KISmLchIw1b9+OSYR2tPeZm6DaJz1xnpUJh0GALg IeOdgd67bTGajuFi+sQzNO6Sg8zBd9aYswtjR8VNjSWXK2mJzvlGe146mopi6j2AwVlI2uEC85S WDFaLiNbo8MeTPthpNctOdMvi52/j5UOxo3/SkUOnpMM2SbYBqoLWRPc93IpGew== X-Gm-Gg: ASbGnctxhvC1laNKX94LMS+aQ1C+YVXCWVmXrI1Q/R8BM7HMsW72ewkoy4gjW9JLVG9 oZC5SGHspCkAj1S4GRtf+0LZdcZ43+Ga8ykqjlofv75WLz6VarOzXNmnNyDGOMbRudJ4eRogs2w 21duEBB+81OiWueLrYoNvvLk2qmYtzNn1T7o3H5SJFFuK2JkMttuOR3RBIVe5zVHThMPWljYQFZ LYMDbBgAPY3VVBfy7I9OJDr9dCEMrj3qtpsnh2py3mPFyaY+mUWRO0D9H9y0y3VR4vfnddqCA/t 59xg7zFUSmG76VjJfvTlYwh5+6El478LxLMVRw== X-Received: by 2002:a05:620a:440c:b0:7ca:ca21:23d9 with SMTP id af79cd13be357-7cad5b1e908mr390997485a.7.1746184008909; Fri, 02 May 2025 04:06:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFxEfw/oGZXNbT+wq9xh4TIiYE0dP+RWQJIzPOf851X459NKI0wxZw1jeI309e25HlZlax9AQ== X-Received: by 2002:a05:620a:440c:b0:7ca:ca21:23d9 with SMTP id af79cd13be357-7cad5b1e908mr390992385a.7.1746184008501; Fri, 02 May 2025 04:06:48 -0700 (PDT) Received: from [192.168.68.119] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a099ae7afesm1820418f8f.47.2025.05.02.04.06.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 May 2025 04:06:48 -0700 (PDT) Message-ID: <0d094cec-0a2e-4e21-845f-977f3a77993d@oss.qualcomm.com> Date: Fri, 2 May 2025 12:06:47 +0100 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/5] ASoC: qcom: sm8250: set card driver name from match data To: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, Srinivas Kandagatla , Luca Weiss Cc: Banajit Goswami , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Bjorn Andersson , Konrad Dybcio , phone-devel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Neil Armstrong References: <20250425-fp5-dp-sound-v3-0-7cb45180091b@fairphone.com> <20250425-fp5-dp-sound-v3-2-7cb45180091b@fairphone.com> <91110CA9-6E83-4811-AA04-C0312B99B95E@lucaweiss.eu> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <91110CA9-6E83-4811-AA04-C0312B99B95E@lucaweiss.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: y4dP_5qRZwIubrz1m0HWRMrrILG1V8OT X-Authority-Analysis: v=2.4 cv=bsxMBFai c=1 sm=1 tr=0 ts=6814a749 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=6H0WHjuAAAAA:8 a=-0JhTq91CruwOFu3ng0A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTAyMDA4NyBTYWx0ZWRfX8czYCWrtTc4r szIw26EwCsbAr7kwypnGVCo5O0BimWGFt06fYR2gsk9VgA9wHjY1BO1hOnMV5+U7Nve98/lU698 M2ek7lGvrH4h2gO1C0GM4r8uowUjdNhKc/dHdKz/RCzueGQ1VHOSpFp83N9MCNsKGp9qxpmL96A X8mfbtPasu7PZ2fTYkT7JS2yPruyy+tn+XQ5h1xVc46UWLXV//15885z+xPQCaHBrmoA2v2tLge 9OAPeeqZCMvhhl+p10uGCunGlXxQ63nj2vKPjy8R158cDLkIECj/tQA72FCZYVzATP02WiZg2vq Jln1nhlgD9XcSj7rqeNS3hGYibrwN/TbbXyZhTjXS6HwBlqT4RsnyEoWWeHVB7OcFQNVrsCsX/j R5SD7SPXxM+qD1uk2l1T9byQX+VhMSAo+5F/m/ZubSXWlsRZXTxOsGMQ+cBmkcwHjMoPZ7vm X-Proofpoint-ORIG-GUID: y4dP_5qRZwIubrz1m0HWRMrrILG1V8OT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-02_01,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1011 mlxscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505020087 On 5/1/25 15:13, Luca Weiss wrote: > Hi Srini, > > Srinivas Kandagatla schreef op 1 mei 2025 13:37:45 CEST: >> On Fri, Apr 25, 2025 at 10:07:26AM +0200, Luca Weiss wrote: >>> Sound machine drivers for Qualcomm SoCs can be reused across multiple >>> SoCs. But user space ALSA UCM files depend on the card driver name which >>> should be set per board/SoC. >>> >>> Allow such customization by using driver match data as sound card driver >>> name. >>> >>> Also while we're already touching these lines, sort the compatibles >>> alphabetically. >>> >>> Reviewed-by: Dmitry Baryshkov >>> Reviewed-by: Neil Armstrong >>> Signed-off-by: Luca Weiss >>> --- >>> sound/soc/qcom/sm8250.c | 9 ++++----- >>> 1 file changed, 4 insertions(+), 5 deletions(-) >>> >>> diff --git a/sound/soc/qcom/sm8250.c b/sound/soc/qcom/sm8250.c >>> index b70b2a5031dfbf69024666f8a1049c263efcde0a..e920b413b762c803cfcc4049f35deba828275478 100644 >>> --- a/sound/soc/qcom/sm8250.c >>> +++ b/sound/soc/qcom/sm8250.c >>> @@ -16,7 +16,6 @@ >>> #include "usb_offload_utils.h" >>> #include "sdw.h" >>> >>> -#define DRIVER_NAME "sm8250" >>> #define MI2S_BCLK_RATE 1536000 >>> >>> struct sm8250_snd_data { >>> @@ -200,15 +199,15 @@ static int sm8250_platform_probe(struct platform_device *pdev) >>> if (ret) >>> return ret; >>> >>> - card->driver_name = DRIVER_NAME; >>> + card->driver_name = of_device_get_match_data(dev); >>> sm8250_add_be_ops(card); >>> return devm_snd_soc_register_card(dev, card); >>> } >>> >>> static const struct of_device_id snd_sm8250_dt_match[] = { >>> - {.compatible = "qcom,sm8250-sndcard"}, >>> - {.compatible = "qcom,qrb4210-rb2-sndcard"}, >>> - {.compatible = "qcom,qrb5165-rb5-sndcard"}, >>> + { .compatible = "qcom,qrb4210-rb2-sndcard", .data = "sm8250" }, >> >> sm4250 for rb2? > > Since this name is visible to user space and used for picking the UCM config, I don't think it's a good idea to change it. > It is not correct to pretend that rb2 is sm8250 for ucm cases, I agree previous code was already doing this, Good thing is that we do not have a ucm written yet for RB2. Lets fix this as you are already doing this for other compatibles. --srini > Regards > Luca > >> >>> + { .compatible = "qcom,qrb5165-rb5-sndcard", .data = "sm8250" }, >>> + { .compatible = "qcom,sm8250-sndcard", .data = "sm8250" }, >>> {} >>> }; >>> >>> >>> -- >>> 2.49.0 >>>