From: Mark Brown <broonie@kernel.org>
To: "Sheetal ." <sheetal@nvidia.com>
Cc: Sander Vanheule <sander@svanheule.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] regmap: Add cache_default_is_zero flag for flat cache
Date: Wed, 7 Jan 2026 11:20:26 +0000 [thread overview]
Message-ID: <0ece3e08-3ffc-418c-9e7b-eaf098fb49bc@sirena.org.uk> (raw)
In-Reply-To: <b0032054-4eea-44f4-bf70-204fa414f297@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Wed, Jan 07, 2026 at 12:25:01PM +0530, Sheetal . wrote:
> On 06-01-2026 20:42, Mark Brown wrote:
> > Why do this on first read rather than than just fill the valid flags
> > during initialisation?
> Setting valid bits on first read rather than bitmap_fill() at init ensures:
> - Only accessed registers are marked valid
> - regcache_sync() only syncs registers that were actually used
> - Avoids writes to holes or unused registers during sync
> - Safer for drivers without writeable_reg callback
Seems reasonable, put that in the changelog please.
BTW I forgot in my initial review but please add KUnit coverage for
this, we've got good coverage of the cache code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-01-07 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 14:08 [RFC PATCH 0/2] regmap: Add cache_default_is_zero flag for flat cache Sheetal .
2026-01-06 14:08 ` [RFC PATCH 1/2] " Sheetal .
2026-01-06 15:12 ` Mark Brown
2026-01-07 6:55 ` Sheetal .
2026-01-07 11:20 ` Mark Brown [this message]
2026-01-06 21:19 ` Sander Vanheule
2026-01-07 7:30 ` Sheetal .
2026-01-06 14:08 ` [RFC PATCH 2/2] ASoC: tegra: Enable cache_default_is_zero for audio drivers Sheetal .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ece3e08-3ffc-418c-9e7b-eaf098fb49bc@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rafael@kernel.org \
--cc=sander@svanheule.net \
--cc=sheetal@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox