Re: [PATCH v2 08/14] ASoC: mediatek: mt8195: Remove redundant error message

[Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>]

On 10/5/2026 4:32 PM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> The errors handled here are already reported by the called functions,
> either directly or deeper in the call chain. Therefore, the additional
> dev_warn() and dev_err_probe() call is redundant and can be removed.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

LGTM

Reviewed-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>

> ---
>   sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
> index bb357cc674cb..1bca2f62e76e 100644
> --- a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
> +++ b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
> @@ -3083,7 +3083,7 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev)
>   	/* initial audio related clock */
>   	ret = mt8195_afe_init_clock(afe);
>   	if (ret)
> -		return dev_err_probe(dev, ret, "init clock error\n");
> +		return ret;
>   
>   	/* reset controller to reset audio regs before regmap cache */
>   	rstc = devm_reset_control_get_exclusive(dev, "audiosys");
> @@ -3130,7 +3130,7 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev)
>   	ret = devm_request_irq(dev, irq_id, mt8195_afe_irq_handler,
>   			       IRQF_TRIGGER_NONE, "asys-isr", (void *)afe);
>   	if (ret)
> -		return dev_err_probe(dev, ret, "could not request_irq for asys-isr\n");
> +		return ret;
>   
>   	/* init sub_dais */
>   	INIT_LIST_HEAD(&afe->sub_dais);
> @@ -3188,10 +3188,9 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev)
>   	/* register component */
>   	ret = devm_snd_soc_register_component(dev, &mtk_afe_pcm_platform,
>   					      afe->dai_drivers, afe->num_dai_drivers);
> -	if (ret) {
> -		dev_warn(dev, "err_platform\n");
> +	if (ret)
>   		goto err_pm_put;
> -	}
> +
>   
>   	ret = regmap_multi_reg_write(afe->regmap, mt8195_afe_reg_defaults,
>   				     ARRAY_SIZE(mt8195_afe_reg_defaults));