Re: [PATCH] ALSA: hda/realtek: Add codec IDs to HP ProBook G8 fixups

[Ilyas Gasanov <public@gsnoff.com>]

On Tue, 02 Dec 2025 17:26 +0400,
Takashi Iwai wrote:
> 
> On Tue, 02 Dec 2025 14:15:08 +0100,
> Ilyas Gasanov wrote:
> > 
> > According to amixer output, as well as the result value of the
> > GET_SUBSYSTEM_ID HDA verb, the codec's own subsystem ID may differ from
> > that of the HDA controller.
> > 
> > The snd_hda_pick_fixup() function specifically inspects just the codec's
> > subsystem ID, ignoring that of the controller, which causes mismatch on
> > machines where the above is the case, unless the codec's subsystem ID is
> > also covered.
> > 
> > For reference:
> > 
> >  - https://linux-hardware.org/?probe=9829e4ea09&log=amixer
> >    (HP ProBook 440 G8, MB 8A74, codec 10ec0236,103c8a7a)
> >  - https://linux-hardware.org/?probe=5b2ca9b826&log=amixer
> >    (HP ProBook 450 G8, MB 8A75, codec 10ec0236,103c8a7b)
> >  - https://linux-hardware.org/?probe=228aee06a5&log=amixer
> >    (HP ProBook 440 G8, MB 8A76, codec 10ec0236,103c8a7c)
> >  - https://linux-hardware.org/?probe=1cd4bf968d&log=amixer
> >    (HP ProBook 450 G8, MB 8A77, codec 10ec0236,103c8a7d)
> > 
> > Signed-off-by: Ilyas Gasanov <public@gsnoff.com>
> 
> The primary matching is with PCI SSID, not the codec SSID.

Good point. There is indeed a semantic difference between the SND_PCI_QUIRK() and HDA_CODEC_QUIRK() macros, specifically where the value of the .match_codec_ssid field is concerned.

> Do they have the same numbers on those machines?

From what it looks like:

 - https://linux-hardware.org/?probe=9829e4ea09&log=lspci
   Device:	00:1f.3
   Class:	Multimedia audio controller [0401]
   SVendor:	Hewlett-Packard Company [103c]
   SDevice:	... [8a74]
   (already covered)

 - https://linux-hardware.org/?probe=5b2ca9b826&log=lspci
   Device:	00:1f.3
   Class:	Multimedia audio controller [0401]
   SVendor:	Hewlett-Packard Company [103c]
   SDevice:	... [8a75]
   (already covered)

 - https://linux-hardware.org/?probe=228aee06a5&log=lspci
   Device:	00:1f.3
   Class:	Multimedia audio controller [0401]
   SVendor:	Hewlett-Packard Company [103c]
   SDevice:	... [8a76]
   (not covered yet)

 - https://linux-hardware.org/?probe=1cd4bf968d&log=lspci
   Device:	00:1f.3
   Class:	Multimedia audio controller [0401]
   SVendor:	Hewlett-Packard Company [103c]
   SDevice:	... [8a77]
   (not covered yet)

In short, PCI SSIDs 0x8a74 and 0x8a75 are already covered within alc269_fixup_tbl, but not 0x8a76 nor 0x8a77.

> 
> 
> thanks,
> 
> Takashi
> 
> > ---
> >  sound/hda/codecs/realtek/alc269.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> > index 4efc16ae6b5d..d34a196158aa 100644
> > --- a/sound/hda/codecs/realtek/alc269.c
> > +++ b/sound/hda/codecs/realtek/alc269.c
> > @@ -6599,6 +6599,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> >  	SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> >  	SND_PCI_QUIRK(0x103c, 0x8a75, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> >  	SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> > +	SND_PCI_QUIRK(0x103c, 0x8a7a, "HP ProBook 440 G8 (MB 8A74)", ALC236_FIXUP_HP_GPIO_LED),
> > +	SND_PCI_QUIRK(0x103c, 0x8a7b, "HP ProBook 450 G8 (MB 8A75)", ALC236_FIXUP_HP_GPIO_LED),
> > +	SND_PCI_QUIRK(0x103c, 0x8a7c, "HP ProBook 440 G8 (MB 8A76)", ALC236_FIXUP_HP_GPIO_LED),
> > +	SND_PCI_QUIRK(0x103c, 0x8a7d, "HP ProBook 450 G8 (MB 8A77)", ALC236_FIXUP_HP_GPIO_LED),
> >  	SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
> >  	SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
> >  	SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)", ALC236_FIXUP_HP_GPIO_LED),
> > -- 
> > 2.51.0
> >