Re: [PATCH 2/2] ASoC: atmel-ssc: use module_platform_driver macro

Russell King - ARM Linux
2012-10-16T09:07:48Z

On Tue, Oct 16, 2012 at 10:49:47AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:07 Tue 16 Oct , Nicolas Ferre wrote:
> > On 10/16/2012 05:56 AM, Bo Shen :
> > > -static int __init ssc_probe(struct platform_device *pdev)
> > > +static int ssc_probe(struct platform_device *pdev)
> >
> > Here you remove the __init altogether, maybe converting to __devinit is
> > the proper replacement for this? I do not know myself but if anybody knows?
> yes __devinit is mandatory

No it isn't. __init is plain buggy. __devinit is better, but there's
plans to remove all __devinit from the kernel. Having nothing there
will make GregKH's life a lot easier when he does come to remove __devinit.