From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
<linux-sound@vger.kernel.org>
Subject: Re: [RFC][PATCH v4 0/2] ASoC: core: use Complete rebind cards by default for all users
Date: Tue, 28 Apr 2026 18:22:42 +0200 [thread overview]
Message-ID: <14a2f5a4-c29a-4aeb-985d-1618feeeb345@intel.com> (raw)
In-Reply-To: <87wlxtxqd1.wl-kuninori.morimoto.gx@renesas.com>
On 2026-04-27 1:18 AM, Kuninori Morimoto wrote:
>
> Hi Cezary
>
>> There is soc_tplg_remove_link() already, I believe introducing
>> soc_tplg_link_release(), an "unbalanced" function goes against the goal
>> of the patch. Internal struct is a heavy hitter, I'd argue it alone
>> defeats the purpose of the patch.
>
> Ah, yes indeed.
>
>> Perhaps we can achieve the goal in multiple steps. Simplify the code
>> implementing the feature by merging 2) and work from there if you
>> believe the readability still isn't where it should be.
>
> Thanks.
> Just I can do is indicate the idea only for topology.
> My posted patch was not good enough, but happy if the idea (= use
> devres_add() to remove rtd/dai-link) acceptable for you.
>
> Thank you for your help !!
Before I send my patch, given your large impact in shaping the subject,
would you like me to add Suggested-by: or Co-developed-by: (you) to the
message?
prev parent reply other threads:[~2026-04-28 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 3:03 [RFC][PATCH v4 0/2] ASoC: core: use Complete rebind cards by default for all users Kuninori Morimoto
2026-04-22 3:04 ` [RFC][PATCH v4 1/2] ASoC: topology: make sure to call snd_soc_remove_pcm_runtime() Kuninori Morimoto
2026-04-22 3:04 ` [RFC][PATCH v4 2/2] ASoC: core: use Complete rebind cards by default for all users Kuninori Morimoto
2026-04-26 14:53 ` [RFC][PATCH v4 0/2] " Cezary Rojewski
2026-04-26 23:18 ` Kuninori Morimoto
2026-04-28 16:22 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14a2f5a4-c29a-4aeb-985d-1618feeeb345@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox