From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: cs35l56: Fix pm_runtime imbalance if suspending before first attach
Date: Mon, 31 Aug 2026 14:10:00 +0100 [thread overview]
Message-ID: <1542cfb8-d2fe-4ecf-b26b-cbb5ccbf41ea@sirena.org.uk> (raw)
In-Reply-To: <20260831094506.57467-1-rf@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
On Mon, Aug 31, 2026 at 10:45:06AM +0100, Richard Fitzgerald wrote:
> Remove the check for init_done in cs35l56_sdw_system_suspend(). Instead,
> protect the call to cs35l56_mask_soundwire_interrupts() to only be done
> if the amp is currently enumerated.
> @@ -386,11 +386,8 @@ static int __maybe_unused cs35l56_sdw_system_suspend(struct device *dev)
> {
> struct cs35l56_private *cs35l56 = dev_get_drvdata(dev);
>
> - if (!cs35l56->base.init_done)
> - return 0;
> -
> - /* runtime_resume unmasks the interrupt */
> - cs35l56_mask_soundwire_interrupts(cs35l56);
> + if (cs35l56->sdw_attached)
> + cs35l56_mask_soundwire_interrupts(cs35l56);
There's a thin race here on init - we call cs35l56_sdw_init() and unmask
the interrupts prior to setting sdw_attached.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-08-31 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 9:45 [PATCH] ASoC: cs35l56: Fix pm_runtime imbalance if suspending before first attach Richard Fitzgerald
2026-08-31 13:10 ` Mark Brown [this message]
2026-08-31 13:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542cfb8-d2fe-4ecf-b26b-cbb5ccbf41ea@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox