From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CF821586D7; Fri, 31 May 2024 12:48:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=208.88.110.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717159687; cv=none; b=Ta7nCjIlVZzTzWl4b85EsXs0khb98mql5yhZaljRowpFjazSK59PaApqnl2g/GGHvyoGHbLjsDZoGSZ5rf7vou7xJXnUqTdqjt1cQ4X7mWEpGVwqvUBVTI0a/Tc1m2t0PiThST5nSxA0ZquKvGQ7HEhICIs25+SvRMQ5Azp7fpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717159687; c=relaxed/simple; bh=m2xAOXligU3lprYVSulk/dW89+JgHc9BI2bSgA7HNtk=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=EAwYkuJ/A/RcwFEmjCl1nfXYL4OcPNW24e7NxCv/QJx2jfFOXRxjcFEpfjmeVENsA43mxDvY5spPLSD8jVIA9gXsnbAQb9HTiC2a31Ck0lASvdIICkYvh8jlDLc+xcWR5o/OW8SFwEoCHZ9i8E+CSryu09wYVUfaMmwteQkZgVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=savoirfairelinux.com; spf=pass smtp.mailfrom=savoirfairelinux.com; dkim=pass (2048-bit key) header.d=savoirfairelinux.com header.i=@savoirfairelinux.com header.b=jAPZBpE5; arc=none smtp.client-ip=208.88.110.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=savoirfairelinux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=savoirfairelinux.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=savoirfairelinux.com header.i=@savoirfairelinux.com header.b="jAPZBpE5" Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 098449C5848; Fri, 31 May 2024 08:48:05 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id 7N-5VYmiZOoY; Fri, 31 May 2024 08:48:04 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 5AD0E9C595F; Fri, 31 May 2024 08:48:04 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com 5AD0E9C595F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1717159684; bh=h3D/uAawc+I8RbHTAiC8n84YabIXpASHjQyR/gpbrgE=; h=Date:From:To:Message-ID:MIME-Version; b=jAPZBpE5nA8mMRoFEtnR1W6Zxjja92p20x6h8UBQhn2VAhdjUCUIE99bWFtrG1SZ/ 2rgsowCsQ+qWOXBktjyvP8RHaKFXQcSvymNZ8xPQiwraAL7iv/ny7lk3Uw/65LmfMc MWyOEp9aGhNxCeSA8Mu8btlz266RwXJsZCEdehRlne92gwvkwt4HF6araHi24pt5wY hi8uxxjhd+7PJefByXIjys01r5vqtsBzJ8deyrqXfhIk/VcH8UJFnQWg/MlllBHreg hhBfmUo92dFl7h6dXXi6sWAx6e2mzSubC4yWqwWg4v5D/lu4UsnKjSX+zbBbjQ0jp0 7b2bKmYaz/3LQ== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id 14T-wh3CS_eR; Fri, 31 May 2024 08:48:04 -0400 (EDT) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [192.168.48.237]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 2249C9C58EA; Fri, 31 May 2024 08:48:04 -0400 (EDT) Date: Fri, 31 May 2024 08:48:04 -0400 (EDT) From: Elinor Montmasson To: Mark Brown Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , shengjiu wang , Xiubo Lee , Fabio Estevam , Nicolin Chen , Jaroslav Kysela , Takashi Iwai , linux-sound , devicetree , linux-kernel , alsa-devel , linuxppc-dev Message-ID: <1598202415.701258.1717159684103.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <500db9de-6113-4e73-ba92-6e52ea292b32@sirena.org.uk> References: <20240515135411.343333-1-elinor.montmasson@savoirfairelinux.com> <20240515135411.343333-10-elinor.montmasson@savoirfairelinux.com> <599489232.349333.1715936741672.JavaMail.zimbra@savoirfairelinux.com> <500db9de-6113-4e73-ba92-6e52ea292b32@sirena.org.uk> Subject: Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - GC112 (Linux)/8.8.15_GA_4581) Thread-Topic: ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec Thread-Index: +Nt1Jr68s5Clyi+hmHO4sX8bYCaHcg== From: "Mark Brown" Sent: Friday, 17 May, 2024 13:11:43 > On Fri, May 17, 2024 at 05:05:41AM -0400, Elinor Montmasson wrote: >> From: "Mark Brown" > >> > This description (and the code) don't feel like they're actually generic >> > - they're clearly specific to the bidrectional S/PDIF case. I'd expect >> > something called -generic to cope with single CODECs as well as double, >> > and not to have any constraints on what those are. > >> I proposed, in an reply of the v3 patch series to Krzysztof Kozlowski, >> the compatible "fsl,imx-audio-no-codec" instead of "generic". >> Krzysztof thought it was too generic, but it would convey more clearly >> that it is for cases without codec driver. >> Would this other compatible string be more appropriate ? > > No. There is very clearly a CODEC here, it physically exists, we can > point at it on the board and it has a software representation. Your > code is also very specific to the two CODEC case. Then maybe it's not be a good idea to make this compatible generic for this contribution. The original intention is to bring support for the S/PDIF, so maybe the contribution should focus on this use case? In that case, would changing the compatible for "fsl,imx-audio-spdif-card" be acceptable? "fsl,imx-audio-spdif" is already used for the `imx-spdif.c` which does not use the ASRC.