From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SdQ4N9Me" Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75BF0129 for ; Fri, 1 Dec 2023 06:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701441685; x=1732977685; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=EFy9Hh3Cv87FHbJLGd1xdosKaDBGtIirU5TJIkN5is0=; b=SdQ4N9Meuw27ACaps53IfdOJehByf9c2t6tGC6fkqIT79I788XA8DfUc ExaIuwfHlwmQb2OL3+2K23OEQbV9N98+u+CKEsLdg7Q6ozTSb3/jlrqyW 0KFsRk0b3hLnQx0QaRNt661qs8tQgfqqlPuZfwFRYXgTr2gpDYG63gqgp 7jo0JrQrQohmQash8Ixv2RevkU6KJjq1eKh5H1ShabEqOMRF/uzI2Fjiq kWBRxkecwbVZIvbYesEAkI+E6EebRLiaygaMSJCXG/8HlVp9DayYcIKMU V+zcnk2JBAFPqFt4mpHaL+pEHaqDO6bHdWjWlOtRBeaDc/Gjas8VAfExL A==; X-IronPort-AV: E=McAfee;i="6600,9927,10911"; a="424662189" X-IronPort-AV: E=Sophos;i="6.04,241,1695711600"; d="scan'208";a="424662189" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2023 06:41:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10911"; a="943106258" X-IronPort-AV: E=Sophos;i="6.04,241,1695711600"; d="scan'208";a="943106258" Received: from shravans-mobl.amr.corp.intel.com (HELO [10.209.93.166]) ([10.209.93.166]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2023 06:41:24 -0800 Message-ID: <162bf443-37ca-4848-99de-ffb877740f44@linux.intel.com> Date: Thu, 30 Nov 2023 08:27:32 -0600 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] ASoC: Intel: soc-acpi-intel-tgl-match: add cs42l43 and cs56l56 support Content-Language: en-US To: Richard Fitzgerald , Peter Ujfalusi , lgirdwood@gmail.com, broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com, cezary.rojewski@intel.com, yung-chuan.liao@linux.intel.com, ckeepax@opensource.cirrus.com, yong.zhi@intel.com, chao.song@linux.intel.com References: <20231127133448.18449-1-peter.ujfalusi@linux.intel.com> <20231127133448.18449-7-peter.ujfalusi@linux.intel.com> <9660e9df-2061-4b2c-ba59-5e6f8a61f07d@opensource.cirrus.com> <6038c9fa-8cb1-46e1-b856-d759a3f990b3@opensource.cirrus.com> <5e9b0b69-6108-4909-90e8-257c13c2d886@linux.intel.com> <7bae01ac-a0de-47d9-9bd3-6bdfc48e02c1@linux.intel.com> <1b77a7b5-5988-49b2-b356-0d24bb01909d@opensource.cirrus.com> From: Pierre-Louis Bossart In-Reply-To: <1b77a7b5-5988-49b2-b356-0d24bb01909d@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/30/23 04:15, Richard Fitzgerald wrote: > On 29/11/23 16:39, Pierre-Louis Bossart wrote: >> >>>>>>>> +        .name_prefix = "cs35l56-8" >>>>>>> >>>>>>> Can these prefixes be "AMPn" to match the CS35L41, CS35L51 and >>>>>>> CS35L56-hda driver? This prefix is used to find the matching >>>>>>> firmware >>>>>>> files and our naming convention for these has been cs35lxx-xxxx-ampn >>>>>>> >>>>>>> Is there anything that depends on the prefixes being "cs35l56-n" ? >>>>>> >>>>>> IIRC this name_prefix is just used for the codec_conf and hence for >>>>>> control names/UCM. At some point userspace/driver need to know if >>>>>> amp5 >>>>>> is left or right. >>>>>> >>>>>> We can certainly align on conventions but the values set in this ACPI >>>>>> match table will not be used for firmware download - different scope. >>>>>> >>>>> >>>>> They are used for our firmware download. Each amp can have its own >>>>> unique firmware file. The ALSA prefix is used to identify which >>>>> firmware >>>>> file to load to which amp. >>>> >>>> The prefix will only be used when the card is created, specifically for >>>> control names. >>>> The firmware should be selected and downloaded when the device shows up >>>> on the bus. >>>> Card creation and device enumeration/initialization happen on different >>>> timelines, if the machine driver is "blacklisted" or unbound I am not >>>> sure what happens. >>>> >>>> There is a dependency between machine driver probe and codec firmware >>>> download that I am not able to follow, can you please elaborate? >>>> >>> >>> The codec driver has to choose which firmware to load from under >>> /lib/firmware. It does this using a combination of SSID (to identify the >>> target product), the ALSA prefix string (to identify which amp) and >>> in some systems a GPIO on the motherboard to select between different >>> models of speaker when they have multiple suppliers. This results in a >>> firmware name like: >>> >>> cs35l56--dsp1-misc-[-]- >>> >>> You can see this if you look in the linux-firmware repo under cirrus/ >>> for cs35l41 firmware files (though the ALSA PREFIX section in those >>> cases is not "AMPn" because they are not SDCA parts with rotation, >>> they have a fixed left/right assignment.) >>> >>> We have to be careful of the length of the prefix. The 44 characters of >>> an ALSA control name get eaten up very quickly when we start creating >>> fully-qualified names for controls published by the firmware. So "AMPn" >>> was nice because it was descriptive enough but only uses 5 characters >>> of the 44. >>> >>> Having said that, I've calculated that we have enough characters (just) >>> to use a prefix of "cs35l56-n". If there's a reason why that is >>> necessary/desirable for SOF or SoundWire then we could do that. But we'd >>> intended to use "AMPn" prefixes. >>> >>> We just need to decide whether to go with "AMPn". Or switch to using >>> "cs35l56-n" for the ALSA prefix (the therefore the qualifier at the end >>> of the firmware filename). >> >> Yes we have similar issues with control names in topology, the limit is >> hit very quickly. >> >> I think you missed my point though that the ALSA prefix is only set when >> the card is created, which can be sometime after the firmware needs to >> be downloaded. I guess you could pick the firmware in the component >> probe, which happens during the card creation, but that could be >> sub-optimal. Given the download times you want the download to proceed >> as early as possible. > > We kick off a background task from our component_probe() to do the > firmware download. We need the ALSA prefix, and also the wm_adsp library > that actually handles the DSP is ASoC code so it needs a probed > component. Doing it in a background work means it doesn't block probe(). > And the download to multiple amps can proceed in parallel - obviously > that's constrained by bus bandwidth but we are seeing that they > interleave. ah ok, that makes sense. In practice the delta between codec enumeration and component probe is probably negligible, and in a multi-amplifier setup the download times are much larger. So to circle back to the initial feedback, do you mind submitting a patch with the exact naming you'd want for the prefix?