Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: matthias.bgg@gmail.com, eugen.hristev@collabora.com,
	 devicetree@vger.kernel.org, nfraprado@collabora.com,
	 claudiu.beznea@tuxon.dev,
	zhourui@huaqin.corp-partner.google.com,  broonie@kernel.org,
	wenst@chromium.org, dianders@chromium.org,
	 shane.chien@mediatek.com, linux-kernel@vger.kernel.org,
	lgirdwood@gmail.com,  allen-kh.cheng@mediatek.com,
	shraash@google.com, frank.li@vivo.com,  maso.huang@mediatek.com,
	perex@perex.cz, jiaxin.yu@mediatek.com,
	 linux-mediatek@lists.infradead.org,
	u.kleine-koenig@pengutronix.de,  alsa-devel@alsa-project.org,
	trevor.wu@mediatek.com,  nicolas.ferre@microchip.com,
	linux-sound@vger.kernel.org,  amergnat@baylibre.com,
	kernel@collabora.com, tiwai@suse.com,  jarkko.nikula@bitmer.com,
	linux-arm-kernel@lists.infradead.org,
	 kuninori.morimoto.gx@renesas.com,
	 xiazhengqiao@huaqin.corp-partner.google.com,
	ckeepax@opensource.cirrus.com,  alpernebiyasak@gmail.com,
	arnd@arndb.de, krzysztof.kozlowski+dt@linaro.org,
	 conor+dt@kernel.org
Subject: Re: [PATCH v2 20/22] ASoC: dt-bindings: mt8186: Document audio-routing and dai-link subnode
Date: Thu, 07 Mar 2024 07:38:54 -0600	[thread overview]
Message-ID: <170981873072.2495513.10220063572625307394.robh@kernel.org> (raw)
In-Reply-To: <20240307114445.196981-21-angelogioacchino.delregno@collabora.com>


On Thu, 07 Mar 2024 12:44:43 +0100, AngeloGioacchino Del Regno wrote:
> Document the dai-link subnodes and the audio-routing property, allowing
> to describe machine specific audio hardware and links in device tree.
> 
> While at it, also deprecate the old properties which were previously
> used with the driver's partially hardcoded configuration.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../sound/mt8186-mt6366-da7219-max98357.yaml  | 112 ++++++++++++++++--
>  .../sound/mt8186-mt6366-rt1019-rt5682s.yaml   | 102 ++++++++++++++--
>  2 files changed, 199 insertions(+), 15 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mt8186-mt6366-rt1019-rt5682s.example.dtb: mt8186-sound: 'model' does not match any of the regexes: '.*-dai-link$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240307114445.196981-21-angelogioacchino.delregno@collabora.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-03-07 13:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 11:44 [PATCH v2 00/22] ASoC: Cleanup MediaTek soundcard machine drivers AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 01/22] ASoC: mediatek: mt8192-afe-pcm: Convert to devm_pm_runtime_enable() AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 02/22] ASoC: mediatek: mt8192-afe-pcm: Simplify with dev_err_probe() AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 03/22] ASoC: mediatek: Commonize ADDA rate transform functions and enums AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 04/22] ASoC: mediatek: Assign dummy when codec not specified for a DAI link AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 05/22] ASoC: mediatek: Add common machine soundcard driver probe mechanism AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 06/22] ASoC: mediatek: common: Constify struct mtk_sof_priv AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 07/22] ASoC: mediatek: mt8188: Migrate to mtk_soundcard_common_probe AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 08/22] ASoC: mediatek: mt8195: " AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 09/22] ASoC: mediatek: mt8192: " AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 10/22] ASoC: mediatek: mt8186: " AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 11/22] ASoC: mediatek: Add common snd_soc_ops .startup() callback AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 12/22] ASoC: mediatek: mt8195: Migrate to the common mtk_soundcard_startup AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 13/22] ASoC: mediatek: mt8192: " AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 14/22] ASoC: mediatek: mt8186-rt1019: " AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 15/22] ASoC: mediatek: Add common mtk_afe_component_probe callback AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 16/22] ASoC: mediatek: Use common mtk_afe_pcm_platform with common probe cb AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 17/22] ASoC: mediatek: mt8186: Unify mt8186-mt6366 machine drivers AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 18/22] ASoC: dt-bindings: mt8195: Document audio-routing and dai-link subnode AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 19/22] ASoC: dt-bindings: mt8192: " AngeloGioacchino Del Regno
2024-03-07 13:38   ` Rob Herring
2024-03-07 14:12   ` Rob Herring
2024-03-08  8:35     ` AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 20/22] ASoC: dt-bindings: mt8186: " AngeloGioacchino Del Regno
2024-03-07 13:38   ` Rob Herring [this message]
2024-03-07 11:44 ` [PATCH v2 21/22] arm64: dts: mediatek: mt8195-cherry: Specify sound DAI links and routing AngeloGioacchino Del Regno
2024-03-07 11:44 ` [PATCH v2 22/22] arm64: dts: mediatek: mt8186-corsola: " AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170981873072.2495513.10220063572625307394.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=allen-kh.cheng@mediatek.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amergnat@baylibre.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=eugen.hristev@collabora.com \
    --cc=frank.li@vivo.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=jiaxin.yu@mediatek.com \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=maso.huang@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=perex@perex.cz \
    --cc=shane.chien@mediatek.com \
    --cc=shraash@google.com \
    --cc=tiwai@suse.com \
    --cc=trevor.wu@mediatek.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wenst@chromium.org \
    --cc=xiazhengqiao@huaqin.corp-partner.google.com \
    --cc=zhourui@huaqin.corp-partner.google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox