Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Seven Lee <wtli@nuvoton.com>
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	broonie@kernel.org,  linux-sound@vger.kernel.org,
	dardar923@gmail.com,  devicetree@vger.kernel.org,
	CTLIN0@nuvoton.com, lgirdwood@gmail.com,
	 krzysztof.kozlowski+dt@linaro.org, KCHSU0@nuvoton.com,
	perex@perex.cz,  SJLIN0@nuvoton.com, scott6986@gmail.com,
	alsa-devel@alsa-project.org,  edson.drosdeck@gmail.com,
	YHCHuang@nuvoton.com, conor+dt@kernel.org,
	 u.kleine-koenig@pengutronix.de, supercraig0719@gmail.com,
	tiwai@suse.com
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC
Date: Fri, 12 Apr 2024 06:17:27 -0500	[thread overview]
Message-ID: <171292064682.1830010.10520655676449462428.robh@kernel.org> (raw)
In-Reply-To: <20240412103554.3487290-1-wtli@nuvoton.com>


On Fri, 12 Apr 2024 18:35:52 +0800, Seven Lee wrote:
> Change the original fixed delay to the assignment from the property. It
> will make it more flexible to different platforms to avoid pop noise at
> the beginning of recording.
> 
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
>  .../devicetree/bindings/sound/nuvoton,nau8821.yaml        | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/nuvoton,nau8821.example.dtb: codec@1b: Unevaluated properties are not allowed ('nuvoton,nuvoton,adc-delay-ms' was unexpected)
	from schema $id: http://devicetree.org/schemas/sound/nuvoton,nau8821.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240412103554.3487290-1-wtli@nuvoton.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2024-04-12 11:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 10:35 [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC Seven Lee
2024-04-12 10:35 ` [PATCH 2/3] ASoC: " Seven Lee
2024-04-12 10:35 ` [PATCH 3/3] ASoC: nau8821: Remove redundant ADC controls Seven Lee
2024-04-12 11:17 ` Rob Herring [this message]
2024-04-12 15:52 ` [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC Rob Herring
2024-04-15  2:32   ` WTLI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171292064682.1830010.10520655676449462428.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=CTLIN0@nuvoton.com \
    --cc=KCHSU0@nuvoton.com \
    --cc=SJLIN0@nuvoton.com \
    --cc=YHCHuang@nuvoton.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=dardar923@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=edson.drosdeck@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=scott6986@gmail.com \
    --cc=supercraig0719@gmail.com \
    --cc=tiwai@suse.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wtli@nuvoton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox