Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-sound@vger.kernel.org,  Jaroslav Kysela <perex@perex.cz>,
	quic_pkumpatl@quicinc.com,  Takashi Iwai <tiwai@suse.com>,
	linux-arm-msm@vger.kernel.org,
	 Banajit Goswami <bgoswami@quicinc.com>,
	devicetree@vger.kernel.org,  quic_rohkumar@quicinc.com,
	Mark Brown <broonie@kernel.org>,
	 Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 3/8] ASoC: dt-bindings: wcd937x-sdw: add bindings for wcd937x-sdw
Date: Tue, 16 Apr 2024 02:51:44 -0500	[thread overview]
Message-ID: <171325390367.1353462.6738496215058640142.robh@kernel.org> (raw)
In-Reply-To: <20240416063600.309747-4-quic_mohs@quicinc.com>


On Tue, 16 Apr 2024 12:05:55 +0530, Mohammad Rafi Shaik wrote:
> From: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> 
> Qualcomm WCD9370/WCD9375 Codec is a standalone Hi-Fi audio codec IC
> connected over SoundWire. This device has two SoundWire devices RX and
> TX respectively.
> This binding is for those slave devices on WCD9370/WCD9375.
> 
> Co-developed-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> ---
>  .../bindings/sound/qcom,wcd937x-sdw.yaml      | 71 +++++++++++++++++++
>  1 file changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,wcd937x.example.dtb: codec@0,4: 'qcom,port-mapping' is a required property
	from schema $id: http://devicetree.org/schemas/sound/qcom,wcd937x-sdw.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,wcd937x.example.dtb: codec@0,3: 'qcom,port-mapping' is a required property
	from schema $id: http://devicetree.org/schemas/sound/qcom,wcd937x-sdw.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.example.dtb: codec@0,4: 'qcom,port-mapping' is a required property
	from schema $id: http://devicetree.org/schemas/sound/qcom,wcd937x-sdw.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.example.dtb: codec@0,3: 'qcom,port-mapping' is a required property
	from schema $id: http://devicetree.org/schemas/sound/qcom,wcd937x-sdw.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240416063600.309747-4-quic_mohs@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-04-16  7:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16  6:35 [PATCH v2 0/8] ASoC: codecs: wcd937x: add wcd937x audio codec support Mohammad Rafi Shaik
2024-04-16  6:35 ` [PATCH v2 1/8] ASoC: dt-bindings: wcd937x: add bindings for wcd937x Mohammad Rafi Shaik
2024-04-17 15:51   ` Krzysztof Kozlowski
2024-04-22  6:55     ` Mohammad Rafi Shaik
2024-04-16  6:35 ` [PATCH v2 2/8] ASoC: codecs: wcd937x: add wcd937x codec driver Mohammad Rafi Shaik
2024-04-17 20:40   ` Konrad Dybcio
2024-04-16  6:35 ` [PATCH v2 3/8] ASoC: dt-bindings: wcd937x-sdw: add bindings for wcd937x-sdw Mohammad Rafi Shaik
2024-04-16  7:51   ` Rob Herring [this message]
2024-04-16 14:32   ` Rob Herring
2024-04-17  8:17     ` Mohammad Rafi Shaik
2024-04-17 15:52       ` Krzysztof Kozlowski
2024-04-17 15:56   ` Krzysztof Kozlowski
2024-04-22 10:37     ` Mohammad Rafi Shaik
2024-04-16  6:35 ` [PATCH v2 4/8] ASoC: codecs: wcd937x-sdw: add SoundWire driver Mohammad Rafi Shaik
2024-04-16  6:35 ` [PATCH v2 5/8] ASoC: codecs: wcd937x: add basic controls Mohammad Rafi Shaik
2024-04-16  6:35 ` [PATCH v2 6/8] ASoC: codecs: wcd937x: add playback dapm widgets Mohammad Rafi Shaik
2024-04-16  6:35 ` [PATCH v2 7/8] ASoC: codecs: wcd937x: add capture " Mohammad Rafi Shaik
2024-04-16  6:36 ` [PATCH v2 8/8] ASoC: codecs: wcd937x: add audio routing and Kconfig Mohammad Rafi Shaik
2024-04-16 12:40 ` [PATCH v2 0/8] ASoC: codecs: wcd937x: add wcd937x audio codec support Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171325390367.1353462.6738496215058640142.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@quicinc.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=quic_mohs@quicinc.com \
    --cc=quic_pkumpatl@quicinc.com \
    --cc=quic_rohkumar@quicinc.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox