From: Mark Brown <broonie@kernel.org>
To: lgirdwood@gmail.com, Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: linux-sound@vger.kernel.org,
pierre-louis.bossart@linux.intel.com,
kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com
Subject: Re: [PATCH] ASoC: SOF: sof-audio: Skip unprepare for in-use widgets on error rollback
Date: Thu, 13 Jun 2024 09:42:29 +0100 [thread overview]
Message-ID: <171826814960.249517.11714936800006262287.b4-ty@kernel.org> (raw)
In-Reply-To: <20240612121203.15468-1-peter.ujfalusi@linux.intel.com>
On Wed, 12 Jun 2024 15:12:03 +0300, Peter Ujfalusi wrote:
> If the ipc_prepare() callback fails for a module instance, on error rewind
> we must skip the ipc_unprepare() call for ones that has positive use count.
>
> The positive use count means that the module instance is in active use, it
> cannot be unprepared.
>
> The issue affects capture direction paths with branches (single dai with
> multiple PCMs), the affected widgets are in the shared part of the paths.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: SOF: sof-audio: Skip unprepare for in-use widgets on error rollback
commit: 6f2a43e3d14f6e31a3b041a1043195d02c54d615
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
next prev parent reply other threads:[~2024-06-13 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 12:12 [PATCH] ASoC: SOF: sof-audio: Skip unprepare for in-use widgets on error rollback Peter Ujfalusi
2024-06-13 8:42 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-06-03 7:26 Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171826814960.249517.11714936800006262287.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox