From: "Rob Herring (Arm)" <robh@kernel.org>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Maxime Ripard" <mripard@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Anatoliy Klymenko" <anatoliy.klymenko@amd.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org,
"Liam Girdwood" <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org,
"Mark Brown" <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-sound@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Vishal Sagar" <vishal.sagar@amd.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Rob Herring" <robh+dt@kernel.org>,
"Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
"Michal Simek" <michal.simek@amd.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
"David Airlie" <airlied@gmail.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs
Date: Wed, 11 Sep 2024 10:19:12 -0500 [thread overview]
Message-ID: <172606795201.325596.766778615878256783.robh@kernel.org> (raw)
In-Reply-To: <20240910-xilinx-dp-audio-v3-1-75560793f4d0@ideasonboard.com>
On Tue, 10 Sep 2024 14:19:19 +0300, Tomi Valkeinen wrote:
> The DP subsystem for ZynqMP supports audio via two channels, and the DP
> DMA has dma-engines for those channels. For some reason the DT binding
> has not specified those channels, even if the picture included in
> xlnx,zynqmp-dpsub.yaml shows "2 x aud" DMAs.
>
> This hasn't caused any issues as the drivers have not supported audio,
> and has thus gone unnoticed.
>
> To make it possible to add the audio support to the driver, add the two
> audio DMAs to the binding. While strictly speaking this is an ABI break,
> there should be no regressions caused by this as we're adding new
> entries at the end of the dmas list, and, after the audio support has
> been added in "arm64: dts: zynqmp: Add DMA for DP audio", the driver
> will treat the audio DMAs as optional to also support the old bindings.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2024-09-11 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 11:19 [PATCH v3 0/3] drm: xlnx: zynqmp: Add DP audio support Tomi Valkeinen
2024-09-10 11:19 ` [PATCH v3 1/3] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs Tomi Valkeinen
2024-09-11 15:19 ` Rob Herring (Arm) [this message]
2024-09-10 11:19 ` [PATCH v3 2/3] arm64: dts: zynqmp: Add DMA for DP audio Tomi Valkeinen
2024-10-08 8:22 ` Michal Simek
2024-10-23 12:00 ` Tomi Valkeinen
2024-10-23 12:50 ` Michal Simek
2024-09-10 11:19 ` [PATCH v3 3/3] drm: xlnx: zynqmp_dpsub: Add DP audio support Tomi Valkeinen
2024-09-10 15:30 ` Markus Elfring
2024-09-10 15:55 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172606795201.325596.766778615878256783.robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=anatoliy.klymenko@amd.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mripard@kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=vishal.sagar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox