Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: kuninori.morimoto.gx@renesas.com, Sen Wang <sen@ti.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	devarsht@ti.com,  v-singh1@ti.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: simple-card-utils: fix graph_util_is_ports0() for DT overlays
Date: Tue, 10 Mar 2026 18:29:12 +0000	[thread overview]
Message-ID: <177316735239.446684.9948986277661383645.b4-ty@kernel.org> (raw)
In-Reply-To: <20260309042109.2576612-1-sen@ti.com>

On Sun, 08 Mar 2026 23:21:09 -0500, Sen Wang wrote:
> graph_util_is_ports0() identifies DPCM front-end (ports@0) vs back-end
> (ports@1) by calling of_get_child_by_name() to find the first "ports"
> child and comparing pointers. This relies on child iteration order
> matching DTS source order.
> 
> When the DPCM topology comes from a DT overlay, __of_attach_node()
> inserts new children at the head of the sibling list, reversing the
> order. of_get_child_by_name() then returns ports@1 instead of ports@0,
> causing all front-end links to be classified as back-ends. The card
> registers with no PCM devices.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: simple-card-utils: fix graph_util_is_ports0() for DT overlays
      commit: 4185b95f8a42d92d68c49289b4644546b51e252b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


      parent reply	other threads:[~2026-03-10 18:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09  4:21 [PATCH v2] ASoC: simple-card-utils: fix graph_util_is_ports0() for DT overlays Sen Wang
2026-03-09 23:14 ` Kuninori Morimoto
2026-03-10 18:29 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177316735239.446684.9948986277661383645.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=devarsht@ti.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sen@ti.com \
    --cc=tiwai@suse.com \
    --cc=v-singh1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox