From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED8D3DA7E9; Wed, 18 Mar 2026 13:50:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773841844; cv=none; b=HkxXYJ2+abPBefixoYufDGzQJ2QiE7tixhg8xf8bdejw2pIaIUMwP76GgPIq2eRreD+KussLYEZiIP+7PdqveZ88DrLmP13eOnlY23t73yia0c1BDsbXeVGnnenXQ53stBrYFL7VuQVxlwNRC5ClKq1xBrAk6FV5Jv+z+8ErYDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773841844; c=relaxed/simple; bh=KWzc1RhRpcc1zceizbJVzn7r1CLlyMQaw4Z3lAe0GWE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qB4kal3KQCAdtX7XZc9sw8j81rwwlBzdbF1KNUcOkx+L5MuaBTJ1QS1odBWn2C45U+kf5ke1l0vBvClirUZ2DQqOtNG56QeGY6DAqw3vBCi31MrDfsjOQI9xLpKu8UTISlqG0YQVG/AnI9jY749CjORPKmCrtmxqNamKPsQfwhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PKktueFs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PKktueFs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2A75C19424; Wed, 18 Mar 2026 13:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773841844; bh=KWzc1RhRpcc1zceizbJVzn7r1CLlyMQaw4Z3lAe0GWE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PKktueFsubrLlQg02btkIb9U7h1du9eA2v15Uolv1AX53djENBo/UlLVylBPHHEKb b+ZMc+8uSSRCaZd+Ajl6F2h1IwAXoh+BHJhKzUu/zRjv9Q2wnyuWOLAVnR5zg0HiA/ 8ZrGnd/pAAF8YhkBUMegwZfBI1oGEOHxrgmhJidSrHb+L98vLt2/GJgid5gBmpz0U1 LpNboWefW/vDgmTKmcDZnGWSOgZqGrPv2C2yVVw6jVpxFt1zw0qdiaxdCXiPTVcr8I 5l5mmBd2RlG71q46pxzhaH/WA2lmQ/WkCbpZBkxsWsU3KENmzpqZhSbXIv7UgFrMLC CEbCDGKeLAnxQ== From: Bjorn Andersson To: konradybcio@kernel.org, Daniel Lezcano Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: Re: (subset) [PATCH v1 0/8] Group QMI service IDs into the QMI header Date: Wed, 18 Mar 2026 08:50:06 -0500 Message-ID: <177384182865.14526.18396654374290648632.b4-ty@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Tue, 10 Mar 2026 00:03:29 +0100, Daniel Lezcano wrote: > The different subsystems implementing the QMI service protocol are > using their own definition of the service id. It is not a problem but > it results on having those duplicated with different names but the > same value and without consistency in their name. > > It makes more sense to unify their names and move the definitions in > the QMI header file providing a consistent way to represent the > supported protocols. Consequently the different drivers will use them > instead of their own definition of the service id. > > [...] Applied, thanks! [8/8] samples: qmi: Use the unified QMI service ID instead of defining it locally commit: 8baf6b3b7695849581a91bdaf66af2be68ef32ed Best regards, -- Bjorn Andersson