From: "Shuming [范書銘]" <shumingf@realtek.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"Flove(HsinFu)" <flove@realtek.com>,
"Oder Chiou" <oder_chiou@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>
Subject: RE: [PATCH] ASoC: rt722: reset codec to fix abnormal sound
Date: Thu, 30 Jul 2026 02:47:10 +0000 [thread overview]
Message-ID: <1976f2661500474787fba73b496f2190@realtek.com> (raw)
In-Reply-To: <950e515e-0d5c-44c7-bc14-d9bdbe841182@sirena.org.uk>
> > The audio output may become abnormal after a warm reboot from
> Windows.
> > Reset the codec once during hardware initialization to restore it to a
> > known state and prevent the issue.
>
> > @@ -1888,6 +1899,9 @@ int rt722_sdca_io_init(struct device *dev, struct
> sdw_slave *slave)
> > rt722->hw_vid = (val & 0x0f00) >> 8;
> > dev_dbg(&slave->dev, "%s hw_vid=0x%x\n", __func__, rt722->hw_vid);
> >
> > + if (!rt722->first_hw_init)
> > + rt722_sdca_reset(rt722);
> > +
> > rt722_sdca_dmic_preset(rt722);
> > rt722_sdca_amp_preset(rt722);
> > rt722_sdca_jack_preset(rt722);
>
> Slirhgly separate issue but you probably need a _jack_init() after the reset -
> your other devices do that, I think there's some races there.
Understood. I'll add _jack_init() after the reset to avoid its settings being reset by the reset.
next prev parent reply other threads:[~2026-07-30 2:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 9:01 [PATCH] ASoC: rt722: reset codec to fix abnormal sound shumingf
2026-07-29 22:25 ` Mark Brown
2026-07-30 2:47 ` Shuming [范書銘] [this message]
2026-07-30 12:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1976f2661500474787fba73b496f2190@realtek.com \
--to=shumingf@realtek.com \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox