From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
linux-sound@vger.kernel.org, kai.vehmanen@linux.intel.com,
ranjani.sridharan@linux.intel.com,
yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
shengjiu.wang@nxp.com
Subject: Re: [PATCH] ASoC: soc-pcm: Preserve hw parameters from components in dpcm_runtime_setup_fe
Date: Mon, 27 Oct 2025 09:07:11 +0200 [thread overview]
Message-ID: <198b0f78-da46-4895-8f38-dc1aa398bfc2@linux.intel.com> (raw)
In-Reply-To: <87ms5comw9.wl-kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
On 27/10/2025 08:54, Kuninori Morimoto wrote:
>
> Hi Péter
>
> Thank you for your feedback
>
>> This is how the RFC was done, but decided to not modify
>> soc_pcm_hw_init() with an added bool.
>> Other option would be to add a new function which would do only
>> conditional initialization.
>
> Yes, I have noticed about this RFC, and you used other metod
> 083a25b18d6a.
I,m not sure what 083a25b18d6a is.
>> This way we would loose the rate_min, channel_min from components, see
>> my RFC which covers this, but it is using reverse condition (preserve vs
>> force).
>> The force boolean might be better than the preserve_config as parameter
>> if the preference is to modify the soc_pcm_hw_init()
>
> I guess you can ignore setup xx_min if "force" was set ?
Yes, in a same way as it was done in RFC under the preserve_config case.
> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto
>
--
Péter
next prev parent reply other threads:[~2025-10-27 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 8:14 [PATCH] ASoC: soc-pcm: Preserve hw parameters from components in dpcm_runtime_setup_fe Peter Ujfalusi
2025-10-27 6:11 ` Kuninori Morimoto
2025-10-27 6:20 ` Péter Ujfalusi
2025-10-27 6:54 ` Kuninori Morimoto
2025-10-27 7:07 ` Péter Ujfalusi [this message]
2025-10-28 21:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=198b0f78-da46-4895-8f38-dc1aa398bfc2@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=shengjiu.wang@nxp.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox