From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C08C013FD71 for ; Tue, 26 Mar 2024 20:24:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711484669; cv=none; b=Ec1r+ixFLmIO1y9qHBcgS7pw/czqfOK0VbBF66Ict9efkL4qsYfD5CHqCMSfY+9OdgO+nZ5AH1sV+GgYfkjO7Y5d/77GkflsRPcthDaeUHK3d4KMabWveXTOKPt33owjtQIx17B6Rzcxxb/GxHINknIJGVRW3vl2cM49M/qiX5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711484669; c=relaxed/simple; bh=3/laPbw4dZzLc5cIWlMGtQPK7sjd5djD9WWYkPnEIy8=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=Z81A+WZ8wGb13MUFDcdKzs7m8WypbL0T0nLoShoVfr1Q1EBMO7jiqLnNu9ZEAwnCxnxegVOYWptm0jecZ+Uy/hWh76BtQlx5tKZuClJc9paY77gQu7yvcY2gb+etIFZb5N8Faa6ZN95yTx+2izjgUEF9RPbwhqiaf7JXo/4WbYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=klP/P7wX; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="klP/P7wX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711484668; x=1743020668; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=3/laPbw4dZzLc5cIWlMGtQPK7sjd5djD9WWYkPnEIy8=; b=klP/P7wXjQS00YZMLKERRA4CvvhbqPheHUv6C0Dv5naQ188WAzPLCJE2 r597KLlQghsQMe1UTLrXAUvCmzWp/UdpBxMVtrCB3o5YfAzOsCP5I/dmt P/W3P2gg41dQ1XOEP4L9//yjbC6gaya+Yha926gszcxppgQ2heAAk/+Zp pgvVuzse1qdBgI1FIOFHm6e2LQxcQoi4fn3O3UohIwLl30lh48RkHzbK+ k3CqIhDNRqs/xaE41dcS6SxQesOQ69mWnj000XoHoshnGv/ZjJovSRwhP 3wlSSBwFsYfMgvYa7yHJ8d/QVlmBG7vzvj31eZgkX7qL3lkwkx1hnA+0r g==; X-CSE-ConnectionGUID: qsaor2KGRUaTRrBRDEAJDA== X-CSE-MsgGUID: aWGZDW3RSUaq1wQuyJKt1Q== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="17946346" X-IronPort-AV: E=Sophos;i="6.07,157,1708416000"; d="scan'208";a="17946346" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 13:24:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,157,1708416000"; d="scan'208";a="20716653" Received: from bhubbert-mobl.amr.corp.intel.com (HELO [10.212.65.108]) ([10.212.65.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 13:24:24 -0700 Message-ID: <1c437229-cbc7-4e0c-987c-9ca31800a572@linux.intel.com> Date: Tue, 26 Mar 2024 15:24:23 -0500 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/15] ASoC: Intel: replace dpcm_playback/capture to playback/capture_only Content-Language: en-US To: Kuninori Morimoto , =?UTF-8?Q?Amadeusz_S=C5=82awi=C5=84ski?= , Alper Nebi Yasak , AngeloGioacchino Del Regno , Banajit Goswami , Bard Liao , Brent Lu , Cezary Rojewski , Cristian Ciocaltea , Daniel Baluta , Hans de Goede , Jaroslav Kysela , Jerome Brunet , Kai Vehmanen , Kevin Hilman , Liam Girdwood , Linus Walleij , Mark Brown , Maso Huang , Matthias Brugger , Neil Armstrong , Peter Ujfalusi , Ranjani Sridharan , Sascha Hauer , Shawn Guo , Shengjiu Wang , Srinivas Kandagatla , Sylwester Nawrocki , Takashi Iwai , Trevor Wu , Vinod Koul , Xiubo Li , alsa-devel@alsa-project.org, imx@lists.linux.dev, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <87o7b353of.wl-kuninori.morimoto.gx@renesas.com> <87frwf53mq.wl-kuninori.morimoto.gx@renesas.com> From: Pierre-Louis Bossart In-Reply-To: <87frwf53mq.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Morimoto-san, > soc_get_playback_capture() is now handling DPCM and normal comprehensively > for playback/capture stream. We can use playback/capture_only flag > instead of using dpcm_playback/capture. This patch replace these. This patch no longer applies since Mark merged "[PATCH 00/21] ASoC: Intel: boards: updates for 6.10 - part1" https://lore.kernel.org/linux-sound/20240325221059.206042-1-pierre-louis.bossart@linux.intel.com/ The odds of additional conflicts are very high due to the number of queued changes in machine drivers, I really don't know how we're going to find the time to solve those conflicts and test experimental versions, while we're also busy checking the 6.9-rc1 transition. In addition, I have a bit of heartburn with the concept of flipping the logic from a clear description of playback or capture supported, to an implicit 'both supported unless stated otherwise'. We are going to miss some cases and have regressions, it's pretty much a given. And then there are cases such as the following examples > @@ -496,8 +494,6 @@ static struct snd_soc_dai_link cml_rt1011_rt5682_dailink[] = { > */ > .name = "SSP1-Codec", > .id = 6, > - .dpcm_playback = 1, > - .dpcm_capture = 1, /* Capture stream provides Feedback */ > .no_pcm = 1, > .init = cml_rt1011_spk_init, > .ops = &cml_rt1011_ops, > @@ -293,8 +291,6 @@ int sof_intel_board_set_ssp_amp_link(struct device *dev, > > link->id = be_id; > link->no_pcm = 1; > - link->dpcm_capture = 1; /* feedback stream or firmware-generated echo reference */ > - link->dpcm_playback = 1; > > return 0; > } > diff --git a/sound/soc/intel/boards/sof_da7219.c b/sound/soc/intel/boards/sof_da7219.c > index 6eb5a6144e97..c7cca3e47ed9 100644 > --- a/sound/soc/intel/boards/sof_da7219.c > +++ b/sound/soc/intel/boards/sof_da7219.c > @@ -296,8 +296,6 @@ static struct snd_soc_dai_link jsl_dais[] = { > .id = 0, > .ignore_pmdown_time = 1, > .no_pcm = 1, > - .dpcm_playback = 1, > - .dpcm_capture = 1, /* IV feedback */ > SND_SOC_DAILINK_REG(ssp1_pin, max_98373_components, platform), where we lose comments on what the capture stream is. That's not so good, we added those comments on purpose to explain that the capture stream isn't a regular PCM format, I don't see a good reason to see them go?