From: YLCHANG2 <neo.chang70@gmail.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>,
Neo Chang <YLCHANG2@nuvoton.com>
Cc: perex@perex.cz, tiwai@suse.com,
krzysztof.kozlowski@oss.qualcomm.com, dan.carpenter@linaro.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
kchsu0@nuvoton.com, broonie@kernel.org, lgirdwood@gmail.com,
linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: nau8325: Add software reset during probe
Date: Wed, 8 Apr 2026 16:51:04 +0800 [thread overview]
Message-ID: <1d0863b2-64f4-9f2f-94a3-3d730e9638f2@gmail.com> (raw)
In-Reply-To: <08462a39-61e2-4125-957e-9454751b011e@intel.com>
On 4/8/26 16:07, Cezary Rojewski wrote:
> On 2026-04-08 7:26 AM, Neo Chang wrote:
>> Currently, the driver only performs a hardware reset during the I2C
>> probe
>> sequence. To ensure all internal states of the codec are properly
>> cleared
>> without affecting the configuration registers, a software reset is also
>> required.
>>
>> According to the hardware specification, writing to the Software Reset
>> register (R01) twice will reset all internal states safely.
>>
>> This patch adds the nau8325_software_reset() function, executes it right
>> after the hardware reset in the probe function, and marks the R01
>> register
>> as writeable in the regmap configuration.
>
> The first two paragraphs explain the situation, I'd say the third is
> redundant. Not a reason for a resend though, only something to consider.
>
> Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Thank you for the review and the advice on the commit message.
I will keep it in mind for the next time.
next prev parent reply other threads:[~2026-04-08 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 5:26 [PATCH] ASoC: nau8325: Add software reset during probe Neo Chang
2026-04-08 8:07 ` Cezary Rojewski
2026-04-08 8:51 ` YLCHANG2 [this message]
2026-04-08 12:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d0863b2-64f4-9f2f-94a3-3d730e9638f2@gmail.com \
--to=neo.chang70@gmail.com \
--cc=YLCHANG2@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=kchsu0@nuvoton.com \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox