Linux Sound subsystem development
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Cc: kernel@collabora.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/6] ASoC: mediatek: mt8188: Add reference for dmic clocks
Date: Wed, 19 Feb 2025 12:29:21 +0100	[thread overview]
Message-ID: <1dc0da53-0bc1-41f2-8478-f72bd0f33115@collabora.com> (raw)
In-Reply-To: <20250218-genio700-dmic-v1-2-6bc653da60f7@collabora.com>

Il 18/02/25 21:52, Nícolas F. R. A. Prado ha scritto:
> Add the names for the dmic clocks, aud_afe_dmic* and aud_dmic_hires*, so
> they can be acquired and enabled by the platform driver.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
>   sound/soc/mediatek/mt8188/mt8188-afe-clk.c | 8 ++++++++
>   sound/soc/mediatek/mt8188/mt8188-afe-clk.h | 8 ++++++++
>   2 files changed, 16 insertions(+)
> 
> diff --git a/sound/soc/mediatek/mt8188/mt8188-afe-clk.c b/sound/soc/mediatek/mt8188/mt8188-afe-clk.c
> index e69c1bb2cb239596dee50b166c20192d5408be10..44c25b6e3d873448163b22e70f5b94cb5070654d 100644
> --- a/sound/soc/mediatek/mt8188/mt8188-afe-clk.c
> +++ b/sound/soc/mediatek/mt8188/mt8188-afe-clk.c
> @@ -58,6 +58,14 @@ static const char *aud_clks[MT8188_CLK_NUM] = {
>   	[MT8188_CLK_AUD_ADC] = "aud_adc",
>   	[MT8188_CLK_AUD_DAC_HIRES] = "aud_dac_hires",
>   	[MT8188_CLK_AUD_A1SYS_HP] = "aud_a1sys_hp",
> +	[MT8188_CLK_AUD_AFE_DMIC1] = "aud_afe_dmic1",
> +	[MT8188_CLK_AUD_AFE_DMIC2] = "aud_afe_dmic2",
> +	[MT8188_CLK_AUD_AFE_DMIC3] = "aud_afe_dmic3",
> +	[MT8188_CLK_AUD_AFE_DMIC4] = "aud_afe_dmic4",
> +	[MT8188_CLK_AUD_DMIC_HIRES1] = "aud_dmic_hires1",
> +	[MT8188_CLK_AUD_DMIC_HIRES2] = "aud_dmic_hires2",
> +	[MT8188_CLK_AUD_DMIC_HIRES3] = "aud_dmic_hires3",
> +	[MT8188_CLK_AUD_DMIC_HIRES4] = "aud_dmic_hires4",
>   	[MT8188_CLK_AUD_ADC_HIRES] = "aud_adc_hires",
>   	[MT8188_CLK_AUD_I2SIN] = "aud_i2sin",
>   	[MT8188_CLK_AUD_TDM_IN] = "aud_tdm_in",
> diff --git a/sound/soc/mediatek/mt8188/mt8188-afe-clk.h b/sound/soc/mediatek/mt8188/mt8188-afe-clk.h
> index ec53c171c170a8b4b47900e63ef79d53641e9b12..68c46feb72271b950d4e538f63cedf524354147e 100644
> --- a/sound/soc/mediatek/mt8188/mt8188-afe-clk.h
> +++ b/sound/soc/mediatek/mt8188/mt8188-afe-clk.h
> @@ -54,6 +54,14 @@ enum {
>   	MT8188_CLK_AUD_ADC,
>   	MT8188_CLK_AUD_DAC_HIRES,
>   	MT8188_CLK_AUD_A1SYS_HP,
> +	MT8188_CLK_AUD_AFE_DMIC1,
> +	MT8188_CLK_AUD_AFE_DMIC2,
> +	MT8188_CLK_AUD_AFE_DMIC3,
> +	MT8188_CLK_AUD_AFE_DMIC4,
> +	MT8188_CLK_AUD_DMIC_HIRES1,
> +	MT8188_CLK_AUD_DMIC_HIRES2,
> +	MT8188_CLK_AUD_DMIC_HIRES3,
> +	MT8188_CLK_AUD_DMIC_HIRES4,
>   	MT8188_CLK_AUD_ADC_HIRES,

Following the comments from audsys, put those after CLK_AUD_ADC_HIRES.

Cheers,
Angelo

>   	MT8188_CLK_AUD_I2SIN,
>   	MT8188_CLK_AUD_TDM_IN,
> 


  reply	other threads:[~2025-02-19 11:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 20:52 [PATCH 0/6] Enable DMIC for Genio 700/510 EVK Nícolas F. R. A. Prado
2025-02-18 20:52 ` [PATCH 1/6] ASoC: mediatek: mt8188: Add audsys hires clocks Nícolas F. R. A. Prado
2025-02-19 11:29   ` AngeloGioacchino Del Regno
2025-02-18 20:52 ` [PATCH 2/6] ASoC: mediatek: mt8188: Add reference for dmic clocks Nícolas F. R. A. Prado
2025-02-19 11:29   ` AngeloGioacchino Del Regno [this message]
2025-02-18 20:52 ` [PATCH 3/6] ASoC: mediatek: mt8188: Add DMIC DAI driver Nícolas F. R. A. Prado
2025-02-19 11:29   ` AngeloGioacchino Del Regno
2025-02-18 20:52 ` [PATCH 4/6] ASoC: mediatek: mt8188: Support DMIC in AFE Nícolas F. R. A. Prado
2025-02-19 11:29   ` AngeloGioacchino Del Regno
2025-02-19 13:40     ` Nícolas F. R. A. Prado
2025-02-19 13:43       ` AngeloGioacchino Del Regno
2025-02-18 20:52 ` [PATCH 5/6] ASoC: mediatek: mt8188-mt6359: Add DMIC Nícolas F. R. A. Prado
2025-02-19 11:29   ` AngeloGioacchino Del Regno
2025-02-18 20:52 ` [PATCH 6/6] arm64: dts: mediatek: mt8390-genio-common: Add routes for DMIC Nícolas F. R. A. Prado
2025-02-19  4:29   ` Chen-Yu Tsai
2025-02-19 13:30     ` Nícolas F. R. A. Prado
2025-02-19 11:29   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dc0da53-0bc1-41f2-8478-f72bd0f33115@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox