From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59FD217E4; Mon, 8 Dec 2025 08:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765180911; cv=none; b=phSXBCekfOJoRx/RivaMaArgio8z+mDa/5PSm1TYGeDHvoEXxV9rIicwY1HdNkdWagfg89QNkMiah0oIV5P7VO5Zlp1IycbPINKDOkeWGTyh4c6r2JIB68/lvX1sFEtzlLeEAAZXkWOL9ihPeEGjgN2cpwfjHR+grhvtVbtad0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765180911; c=relaxed/simple; bh=4o3k84cSoFVkEFHqlP6kdQk46PTl+iYPVlvk6x9AM7s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HZ+tizFGNU5x6NciTcS397tXaTPPtLSm87QtEJ3+TlgrJyx+bfM/9eCmGjsL1toLQuAcBSSsuHX4UN05Vkf1O4FVrx8iY9AcY4TUlbWLbJh12Zs92XSXEv+eHzyvuQ5asehSBIyuOIQiuCnZv4OCe4reTOU63D+SRMeRmJr3U/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j80OI97R; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j80OI97R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8F3AC4CEF1; Mon, 8 Dec 2025 08:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765180910; bh=4o3k84cSoFVkEFHqlP6kdQk46PTl+iYPVlvk6x9AM7s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=j80OI97RKDz5Ua10r/90B/K+sulEdDJuikydKmNdFReRjDbRKtscr7GEFvSM7UmQE js3dhNXoqAa8gRmiDsa3mCnJTAcjGfZIPvuB3Ata/c6ut1BIPGqrLKgcdCIBIga0Ys 1iRszMxja7QCJylYxdbmSHgOnFduswhEzt6hVw9CC7nGJ7BCMk6ko2WRzMhNB9AjYF vvgGpMhlLmKl3+TNDs1wTYf7K8oO4s5meSeridMesNeSAwlOesM1s/1DserQs63QCb IO30I2IMrT6++rEpc7Jl7h1TyKqsVcP7WGAeATWxkcnTw3e08v3MIMJFH8kjvuItFO oig7shpTY8BTA== Message-ID: <20065270-0d88-4463-9641-f92b4c9e4674@kernel.org> Date: Mon, 8 Dec 2025 09:01:46 +0100 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/2] ASoC: rt5575: Add the codec driver for the ALC5575 To: Oder Chiou , "cezary.rojewski@intel.com" , "broonie@kernel.org" , "lgirdwood@gmail.com" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" Cc: "perex@perex.cz" , "linux-sound@vger.kernel.org" , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , "Flove(HsinFu)" , =?UTF-8?B?U2h1bWluZyBb6IyD5pu46YqYXQ==?= , Jack Yu , =?UTF-8?B?RGVyZWsgW+aWueW+t+e+qV0=?= References: <20251201105926.1714341-1-oder_chiou@realtek.com> <20251201105926.1714341-2-oder_chiou@realtek.com> <6c0639e2-dc59-4e0f-be42-224a98b37f75@kernel.org> <2202b463075f4219bffc636fbafb0684@realtek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <2202b463075f4219bffc636fbafb0684@realtek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08/12/2025 08:29, Oder Chiou wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Monday, December 8, 2025 2:05 PM >> To: Oder Chiou ; cezary.rojewski@intel.com; >> broonie@kernel.org; lgirdwood@gmail.com; robh@kernel.org; >> krzk+dt@kernel.org; conor+dt@kernel.org >> Cc: perex@perex.cz; linux-sound@vger.kernel.org; devicetree@vger.kernel.org; >> alsa-devel@alsa-project.org; Flove(HsinFu) ; Shuming [范 >> 書銘] ; Jack Yu ; Derek [方德 >> 義] >> Subject: Re: [PATCH v8 1/2] ASoC: rt5575: Add the codec driver for the >> ALC5575 >> >> >> External mail : This email originated from outside the organization. Do not >> reply, click links, or open attachments unless you recognize the sender and >> know the content is safe. >> >> >> >> On 01/12/2025 11:59, Oder Chiou wrote: >>> + >>> +static int rt5575_i2c_read(void *context, unsigned int reg, unsigned int >> *val) >>> +{ >>> + struct i2c_client *client = context; >>> + struct rt5575_priv *rt5575 = i2c_get_clientdata(client); >>> + >>> + regmap_read(rt5575->dsp_regmap, reg | RT5575_DSP_MAPPING, >> val); >>> + >>> + return 0; >>> +} >>> + >>> +static int rt5575_i2c_write(void *context, unsigned int reg, unsigned int val) >>> +{ >>> + struct i2c_client *client = context; >>> + struct rt5575_priv *rt5575 = i2c_get_clientdata(client); >>> + >>> + regmap_write(rt5575->dsp_regmap, reg | RT5575_DSP_MAPPING, >> val); >>> + >>> + return 0; >>> +} >>> + >>> +static const struct regmap_config rt5575_regmap = { >>> + .reg_bits = 16, >>> + .val_bits = 32, >>> + .reg_stride = 4, >>> + .max_register = 0xfffc, >>> + .readable_reg = rt5575_readable_register, >>> + .reg_read = rt5575_i2c_read, >>> + .reg_write = rt5575_i2c_write, >>> + .use_single_read = true, >>> + .use_single_write = true, >>> +}; >> >> OF device ID table goes around here - together with I2C. > I will correct it. > >>> + >>> +static const struct i2c_device_id rt5575_i2c_id[] = { >>> + { "rt5575" }, >>> + { } >>> +}; >>> +MODULE_DEVICE_TABLE(i2c, rt5575_i2c_id); >>> + >>> +static int rt5575_i2c_probe(struct i2c_client *i2c) >>> +{ >>> + struct rt5575_priv *rt5575; >>> + struct device *dev = &i2c->dev; >>> + int ret, val; >>> + >>> +#if IS_ENABLED(CONFIG_SND_SOC_RT5575_SPI) >> >> No ifdefs in driver code. > > I am not understanding exactly. > If the machine is without SPI interface and the codec with flash, the > CONFIG_SND_SOC_RT5575_SPI can be disabled. But you still should not use #ifdef. Coding style gives you alternative, please look at the doc. > >>> + if (!rt5575_spi && of_device_is_compatible(dev->of_node, >> rt5575_of_match[1].compatible)) >> >> No, use driver match data if ever, but this is just wrong. You said it >> depends on SPI flash, not SPI interface. > > I will modify it to use the match data as following. > static const struct of_device_id rt5575_of_match[] = { > { .compatible = "realtek,rt5575", .data = (void *)RT5575_WITH_FLASH }, > { .compatible = "realtek,rt5575-use-spi", .data = (void *)RT5575_WITHOUT_FLASH }, What is still wrong is that why you defer probe if there is no flash. I really do not get it... Best regards, Krzysztof