From: "Scott Thompson" <postfail@hushmail.com>
To: tiwai@suse.de
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org
Subject: Re: [PATCH 2/3] sound/pci ioremap/iounmap balancing
Date: Wed, 01 Aug 2007 13:25:51 +0000 [thread overview]
Message-ID: <20070801132551.5A8132281F@mailserver9.hushmail.com> (raw)
In-Reply-To: <20070801060256.F0BA2DA820@mailserver8.hushmail.com>
On Wed, 01 Aug 2007 06:38:16 -0400 Takashi Iwai <tiwai@suse.de>
wrote:
>This would be rater a lacking check of returned errors.
>
>The other changes look incorrect. All these drivers use
>card->private_free callback to release the resources even for the
>error exit. Thus, you don't need iounmap in each place.
>
>
>thanks,
>
>Takashi
Missed the callback on the audit, will repost this patch
(sound/pci) with just the unchecked returns...
---------------------------------------
Scott Thompson / postfail@hushmail.com
---------------------------------------
--
Click here for a free search to find a personal injury lawyer in your area.
http://tagline.hushmail.com/fc/Ioyw6h4fOfoaL5grSba8qnlenBibb9zjK5zUaQHZiVV0JZfJFmwnj3/
prev parent reply other threads:[~2007-08-01 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 6:02 [PATCH 2/3] sound/pci ioremap/iounmap balancing Scott Thompson
2007-08-01 10:38 ` Takashi Iwai
2007-08-01 13:25 ` Scott Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070801132551.5A8132281F@mailserver9.hushmail.com \
--to=postfail@hushmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox