From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
Wolfram Sang <w.sang@pengutronix.de>,
linux-sound@vger.kernel.org, Bo Shen <voice.shen@atmel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ASoC: atmel-ssc: use module_platform_driver macro
Date: Tue, 16 Oct 2012 08:49:47 +0000 [thread overview]
Message-ID: <20121016084947.GD12801@game.jcrosoft.org> (raw)
In-Reply-To: <507D15C2.7000606@atmel.com>
On 10:07 Tue 16 Oct , Nicolas Ferre wrote:
> On 10/16/2012 05:56 AM, Bo Shen :
> > This patch removes some code duplication by using module_platform_driver
> >
> > Signed-off-by: Bo Shen <voice.shen@atmel.com>
>
> Very good simplification but...
>
> > ---
> > drivers/misc/atmel-ssc.c | 18 ++++--------------
> > 1 file changed, 4 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> > index 23dcb76..ac00f83 100644
> > --- a/drivers/misc/atmel-ssc.c
> > +++ b/drivers/misc/atmel-ssc.c
> > @@ -68,7 +68,7 @@ void ssc_free(struct ssc_device *ssc)
> > }
> > EXPORT_SYMBOL(ssc_free);
> >
> > -static int __init ssc_probe(struct platform_device *pdev)
> > +static int ssc_probe(struct platform_device *pdev)
>
> Here you remove the __init altogether, maybe converting to __devinit is
> the proper replacement for this? I do not know myself but if anybody knows?
yes __devinit is mandatory
Best Regards,
J.
next prev parent reply other threads:[~2012-10-16 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 3:56 [PATCH 1/2] ASoC: atmel-ssc: use devm_xxx() managed function Bo Shen
2012-10-16 3:56 ` [PATCH 2/2] ASoC: atmel-ssc: use module_platform_driver macro Bo Shen
2012-10-16 8:07 ` Nicolas Ferre
2012-10-16 8:49 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-10-16 8:59 ` Bo Shen
2012-10-16 9:07 ` Russell King - ARM Linux
2012-10-16 9:32 ` Fabio Porcedda
2012-10-16 5:12 ` [PATCH 1/2] ASoC: atmel-ssc: use devm_xxx() managed function Mark Brown
2012-10-16 8:05 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016084947.GD12801@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=voice.shen@atmel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox