Re: [Resend PATCH v3 2/4] ARM: at91: atmel-ssc: add device tree support

Jean-Christophe PLAGNIOL-VILLARD
2012-11-07T15:14:41Z

On 15:44 Wed 07 Nov , Mark Brown wrote:
> On Wed, Nov 07, 2012 at 03:30:46PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
>
> > the one via ASoC for the driver with the pinctrl for now but MUST add it later
>
> > the arch/arm related via AT91 tree where the pinctrl is mandatory in the dtsi
>
> > I'm no going to spend hours to do the pinctrl to test Bo patch that he is
> > supposed to have deon to test this code
>
> > As basically today on DT none of the board will work if BO does no provide the
> > pinctrl so for me he MUST put in the dtsi
>
> > is it ok with you?
>
> Or add the pinmux bindings for other IPs over in the pinmux branch and
> the pinmux binding for SSC here (which will help with bisection as the
> DT bindings for the audio will then always exist in conjunction with the
> .dtsi changes for them). Either way is fine with me; I'll leave things
> as they are until I see some new patches.
>
> Though I have to say now that I look in -next it's a bit surprising that
> there are so many IPs in the file that have no pinmix configuration,
> based on what you're saying it seems like the entire board will be
> falling over with the pinmux code anyway - in the case of the sam9g20ek
> we'd at least need I2C pinmux settings. I may be misunderstanding.

yes I've a new patch series that finish to add them as they was in the Dt
before the add of the pinctrl (macb/usb device /host) i2c after as on 9g20ek
we use gpio i2c so no need to do any pinctrl for now

but now new switch to DT must handle the pinctrl

Best Regards,
J.