From: Mark Brown <broonie@kernel.org>
To: Bo Shen <voice.shen@atmel.com>
Cc: nicolas.ferre@atmel.com, plagnioj@jcrosoft.com,
linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ASoC: atmel_wm8904: make it available to choose clock
Date: Mon, 27 Jan 2014 20:59:25 +0000 [thread overview]
Message-ID: <20140127205925.GE11841@sirena.org.uk> (raw)
In-Reply-To: <52D7366B.1030909@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On Thu, Jan 16, 2014 at 09:31:23AM +0800, Bo Shen wrote:
> >Shouldn't this code be in the DAI driver? Otherwise this series looks
> >fine to me, though the DT folks might have something to say I guess.
> For audio on Atmel SoC, it depends on three device nodes, one is
> SSC node, one is the codec node and the sound node.
> The sound node will parse by machine driver, and machine driver is
> mainly for hardware connection. As the "clk_from_rk_pin" is decided
> by hardware, so, I put it here.
> If I move the code to dai driver, it will parse the sound node in
> dai driver, I think it will make the code a little bit not explicit.
> What do you think?
I think it should just be a property of the DAI device. It's true that
the card defines the connections but if something is going to be an
option that's there for most if not all systems then putting it in the
device driver means less effort on each integration.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-27 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 3:25 [PATCH 0/3] ASoC: atmel_ssc_dai: add option to choose clock Bo Shen
2014-01-14 3:25 ` [PATCH 1/3] ASoC: atmel_ssc_dai: make " Bo Shen
2014-01-14 3:25 ` [PATCH 2/3] ASoC: atmel_wm8904: make it available " Bo Shen
2014-01-14 20:36 ` Mark Brown
2014-01-16 1:31 ` Bo Shen
2014-01-27 20:59 ` Mark Brown [this message]
2014-01-15 17:16 ` Nicolas Ferre
2014-01-14 3:25 ` [PATCH 3/3] Binding: atmel-wm8904: add option " Bo Shen
2014-01-15 11:54 ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-16 1:33 ` Bo Shen
2014-01-16 11:03 ` Mark Brown
2014-01-15 17:17 ` Nicolas Ferre
2014-01-16 1:38 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127205925.GE11841@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=perex@perex.cz \
--cc=plagnioj@jcrosoft.com \
--cc=tiwai@suse.de \
--cc=voice.shen@atmel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox