Re: [RFC PATCH] ASoC: wm8904: add CCF support

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

On Fri, Mar 21, 2014 at 10:37:47AM +0000, Mark Rutland wrote:
> On Fri, Mar 21, 2014 at 02:51:02AM +0000, Bo Shen wrote:

> > +  - wlf,sysclk-from-mclk: set the sys clock is driven from mclk,

> Why can the kernel not decide this?

It can.

> > +    - wlf,mclk-use-xtal: if the mclk is generated by crystal.
> > +      if without this property, the mclk is generated from SOC.

> Huh? What exact property do you actually are about here?

This should just be omitted - based on the previous posting it's saying
if this is a fixed or variable rate clock.

> > +    - wlf,mclk-freq: mclk's frequency

> If you expect mclk, you should be able to query this from it. You don't
> need a separate property.

> Unless this is a frequency to set it to? If so, why can the kernel not
> choose this?

Yes, quite - and even if it needs to be set explicitly the clock API
generic bindings should be able to support this (I *think* that is due
to go in during the next merge window but iddn't check yet).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]