From: Mark Brown <broonie@kernel.org>
To: Bo Shen <voice.shen@atmel.com>
Cc: nicolas.ferre@atmel.com, b.brezillon.dev@gmail.com,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
linux-sound@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [RFC v2 PATCH] ASoC: wm8904: add CCF support
Date: Tue, 25 Mar 2014 11:27:16 +0000 [thread overview]
Message-ID: <20140325112716.GS2269@sirena.org.uk> (raw)
In-Reply-To: <1395741416-23981-1-git-send-email-voice.shen@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On Tue, Mar 25, 2014 at 05:56:56PM +0800, Bo Shen wrote:
> case SND_SOC_BIAS_ON:
> + if (IS_ENABLED(CONFIG_COMMON_CLK))
> + if (wm8904->mclk)
> + clk_prepare_enable(wm8904->mclk);
No, this shouldn't depend on COMMON_CLK - there is no reason other clock
API implementations shouldn't be able to use this. Providing a clock is
something you can only do with COMMON_CLK but using one doesn't need
that, generally using a clock is done unconditionally.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-25 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 9:56 [RFC v2 PATCH] ASoC: wm8904: add CCF support Bo Shen
2014-03-25 11:27 ` Mark Brown [this message]
2014-03-26 1:32 ` [alsa-devel] " Bo Shen
2014-03-25 11:59 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325112716.GS2269@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=b.brezillon.dev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox